Project foundation for the taken-over SPA #1

Merged
ai-reviewer merged 4 commits from claude-code/project-foundation into main 2026-10-14 16:46:23 +02:00
Collaborator

Adds README, AGENTS.md, CLAUDE.md, the shared workflow, PR documents, the plan, the risk analysis, .werkrevisor.toml and .gitignore to the unchanged SPA on main.

See docs/prs/2026-10-14-PR#1-project-foundation.md.

🤖 Generated with Claude Code

Adds README, AGENTS.md, CLAUDE.md, the shared workflow, PR documents, the plan, the risk analysis, .werkrevisor.toml and .gitignore to the unchanged SPA on main. See docs/prs/2026-10-14-PR#1-project-foundation.md. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
claude-code added 1 commit 2026-10-14 13:21:11 +02:00
claude-code added 1 commit 2026-10-14 13:26:37 +02:00
The browser check of the unchanged page found one failure:
the copyright, imprint and privacy links of the framed views turn the view blank.
It is planned as a follow-up, since this PR changes no behaviour.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-code added 1 commit 2026-10-14 14:17:12 +02:00
claude-code added 1 commit 2026-10-14 16:38:22 +02:00
Plan: Werkkompass moves to werkkompass.javagil.de
ai-review/assessment human review required; a human approval unlocks the merge; review requested from mi; merge scheduled for when the checks succeed
ai-review/gate build succeeded after 02:35
727ee93db4
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-code marked the pull request as ready for review 2026-10-14 16:41:49 +02:00
Collaborator

🟡 werkrevisor: YELLOW / HUMAN_REVIEW

Change kind: mixed.

Reasons

  • YELLOW risky paths changed: .werkrevisor.toml (built in)
  • hint 2 changed file(s) that neither weaken the checks nor touch security according to Jev
  • hint files the model cannot review: .gitignore (advisory: Jev judged every changed file)
  • hint 3 finding(s) of low severity or rated minor by Jev: docs/prs/2026-10-14-PR#1-project-foundation.md:52, .werkrevisor.toml:25-27, README.md:47-48
  • hint model recommends changes before merge

Findings

  1. [medium] PR doc lists .gitignore, but it is not in the diff at docs/prs/2026-10-14-PR#1-project-foundation.md:52, hint, as a line comment

  2. [low] Garbled comment at .werkrevisor.toml:25-27, hint, as a line comment

  3. [low] Install destination differs from published URL at README.md:47-48

    hint

    The README states that install-vibe-engineering-webapp uploads an HTML file to javagil.de/vibe-engineering.html, but the PR document and the workflow list the published version as https://javagil.de/vibe-engineering (without the .html extension). The relationship between these two URLs (server alias, rewrite, or tool-side rename) is not explained, leaving the installation instructions at odds with the published address.

Classifier

9 of 9 units passed all questions (1 PR document(s)).
1 answer ignored because of a confidence below [classifier] min_confidence.

Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 14231, calls 1, tokens in 13658 / out 19182 (reasoning included in out), duration 150.4 s, cost 0.0271 USD (reported), classifier `jev-1.13.0` calls 9, tokens in 6942, cost 0.0003 USD, finding judge `jev-1.13.0` calls 1, tokens in 1679, cost 0.0001 USD, build file judge `jev-1.13.0` calls 2, tokens in 869, cost 0.0000 USD, phases: path_judge 0.3 s, classifier 0.7 s, context 0.4 s, model_review 147.8 s, finding_judge 0.3 s, config: defaults + host.
Reviewed head `727ee93db48b91361e708df0f2444ff07bfe49f9` against base `27da46219e5b6e390628f1046fa8de02c7545ab2`, werkrevisor 0.41.2.
<!-- werkrevisor:727ee93db48b91361e708df0f2444ff07bfe49f9 --> <!-- werkrevisor-verdict:YELLOW --> <!-- werkrevisor-blocks:0848ec992deeb2ce33402c7461a9d4e8,d878eafb704cb865a69fb8551579f172,c91b9eec3737bde89cf417c3bfae1a5e,71f8e433ebf8c0bb165c402ba5d121dd,26022ad65c78e33416bc97cd3930849f,219107b8acb48199fc324d72490f1dc6,c3cd72bfc5f5454bd6a3001c2a47ec5a,29f2e338a2ca6a060cca01c886964470,fec9f73296d1d69b8c275fb3ce99231d,4a01f7a65140d3ff19c0ef00d7c1dfb1,5ac9651fcd7109b0dc303e70fa1b6703,519146f5e8c5f16a42be90556ce211af --> ## 🟡 werkrevisor: YELLOW / HUMAN_REVIEW Change kind: `mixed`. ### Reasons - **YELLOW** risky paths changed: .werkrevisor.toml (built in) - **hint** 2 changed file(s) that neither weaken the checks nor touch security according to Jev - **hint** files the model cannot review: .gitignore (advisory: Jev judged every changed file) - **hint** 3 finding(s) of low severity or rated minor by Jev: docs/prs/2026-10-14-PR#1-project-foundation.md:52, .werkrevisor.toml:25-27, README.md:47-48 - **hint** model recommends changes before merge ### Findings 1. **[medium] PR doc lists .gitignore, but it is not in the diff** at `docs/prs/2026-10-14-PR#1-project-foundation.md:52`, hint, as a line comment 2. **[low] Garbled comment** at `.werkrevisor.toml:25-27`, hint, as a line comment 3. **[low] Install destination differs from published URL** at `README.md:47-48` hint The README states that `install-vibe-engineering-webapp` uploads an HTML file to `javagil.de/vibe-engineering.html`, but the PR document and the workflow list the published version as `https://javagil.de/vibe-engineering` (without the `.html` extension). The relationship between these two URLs (server alias, rewrite, or tool-side rename) is not explained, leaving the installation instructions at odds with the published address. ### Classifier 9 of 9 units passed all questions (1 PR document(s)). 1 answer ignored because of a confidence below [classifier] min_confidence. <sub> Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 14231, calls 1, tokens in 13658 / out 19182 (reasoning included in out), duration 150.4 s, cost 0.0271 USD (reported), classifier `jev-1.13.0` calls 9, tokens in 6942, cost 0.0003 USD, finding judge `jev-1.13.0` calls 1, tokens in 1679, cost 0.0001 USD, build file judge `jev-1.13.0` calls 2, tokens in 869, cost 0.0000 USD, phases: path_judge 0.3 s, classifier 0.7 s, context 0.4 s, model_review 147.8 s, finding_judge 0.3 s, config: defaults + host.<br> Reviewed head `727ee93db48b91361e708df0f2444ff07bfe49f9` against base `27da46219e5b6e390628f1046fa8de02c7545ab2`, werkrevisor 0.41.2. </sub>
ai-reviewer left a comment
Collaborator

werkrevisor: YELLOW / HUMAN_REVIEW for 727ee93db48b91361e708df0f2444ff07bfe49f9.
The result comment of werkrevisor holds the details.

werkrevisor: YELLOW / HUMAN_REVIEW for `727ee93db48b91361e708df0f2444ff07bfe49f9`. The result comment of werkrevisor holds the details. <!-- werkrevisor-review:727ee93db48b91361e708df0f2444ff07bfe49f9 -->
@@ -0,0 +22,4 @@
name = "form_data_integrity"
action = "off"
# The levels of the required checks need the human (docs/agentic-workflow.md, "Required Checks"):
Collaborator

[low] Garbled comment (werkrevisor)

hint

The comment at lines 25-27 is garbled: the colon at the end of line 25 leads to nowhere, and the next line ("the risk analysis that sets them.") reads as a separate fragment whose antecedent is unclear. The intent (that the required-check levels need the human and are set by the risk analysis, and that the repository's secret paths replace the host's) is not conveyed by the current text.

**[low] Garbled comment** (werkrevisor) hint The comment at lines 25-27 is garbled: the colon at the end of line 25 leads to nowhere, and the next line ("the risk analysis that sets them.") reads as a separate fragment whose antecedent is unclear. The intent (that the required-check levels need the human and are set by the risk analysis, and that the repository's secret paths replace the host's) is not conveyed by the current text.
claude-code marked this conversation as resolved
@@ -0,0 +49,4 @@
- `docs/risk-analysis.md`: criticality low, set by the human as a deviation from the table of the workflow.
- `.werkrevisor.toml`: the template `typescript-frontend` without the categories for login, tokens, API and forms.
werkrevisor reads it from `main`, so it applies from the next PR on.
- `.gitignore`: editor files and the local state of coding agents; nothing is generated yet.
Collaborator

[medium] PR doc lists .gitignore, but it is not in the diff (werkrevisor)

hint; Jev: real 0.80, severity 1.4 of 3

The PR document under "Files" lists .gitignore as one of the files added in this PR (and the PR description also mentions it), yet the actual diff contains no .gitignore. This is a direct contradiction between the PR document and the code: either the file should be added, or the PR document and PR description should be updated to reflect what is actually being merged.

**[medium] PR doc lists .gitignore, but it is not in the diff** (werkrevisor) hint; Jev: real 0.80, severity 1.4 of 3 The PR document under "Files" lists `.gitignore` as one of the files added in this PR (and the PR description also mentions it), yet the actual diff contains no `.gitignore`. This is a direct contradiction between the PR document and the code: either the file should be added, or the PR document and PR description should be updated to reflect what is actually being merged.
claude-code marked this conversation as resolved
ai-reviewer scheduled this pull request to auto merge when all checks succeed 2026-10-14 16:44:32 +02:00
ai-reviewer requested review from mi 2026-10-14 16:44:32 +02:00
@@ -0,0 +49,4 @@
- `docs/risk-analysis.md`: criticality low, set by the human as a deviation from the table of the workflow.
- `.werkrevisor.toml`: the template `typescript-frontend` without the categories for login, tokens, API and forms.
werkrevisor reads it from `main`, so it applies from the next PR on.
- `.gitignore`: editor files and the local state of coding agents; nothing is generated yet.
Author
Collaborator

Not a contradiction: .gitignore is part of the diff, added in 1c74aad with 10 lines (git diff --stat 27da462 727ee93). The result comment says why the model did not see it: "files the model cannot review: .gitignore". No change.

Not a contradiction: `.gitignore` is part of the diff, added in `1c74aad` with 10 lines (`git diff --stat 27da462 727ee93`). The result comment says why the model did not see it: "files the model cannot review: .gitignore". No change.
claude-code marked this conversation as resolved
mi approved these changes 2026-10-14 16:46:21 +02:00
ai-reviewer merged commit b20be0a743 into main 2026-10-14 16:46:23 +02:00
@@ -0,0 +22,4 @@
name = "form_data_integrity"
action = "off"
# The levels of the required checks need the human (docs/agentic-workflow.md, "Required Checks"):
Author
Collaborator

Right; the human decided to approve this head as it is, so the clearer comment follows in the next PR of werkkompass, the fix of the links in the framed views (#bug.frame-links).

Right; the human decided to approve this head as it is, so the clearer comment follows in the next PR of werkkompass, the fix of the links in the framed views (`#bug.frame-links`).
claude-code marked this conversation as resolved
Author
Collaborator

On the hint at README.md:47-48 (install destination): right, the script uploads vibe-engineering.html, and the web server of javagil.de serves it without the extension as https://javagil.de/vibe-engineering. The human decided to approve this head as it is; the README says so in the next PR of werkkompass.

On the hint at `README.md:47-48` (install destination): right, the script uploads `vibe-engineering.html`, and the web server of javagil.de serves it without the extension as https://javagil.de/vibe-engineering. The human decided to approve this head as it is; the README says so in the next PR of werkkompass.
Sign in to join this conversation.
No labels
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mi/werkkompass#1