Fixed in 04fc1ce: host_config_blocks keeps the checked snapshot of every block, also an equal one, and install compares each of them before any write. Test: `test_an_equal_host_block_changed_…
c20a7eaa54
hs-review draws the diagrams also for GREEN; a run without new diagrams shows none of an earlier run
Fixed in c20a7ea: review-report empties the directory of the diagrams before each dry run (clear_diagrams), so a run that draws none shows no SVGs of an earlier run. Scenario#129.02.
Fixed in d6e6683: the five tests are back unchanged, among them "exposes git metadata read-only with the werkator dir masked, in mount order" and "mounts the primary checkout read-only, the…
Fixed in d6e6683, the head after the reviewed 00f7462: every name starting with SSH_ belongs to the runtime, so SSH_ASKPASS and SSH_ASKPASS_REQUIRE of a build stay on the command line and…
No change; the finding does not hold for Go. The os/signal documentation, section "SIGPIPE": a write to a broken pipe on file descriptors 1 or 2 makes the program exit with SIGPIPE; on any other…
Fixed in d6e6683: every name starting with SSH_, SSL_ or OPENSSL_, and DISPLAY/WAYLAND_DISPLAY, belongs to the runtime now. A build value of such a name stays on the command line, and…
Right, and fixed in d6e6683: moving Scenario#166.03 into the integration test had cut the five tests after it by mistake. They are back unchanged; the spec has 23 tests, the 21 of main plus…
d6e668319f
Review: the five sandbox tests are back; SSH_, SSL_, OPENSSL_ and DISPLAY belong to the runtime
Fixed in 1e523bf: the new text is a paragraph of its own, one sentence per line. The long line 115 above it predates this PR and stays as it is.
Same as above: the new sentences have their own lines now; line 115 is the existing paragraph and is not part of this change.
No change; the finding is wrong. The expected environment is HOST_RUNTIME_ENVIRONMENT + mapOf("branch" to "main") + secrets, and secrets holds both GITEA_BOT_TOKEN and WERKREVISOR_CONFIG_TOML.…
Fixed in 1e523bf: the test moved to the new WerkdockBuildRunnerIntegrationTest.
1e523bf6ff
Review: Scenario#166.03 as an integration test, the values asserted again, one sentence per line in the skill