Same as above: the new sentences have their own lines now; line 115 is the existing paragraph and is not part of this change.
No change; the finding is wrong. The expected environment is HOST_RUNTIME_ENVIRONMENT + mapOf("branch" to "main") + secrets, and secrets holds both GITEA_BOT_TOKEN and WERKREVISOR_CONFIG_TOML.…
1e523bf6ff
Review: Scenario#166.03 as an integration test, the values asserted again, one sentence per line in the skill
Fixed in 1e523bf: the test moved to the new WerkdockBuildRunnerIntegrationTest.
Fixed in 1e523bf: the test asserts the values in the werkdock process's environment, branch = main and FOO = bar.
Fixed in 38550a0: the Non-Goals say that config.json keeps the environment in plain text, why (start of a stopped instance needs it), and that mode 0600 limits it to the account, which holds…
Stays, on purpose: Argv is also what werkdock run validates a spec with before it creates the instance (internal/cli/run.go:108), so it must refuse a NUL byte as Start would. A second pass…
Fixed earlier, in afdf9ac: the Follow-up section with that line is gone; no line is longer than 128 characters.
Fixed in 38550a0: a failed write kills bwrap before the pipe closes. bwrap reads fd 4 up to EOF before it does anything else, so it never starts a sandbox with part of its environment; Start…
Fixed in 38550a0: the Non-Goals line is wrapped.
Fixed in 38550a0: the link line is wrapped.
Fixed in 38550a0: the message says "in its name or its value".
Fixed in 38550a0: "Setting them as bwrap's own environment is no option either".
38550a0f43
Review: a failed write of the environment kills bwrap; wording, error message, line lengths