Fixed in 241535b: set calls digest optional, which writes nothing only for a file without the key and fails for a file it cannot read or parse, before the first connection. `test_set_stops_be…
Answer to the review of 7deb465, fixed in a6e8897:
- Merge conflict with main: rebased onto 0.55.0 of PR#124; the version stays 0.56.0.
- Codex finding on a value with a line break: fixed…
Fixed in a6e8897: main() accepts only [A-Za-z0-9._~+/=-]{16,512}, as set does, and names the allowed characters without the value. Red/green: MalformedValueTest uses the real opener;…
972d51b208
Review round 1: Gitea probe checks the write scopes; purge only by backup names; unreadable configs are errors
Answer to the review of 729e0c7, fixed in 7deb465:
- Codex findings 1 to 4: fixed, see the threads.
- Scenario#128.05 had two aspects: split into 128.05 (only backups with the old value go)…
Fixed in 7deb465: the repository request uses _refused(), so 401/403 refuse and any other status exits with 2; covered in test_an_outage_is_no_refusal.
Fixed in 7deb465: the probe now posts {} to pulls/0/reviews (write:repository) and issues/0/comments (write:issue). Gitea checks the scope first: 403 without it; with it 404 or 422, and…
Fixed in 7deb465: read_lines() turns a read or decode error into an error with exit code 2 for check, set and purge; test_an_unreadable_machine_config_is_an_error (Scenario#128.08).…
Fixed in 7deb465: backups() takes only the backup names on the hosts, <file>.bak…, .pre… and .before…, so secrets.env.production stays; `test_purge_keeps_a_file_that_only_shares_the_…
Fixed in 7deb465: the sentence is split after "has it".
7deb465d58
Review round 1: Gitea probe checks the write scopes; purge only by backup names; unreadable configs are errors
Fixed in 175b7fc: test_hs_review_draws_also_for_green runs a GREEN dry run with the [diagrams] of config/hsadmin-ng.toml and checks that the SVGs are written.
Fixed in 175b7fc: the Solution says that a GREEN result gets diagrams only with skip_green = false, as config/hsadmin-ng.toml sets it.
175b7fce2e
werkrevisor 0.57.0: review-report uses prlens.ASSET_PREFIX; Scenario#129.03 runs a GREEN dry run
Fixed in 175b7fc: clear_diagrams and copy_diagrams use prlens.ASSET_PREFIX.
Answer to the review of ca34c31, now at 04fc1ce:
- Codex finding 6722: fixed in
04fc1ce, thread answered and resolved. - Size and the risk of
tools/release_rootfs.py: structural; they are…
Fixed in 1c33cf7: execute removes the old SVGs of --diagrams-out at the start of each run, so a run that ends in ERROR or is superseded leaves none. Scenario#129.01, `test_a_failed_dry_run_le…