2.3 KiB
PR#61: one change without a statement no longer drops the whole PR document check
WARNING: This document describes only the change applied in this PR. It may already be outdated once the next PR is merged. Historic PR documentation is not maintained along with new PRs; treat it as a snapshot.
The Problem
Since PR#47, an economy model summarizes the diff as a list of changes, and Jev compares the PR document with it. werkrevisor refuses the whole summary if one change has no statement. In the review of PR#58, MiniMax M3 left out one statement, so the PR document was not checked at all.
On 2026-10-08 the operator selected the risk template jvm-spring-backend for werkator on mih09,
but config/werkator.toml in this repository does not name it yet.
Non-Goals
- No change of the questions of the PR document check.
- No change of config/werkprobe.toml: its host block on mih09 differs on purpose, e.g. in the model.
The Scenarios
Feature: the PR document check keeps the usable part of a summary
Scenario#61.01: a change without a statement is left out, the others are compared
So that one sloppy entry of the economy model does not drop the whole check.
- Given a summary with two changes, and one of them has no statement
- When werkrevisor reads the summary
- Then it keeps the change with a statement
- and Jev compares the PR document with it
Verified by
Scenario#61.02: a summary without any usable change is still refused
So that a comparison never runs against nothing.
- Given a summary whose changes all lack a statement
- When werkrevisor reads the summary
- Then the check is left out with a hint
Verified by
The Solution
doccheck.parse_summaryleaves out the changes without a text statement and refuses only a summary without any left.- config/werkator.toml selects
risk_template = "jvm-spring-backend", as the host block on mih09 does. - docs/werkrevisor.werkbaum marks the planned fix as done, and the risk categories as live.
- werkrevisor 0.28.1.
Prerequisite PRs
- PR#60: werkrevisor 0.28.0, merged.