35 lines
1.2 KiB
Markdown
35 lines
1.2 KiB
Markdown
# PR#115: tools/build-rootfs Also Runs with Podman
|
|
|
|
Version: patch
|
|
|
|
> **WARNING:** This document describes only the change applied in this PR.
|
|
> It may already be outdated once the next PR is merged.
|
|
> Historic PR documentation is not maintained along with new PRs; treat it as a snapshot.
|
|
|
|
## Related Links
|
|
|
|
- [werkrevisor PR#114](https://git.javagil.de/mi/werkrevisor/pulls/114): the same for tools/dry-run and tools/jev-eval.
|
|
|
|
## Problem
|
|
|
|
`tools/build-rootfs` calls `docker`; on the workstation there is only Podman.
|
|
Podman also refuses the short base image name `pragent/pr-agent` in the `Dockerfile`.
|
|
|
|
## Non-Goals
|
|
|
|
- No change of the content of the image or of the archive.
|
|
- mih09 keeps Docker.
|
|
|
|
## Solution
|
|
|
|
- `tools/build-rootfs` takes `docker` if it is on the `PATH`, else `podman`; `CONTAINER_ENGINE` overrides the choice.
|
|
- The `Dockerfile` qualifies its base image with `docker.io/`, which Docker and Podman both accept.
|
|
- `tools/build-rootfs` drops `--pull=false`: Podman reads it as "never pull" and fails without a local base image.
|
|
For Docker, `--pull=false` only meant "do not pull a newer base image";
|
|
without it, Docker still pulls the base image only if it is missing.
|
|
- Version 0.44.1.
|
|
|
|
## Open Questions
|
|
|
|
None.
|