werkrevisor allows the change kind feature with tests for itself #8

2026-10-05T17:04:46+02:00

claude-code commented

2026-10-05 17:04:46 +02:00

.werkrevisor.toml adds feature_with_tests and harmless_only to auto_approvable, now that 0.10.0 runs on mih09.

Details: the PR document under docs/prs/.

🤖 Generated with Claude Code

`.werkrevisor.toml` adds `feature_with_tests` and `harmless_only` to `auto_approvable`, now that 0.10.0 runs on mih09. Details: the PR document under `docs/prs/`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-code added 1 commit 2026-10-05 17:04:46 +02:00

werkrevisor allows the change kinds feature_with_tests and harmless_only for itself

werkator build succeeded after 00:06

Details

ai-review/assessment human review required; a human approval unlocks the merge; review requested from mi

Details

ai-review/gate build succeeded after 00:09

Details

99fd34d1f6

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-code marked the pull request as ready for review 2026-10-05 17:04:54 +02:00

ai-reviewer commented

2026-10-05 17:05:12 +02:00

🟡 werkrevisor: YELLOW / HUMAN_REVIEW

Change kind: mixed.

Reasons

YELLOW change kind 'mixed' (other files, docs); AI-approvable are only: docs only, tests only added, docs and tests, refactoring with unchanged tests
YELLOW risky paths changed: .werkrevisor.toml (built in)
YELLOW model reports 1 key issue(s)

Findings

Inaccurate PR document at docs/prs/2026-10-05-PR#8-werkrevisor-allows-feature-with-tests.md:9-12

The PR document says the config adds the two change kinds to the auto_approvable list, but it does not state that harmless_only also becomes auto-approvable. The Problem section only motivates feature_with_tests ("a feature PR ... with purely additive tests can become GREEN"). A reviewer cannot tell from the document why harmless_only is allowed or what it permits. Add one sentence on the reason for harmless_only.

_{Usage: model `openrouter/anthropic/claude-sonnet-5.5`, LLM done, calls 1, tokens in 8255 / out 330 (reasoning included in out), duration 7.3 s, cost 0.0198 USD (reported), config: defaults + host + repository (.werkrevisor.toml at base 94f059c).

Reviewed head `99fd34d1f690be18bd367d544e43b25bfecf401c` against base `94f059c1e17ad1f8a8e2f3f2fa6ed41c2653ec6c`, werkrevisor 0.10.0.}

## 🟡 werkrevisor: YELLOW / HUMAN_REVIEW Change kind: `mixed`. ### Reasons - **YELLOW** change kind 'mixed' (other files, docs); AI-approvable are only: docs only, tests only added, docs and tests, refactoring with unchanged tests - **YELLOW** risky paths changed: .werkrevisor.toml (built in) - **YELLOW** model reports 1 key issue(s) ### Findings 1. **Inaccurate PR document** at `docs/prs/2026-10-05-PR#8-werkrevisor-allows-feature-with-tests.md:9-12` The PR document says the config adds the two change kinds to the `auto_approvable` list, but it does not state that `harmless_only` also becomes auto-approvable. The Problem section only motivates `feature_with_tests` ("a feature PR ... with purely additive tests can become GREEN"). A reviewer cannot tell from the document why `harmless_only` is allowed or what it permits. Add one sentence on the reason for `harmless_only`. Usage: model `openrouter/anthropic/claude-sonnet-5.5`, LLM done, calls 1, tokens in 8255 / out 330 (reasoning included in out), duration 7.3 s, cost 0.0198 USD (reported), config: defaults + host + repository (.werkrevisor.toml at base 94f059c). Reviewed head `99fd34d1f690be18bd367d544e43b25bfecf401c` against base `94f059c1e17ad1f8a8e2f3f2fa6ed41c2653ec6c`, werkrevisor 0.10.0.

ai-reviewer requested review from mi 2026-10-05 17:05:12 +02:00

claude-code added 1 commit 2026-10-05 17:05:40 +02:00

docs: PR#8 document says what harmless_only permits and why it is allowed

werkator build succeeded after 00:05

Details

ai-review/assessment human review required; a human approval unlocks the merge; a human review request is pending

Details

ai-review/gate build succeeded after 00:09

Details

8b3f8f716b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

ai-reviewer commented

2026-10-05 17:05:57 +02:00

🟡 werkrevisor: YELLOW / HUMAN_REVIEW

Change kind: mixed.

Reasons

YELLOW change kind 'mixed' (other files, docs); AI-approvable are only: docs only, tests only added, docs and tests, refactoring with unchanged tests
YELLOW risky paths changed: .werkrevisor.toml (built in)
YELLOW model recommends merge with caution
YELLOW model reports 1 key issue(s)

Findings

Line Length Violation at docs/prs/2026-10-05-PR#8-werkrevisor-allows-feature-with-tests.md:9-14

The sentence "Now 0.10.0 runs on mih09, so a feature PR of werkrevisor with purely additive tests can become GREEN." is 111 characters, within the 128 limit, but the line "harmless_only is a PR of files listed in [categories] harmless, e.g. editor settings, which cannot change the gate." exceeds 120 characters and mixes definition and example. More importantly, lines 10-11 split one sentence across two lines after a comma, which violates the AGENTS.md rule of one sentence per line only if read as a wrapped sentence; this is acceptable. The real issue is the explanation of why the change was not made earlier ("because the installed 0.9.0 would have refused the unknown values") narrates history rather than describing the problem. Consider stating only that 0.10.0 is now deployed, so the values are valid.

_{Usage: model `openrouter/anthropic/claude-sonnet-5.5`, LLM done, calls 1, tokens in 8343 / out 462 (reasoning included in out), duration 8.0 s, cost 0.0213 USD (reported), config: defaults + host + repository (.werkrevisor.toml at base 94f059c).

Reviewed head `8b3f8f716b11769b217bec7538b702c7c9dafbb1` against base `94f059c1e17ad1f8a8e2f3f2fa6ed41c2653ec6c`, werkrevisor 0.10.0.}

## 🟡 werkrevisor: YELLOW / HUMAN_REVIEW Change kind: `mixed`. ### Reasons - **YELLOW** change kind 'mixed' (other files, docs); AI-approvable are only: docs only, tests only added, docs and tests, refactoring with unchanged tests - **YELLOW** risky paths changed: .werkrevisor.toml (built in) - **YELLOW** model recommends merge with caution - **YELLOW** model reports 1 key issue(s) ### Findings 1. **Line Length Violation** at `docs/prs/2026-10-05-PR#8-werkrevisor-allows-feature-with-tests.md:9-14` The sentence "Now 0.10.0 runs on mih09, so a feature PR of werkrevisor with purely additive tests can become GREEN." is 111 characters, within the 128 limit, but the line "`harmless_only` is a PR of files listed in `[categories] harmless`, e.g. editor settings, which cannot change the gate." exceeds 120 characters and mixes definition and example. More importantly, lines 10-11 split one sentence across two lines after a comma, which violates the AGENTS.md rule of one sentence per line only if read as a wrapped sentence; this is acceptable. The real issue is the explanation of why the change was not made earlier ("because the installed 0.9.0 would have refused the unknown values") narrates history rather than describing the problem. Consider stating only that 0.10.0 is now deployed, so the values are valid. Usage: model `openrouter/anthropic/claude-sonnet-5.5`, LLM done, calls 1, tokens in 8343 / out 462 (reasoning included in out), duration 8.0 s, cost 0.0213 USD (reported), config: defaults + host + repository (.werkrevisor.toml at base 94f059c). Reviewed head `8b3f8f716b11769b217bec7538b702c7c9dafbb1` against base `94f059c1e17ad1f8a8e2f3f2fa6ed41c2653ec6c`, werkrevisor 0.10.0.

mi merged commit 4cf8b99535 into main

2026-10-05 17:28:53 +02:00

mi deleted branch claude-code/werkrevisor-allows-feature-with-tests

2026-10-05 17:28:53 +02:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mi/werkrevisor#8