werkrevisor 0.51.0: the Codex runner checks its sandbox before it reviews #123

Merged
ai-reviewer merged 5 commits from claude-code/codex-sandbox-check into main 2026-10-18 20:38:01 +02:00
Collaborator

Before each run, the Codex runner checks that a bwrap inside its jail works; with a broken sandbox it reviews nothing, uses up no attempt and exits with 1.

🤖 Generated with Claude Code

Before each run, the Codex runner checks that a bwrap inside its jail works; with a broken sandbox it reviews nothing, uses up no attempt and exits with 1. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
claude-code added 1 commit 2026-10-18 20:24:19 +02:00
claude-code added 1 commit 2026-10-18 20:24:20 +02:00
PR document: number 123
werkator build succeeded after 00:30
werkator/werkrevisor-statistics build succeeded after 00:32
2a7a073a52
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-code added 1 commit 2026-10-18 20:26:23 +02:00
The Codex runner checks its sandbox before it reviews
werkator build succeeded after 00:11
werkator/werkrevisor-statistics build succeeded after 00:28
1eaad28806
Before each run, a bwrap inside the jail must work; otherwise the run
reviews nothing, counts no attempt and exits with 1. A review whose bwrap
fails counts no attempt either.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-code added 1 commit 2026-10-18 20:26:58 +02:00
werkrevisor 0.51.0: README, plan and PR document for the sandbox check
werkator build succeeded after 00:09
werkator/werkrevisor-statistics build succeeded after 00:32
ai-review/assessment AI review passed; approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit
ai-review/gate build succeeded after 01:11
a3b82b322c
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-code marked the pull request as ready for review 2026-10-18 20:28:09 +02:00
Collaborator
🟢 werkrevisor GREEN for a3b82b3, superseded by the result for 856cb9b

🟢 werkrevisor: GREEN / PASS

Gate: approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit.

Change kind: mixed.

Reasons

  • hint writing rules violated in the changed docs: README.md:1518: paragraph with 7 sentences, more than 5
  • hint 5 changed file(s) that neither weaken the checks, touch security nor show a risk category of the repository config according to Jev
  • hint 1 build change(s) of low risk according to Jev: statistics/build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.02)
  • hint 8 changed file(s) agree with the PR document according to Jev

Classifier

7 of 7 units passed all questions (1 PR document(s)).
1 answer ignored because of a confidence below [classifier] min_confidence.

Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 33807, calls 1, tokens in 32470 / out 17126 (reasoning included in out), duration 69.0 s, cost 0.0303 USD (reported), classifier `jev-1.13.0` calls 7, tokens in 5803, cost 0.0002 USD, PR document check `jev-1.13.0` calls 8, tokens in 22367, cost 0.0009 USD, build file judge `jev-1.13.0` calls 6, tokens in 6444, cost 0.0003 USD, phases: path_judge 0.5 s, classifier 0.5 s, doc_check 0.6 s, context 0.2 s, model_review 66.8 s, config: defaults + host + repository (.werkrevisor.toml at main 4685c8d).
Reviewed head `a3b82b322cd2f258dee8b80458ff0cb492eaf1ed` against base `4685c8db840b552add7486260d5a6f0ed7ee9d35`, werkrevisor 0.49.1.
<!-- werkrevisor:a3b82b322cd2f258dee8b80458ff0cb492eaf1ed --> <!-- werkrevisor-verdict:GREEN --> <!-- werkrevisor-blocks:987ffe61e6e9fcdc9689e2ed41fae8f7,c0172f7b1653660d0d43eedb8556b3bc,69a63caddc09178034680489ff2eb060,b56147564afe118fe7d96c3f41b19d10,db1f2a6c59b33470da2bd553643c5882,c26f25b22aabd6a33ac7a78ba86982f1,21980b8307ff6811239cd794a595706d,2bbaa088113ec97de2b0828714138495,0f7882c2a61cd0890ea9fc992cdbc108,695bbe03e82140adee467a7258736faa,1627fce501228f69fa102547532f0e1c,26b935bf48b4e14005d4d84ba51058cd,5e047bb067767aaa20d9a6fbaf543014,20f180dd80e6f178d285b133a2ab29e3,f2ecb84855bad88e2f638a12fa936dff,34d374a687c9efce945d16ece46359db,2f1afdbecff11cafe15ab9b8679a01ce,40c211d6c9d0b95993fee7d7bb292eef,56c621962961d28d5f142bfa3d4a2896,9c61a2859f7cd8b6a6f041c8f6c80a82,5c8febbae5386aa788071a0475160eb1,8760d68a7edc99e2ea8e300cccf752a3,86a5cec985b09973f055fec06ee6f478,26ce16146e0e402dea0e3df7fdd67815,ec666cc266ff4b28ec2690101e91e733,a1ec07051f4a3b979f4b5415ee369acb,dc501432996ed5c02cc8264a01f4d8f8 --> <!-- werkrevisor-folded --> <details><summary>🟢 werkrevisor GREEN for <code>a3b82b3</code>, superseded by <a href="http://git.javagil.de/mi/werkrevisor/pulls/123#issuecomment-6368">the result for <code>856cb9b</code></a></summary> ## 🟢 werkrevisor: GREEN / PASS Gate: approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit. Change kind: `mixed`. ### Reasons - **hint** writing rules violated in the changed docs: README.md:1518: paragraph with 7 sentences, more than 5 - **hint** 5 changed file(s) that neither weaken the checks, touch security nor show a risk category of the repository config according to Jev - **hint** 1 build change(s) of low risk according to Jev: statistics/build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.02) - **hint** 8 changed file(s) agree with the PR document according to Jev ### Classifier 7 of 7 units passed all questions (1 PR document(s)). 1 answer ignored because of a confidence below [classifier] min_confidence. <sub> Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 33807, calls 1, tokens in 32470 / out 17126 (reasoning included in out), duration 69.0 s, cost 0.0303 USD (reported), classifier `jev-1.13.0` calls 7, tokens in 5803, cost 0.0002 USD, PR document check `jev-1.13.0` calls 8, tokens in 22367, cost 0.0009 USD, build file judge `jev-1.13.0` calls 6, tokens in 6444, cost 0.0003 USD, phases: path_judge 0.5 s, classifier 0.5 s, doc_check 0.6 s, context 0.2 s, model_review 66.8 s, config: defaults + host + repository (.werkrevisor.toml at main 4685c8d).<br> Reviewed head `a3b82b322cd2f258dee8b80458ff0cb492eaf1ed` against base `4685c8db840b552add7486260d5a6f0ed7ee9d35`, werkrevisor 0.49.1. </sub> </details>
ai-reviewer approved these changes 2026-10-18 20:29:22 +02:00
Dismissed
ai-reviewer left a comment
Collaborator

werkrevisor: GREEN / PASS for a3b82b322cd2f258dee8b80458ff0cb492eaf1ed.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `a3b82b322cd2f258dee8b80458ff0cb492eaf1ed`. The result comment of werkrevisor holds the details. <!-- werkrevisor-review:a3b82b322cd2f258dee8b80458ff0cb492eaf1ed -->
Collaborator

Writing rule: paragraph with 7 sentences, more than 5 (werkrevisor writing rule)

Fix the line, or reply why it stays, and resolve this comment.

**Writing rule: paragraph with 7 sentences, more than 5** (werkrevisor writing rule) Fix the line, or reply why it stays, and resolve this comment.
Author
Collaborator

Fixed in 856cb9b: the sandbox check is a paragraph of its own; both paragraphs have at most 5 sentences.

Fixed in `856cb9b`: the sandbox check is a paragraph of its own; both paragraphs have at most 5 sentences.
claude-code marked this conversation as resolved
claude-code added 1 commit 2026-10-18 20:30:00 +02:00
README: the sandbox check in a paragraph of its own
ai-review/codex Codex review passed
werkator build succeeded after 00:11
werkator/werkrevisor-statistics build succeeded after 00:27
ai-review/assessment AI review passed; approved by werkrevisor; merge scheduled for when the checks succeed
ai-review/gate build succeeded after 02:54
856cb9bb5a
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-code dismissed ai-reviewer's review 2026-10-18 20:30:00 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Collaborator

🟢 werkrevisor: GREEN / PASS

Change kind: mixed.

Reasons

  • hint approval of werkrevisor for a3b82b3 not carried over: 1 approved block(s) are missing
  • hint 5 changed file(s) that neither weaken the checks, touch security nor show a risk category of the repository config according to Jev
  • hint 1 build change(s) of low risk according to Jev: statistics/build.gradle.kts (weakens checks 0.02, risk 0.00, security 0.01)
  • hint 8 changed file(s) agree with the PR document according to Jev

Classifier

7 of 7 units passed all questions (1 PR document(s)).

Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 33645, calls 1, tokens in 32320 / out 32898 (reasoning included in out), duration 171.9 s, cost 0.0491 USD (reported), classifier `jev-1.13.0` calls 7, tokens in 5803, cost 0.0002 USD, PR document check `jev-1.13.0` calls 8, tokens in 22348, cost 0.0009 USD, build file judge `jev-1.13.0` calls 6, tokens in 6444, cost 0.0003 USD, phases: path_judge 0.4 s, classifier 0.5 s, doc_check 0.5 s, context 0.3 s, model_review 169.6 s, config: defaults + host + repository (.werkrevisor.toml at main 4685c8d).
Reviewed head `856cb9bb5a2680f8125a2eb45c651ea2686d902b` against base `4685c8db840b552add7486260d5a6f0ed7ee9d35`, werkrevisor 0.49.1.
<!-- werkrevisor:856cb9bb5a2680f8125a2eb45c651ea2686d902b --> <!-- werkrevisor-verdict:GREEN --> <!-- werkrevisor-blocks:1defbbde6a1ff6e25b28cc435daa1177,c0172f7b1653660d0d43eedb8556b3bc,69a63caddc09178034680489ff2eb060,b56147564afe118fe7d96c3f41b19d10,db1f2a6c59b33470da2bd553643c5882,c26f25b22aabd6a33ac7a78ba86982f1,21980b8307ff6811239cd794a595706d,2bbaa088113ec97de2b0828714138495,0f7882c2a61cd0890ea9fc992cdbc108,695bbe03e82140adee467a7258736faa,1627fce501228f69fa102547532f0e1c,26b935bf48b4e14005d4d84ba51058cd,5e047bb067767aaa20d9a6fbaf543014,20f180dd80e6f178d285b133a2ab29e3,f2ecb84855bad88e2f638a12fa936dff,34d374a687c9efce945d16ece46359db,2f1afdbecff11cafe15ab9b8679a01ce,40c211d6c9d0b95993fee7d7bb292eef,56c621962961d28d5f142bfa3d4a2896,9c61a2859f7cd8b6a6f041c8f6c80a82,5c8febbae5386aa788071a0475160eb1,8760d68a7edc99e2ea8e300cccf752a3,86a5cec985b09973f055fec06ee6f478,26ce16146e0e402dea0e3df7fdd67815,ec666cc266ff4b28ec2690101e91e733,a1ec07051f4a3b979f4b5415ee369acb,dc501432996ed5c02cc8264a01f4d8f8 --> ## 🟢 werkrevisor: GREEN / PASS Change kind: `mixed`. ### Reasons - **hint** approval of werkrevisor for `a3b82b3` not carried over: 1 approved block(s) are missing - **hint** 5 changed file(s) that neither weaken the checks, touch security nor show a risk category of the repository config according to Jev - **hint** 1 build change(s) of low risk according to Jev: statistics/build.gradle.kts (weakens checks 0.02, risk 0.00, security 0.01) - **hint** 8 changed file(s) agree with the PR document according to Jev ### Classifier 7 of 7 units passed all questions (1 PR document(s)). <sub> Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 33645, calls 1, tokens in 32320 / out 32898 (reasoning included in out), duration 171.9 s, cost 0.0491 USD (reported), classifier `jev-1.13.0` calls 7, tokens in 5803, cost 0.0002 USD, PR document check `jev-1.13.0` calls 8, tokens in 22348, cost 0.0009 USD, build file judge `jev-1.13.0` calls 6, tokens in 6444, cost 0.0003 USD, phases: path_judge 0.4 s, classifier 0.5 s, doc_check 0.5 s, context 0.3 s, model_review 169.6 s, config: defaults + host + repository (.werkrevisor.toml at main 4685c8d).<br> Reviewed head `856cb9bb5a2680f8125a2eb45c651ea2686d902b` against base `4685c8db840b552add7486260d5a6f0ed7ee9d35`, werkrevisor 0.49.1. </sub>
ai-reviewer left a comment
Collaborator

werkrevisor: GREEN / PASS for 856cb9bb5a2680f8125a2eb45c651ea2686d902b.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `856cb9bb5a2680f8125a2eb45c651ea2686d902b`. The result comment of werkrevisor holds the details. <!-- werkrevisor-review:856cb9bb5a2680f8125a2eb45c651ea2686d902b -->
ai-reviewer scheduled this pull request to auto merge when all checks succeed 2026-10-18 20:36:41 +02:00
Collaborator

Codex review: not critical

The change adds a fail-closed sandbox availability check without changing sandbox permissions or weakening approval requirements. Sandbox failures leave unreviewed PRs pending and preserve their attempt counts.

No findings.

The merge waits for the status ai-review/codex: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here.

Model `gpt-6-astra`, effort high, tokens in 179877 (cached 131072) / out 1470, 46.9 s, 8 commands; reviewed head `856cb9bb5a2680f8125a2eb45c651ea2686d902b`.
<!-- werkrevisor-codex:856cb9bb5a2680f8125a2eb45c651ea2686d902b --> <!-- werkrevisor-codex-critical:false --> <!-- werkrevisor-codex-unattached:0 --> <!-- werkrevisor-codex --> ## Codex review: not critical The change adds a fail-closed sandbox availability check without changing sandbox permissions or weakening approval requirements. Sandbox failures leave unreviewed PRs pending and preserve their attempt counts. No findings. The merge waits for the status `ai-review/codex`: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here. <sub> Model `gpt-6-astra`, effort high, tokens in 179877 (cached 131072) / out 1470, 46.9 s, 8 commands; reviewed head `856cb9bb5a2680f8125a2eb45c651ea2686d902b`. </sub>
ai-reviewer merged commit a6185f0949 into main 2026-10-18 20:38:01 +02:00
ai-reviewer deleted branch claude-code/codex-sandbox-check 2026-10-18 20:38:01 +02:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mi/werkrevisor#123