63 lines
1.9 KiB
Markdown
63 lines
1.9 KiB
Markdown
# PR#76: The Logos of the Connection Bar Stay in One Row on a Phone
|
|
|
|
> **WARNING:** This document describes only the change applied in this PR.
|
|
> It may already be outdated once the next PR is merged.
|
|
> Historic PR documentation is not maintained along with new PRs; treat it as a snapshot.
|
|
|
|
## Related Links
|
|
|
|
- [werkregie PR#68](https://git.javagil.de/mi/werkregie/pulls/68): one logo per tool in the connection bar.
|
|
|
|
## Problem
|
|
|
|
Since PR#68, the connection bar shows one logo per tool.
|
|
Each logo takes 34 px and 8 px of space, so 7 logos fill the 302 px of the bar at a width of 360 px.
|
|
With more logos or a narrower phone, the row breaks into two.
|
|
|
|
## Non-Goals
|
|
|
|
- No change on a desktop.
|
|
- No fewer logos; werkrevisor keeps its own.
|
|
|
|
## Specification
|
|
|
|
### Feature: one row of logos on a phone
|
|
|
|
#### Scenario#76.01: the logos shrink instead of breaking the row
|
|
|
|
… so that the bar stays one row high on a phone.
|
|
|
|
- **Given** 9 logos in the connection bar
|
|
- **When** a phone 320 px wide shows the overview
|
|
- **Then** all 9 logos stand in one row
|
|
|
|
##### Verified by
|
|
|
|
- manual check in the browser, see "Solution"
|
|
|
|
#### Scenario#76.02: few logos keep their size
|
|
|
|
… so that a bar with room to spare looks as before.
|
|
|
|
- **Given** 5 logos in the connection bar
|
|
- **When** a phone 360 px wide shows the overview
|
|
- **Then** each logo is 34 px wide, as before
|
|
|
|
##### Verified by
|
|
|
|
- manual check in the browser, see "Solution"
|
|
|
|
## Solution
|
|
|
|
- On a phone, the row of logos no longer wraps; each logo shrinks from 34 px towards the width of the logo, 19 px plus its border.
|
|
The space between them is 6 px instead of 8 px.
|
|
- The desktop keeps its layout.
|
|
- The repository has no tests of the page; a local check in the browser showed:
|
|
at 320 px, 9 logos, 4 of them added in the browser, in one row, each 24 px wide;
|
|
at 360 px, the 5 logos of the user's own configuration, each 34 px wide.
|
|
- Version 0.46.1; PR#74 holds 0.46.0.
|
|
|
|
## Open Questions
|
|
|
|
None.
|