Dashboard, RelayClient, ClaudeCodeSource and GiteaSource at a Mutation-CRAP of at most 15 #75
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: mi/werkregie#75
Reference in New Issue
Block a user
See doc/prs/ for the PR document.
🤖 Generated with Claude Code
🟡 werkrevisor YELLOW for
5833a82, superseded by the result forbecd5b6🟡 werkrevisor: YELLOW / HUMAN_REVIEW
Change kind:
mixed.Reasons
Findings
Follow-up PRs contradiction at
doc/prs/2026-10-14-PR#75-crap-sources.md:58-60, severity unknown, counted as medium, hint, as a line commentUnclear mutation rationale at
doc/prs/2026-10-14-PR#75-crap-sources.md:35, severity unknown, counted as medium, hint, as a line commentClassifier
6 of 6 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 62807, calls 1, tokens in 60800 / out 63924 (reasoning included in out), duration 355.8 s, cost 0.0949 USD (reported), classifier `jev-1.13.0` calls 6, tokens in 4630, cost 0.0002 USD, finding judge `jev-1.13.0` calls 2, tokens in 4067, cost 0.0002 USD, build file judge `jev-1.13.0` calls 8, tokens in 20338, cost 0.0009 USD, phases: path_judge 0.6 s, classifier 0.4 s, context 0.3 s, model_review 353.7 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main1 answer ignored because of a confidence below [classifier] min_confidence.
7704a8e).Reviewed head `5833a827710a9f13c74142b444bf3e4caad2e3ae` against base `7704a8e89cdf61d0fff6bafa24275b08932909fa`, werkrevisor 0.41.2.
werkrevisor: YELLOW / HUMAN_REVIEW for
5833a827710a9f13c74142b444bf3e4caad2e3ae.The result comment of werkrevisor holds the details.
@@ -0,0 +32,4 @@- `GiteaSource.activityItem` (19) and `pushItem` (16): `subjectOf`, `activityUrl` and `commitsOf`.- `ClaudeCodeSource.desktopItem` (27): `stateOf`, `desktopUrl`, `phoneUrl`, and the item built apart from the filter.- `ClaudeCodeSource.Asks.of` (18): `flag`, `reason`, `waitsForUser` and `ask`;an early return of an empty list became a return of `null`: PIT replaces it by an empty list, a mutant no test can kill.Unclear mutation rationale, severity unknown, counted as medium (werkrevisor)
hint; Jev: real 0.76, severity 1.1 of 3
The sentence "an early return of an empty list became a return of
null: PIT replaces it by an empty list, a mutant no test can kill" is confusing and technically wrong as stated.flag()returnsFlag?, so PIT cannot mutatereturn nulltoreturn emptyList()without violating the return type. The intended rationale about which equivalent mutation tests cannot distinguish is left unexplained.@@ -0,0 +55,4 @@None.## Follow-up PRsFollow-up PRs contradiction, severity unknown, counted as medium (werkrevisor)
hint; Jev: real 0.81, severity 0.8 of 3
The "Follow-up PRs" section lists "werkregie PR#74 builds on it", yet PR#74 already happened and is the previous change that made the four classes complex (it is referenced as such in "Related Links" and "Problem"). A follow-up PR for the remaining classes cannot be PR#74; this is a clear contradiction and almost certainly a typo (likely should be a future PR number, or the section should be removed).
@@ -0,0 +32,4 @@- `GiteaSource.activityItem` (19) and `pushItem` (16): `subjectOf`, `activityUrl` and `commitsOf`.- `ClaudeCodeSource.desktopItem` (27): `stateOf`, `desktopUrl`, `phoneUrl`, and the item built apart from the filter.- `ClaudeCodeSource.Asks.of` (18): `flag`, `reason`, `waitsForUser` and `ask`;`of` returned `emptyList()` early, and PIT's mutant that returns an empty list instead changes nothing there;Fixed in
becd5b6: the line now says thatofreturnedemptyList()early, which PIT's empty-list mutant cannot change, and thatofnow wraps theFlag?offlag.@@ -0,0 +55,4 @@## Open QuestionsNone.Fixed in
becd5b6: PR#74 is still open and builds on this PR; the PR document now says so in Related Links, Problem and Follow-up PRs.🟡 werkrevisor YELLOW for
becd5b6, superseded by the result for948cbc8🟡 werkrevisor: YELLOW / HUMAN_REVIEW
Change kind:
mixed.Reasons
Findings
Doc Inconsistency at
doc/prs/2026-10-14-PR#75-crap-sources.md:16, severity unknown, counted as mediumhint; Jev: real 0.64, severity 0.9 of 3
The doc states "GiteaSource.pullRequestItem at 1980" but the previous
dashboard/build.gradle.ktsratchet was 1806, and the werkbaum records the same 1806 as the highest CRAP at PR#64. IfpullRequestItemwere really at 1980, the ratchet at 1806 would have made every build onmainfail (and prevented PR#74 from being openable). The most likely explanation is a typo in the doc: the value should be 1806, matching the ratchet and the werkbaum. Worth correcting so the PR document is consistent with the rest of the repo.Classifier
6 of 6 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 62921, calls 1, tokens in 60905 / out 35617 (reasoning included in out), duration 265.6 s, cost 0.0610 USD (reported), classifier `jev-1.13.0` calls 6, tokens in 4690, cost 0.0002 USD, finding judge `jev-1.13.0` calls 1, tokens in 2232, cost 0.0001 USD, build file judge `jev-1.13.0` calls 8, tokens in 20338, cost 0.0009 USD, phases: path_judge 0.5 s, classifier 0.4 s, context 0.4 s, model_review 263.6 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main2 answers ignored because of a confidence below [classifier] min_confidence.
7704a8e).Reviewed head `becd5b6a1941fd64bedeb4acbf1c2be18c474c6a` against base `7704a8e89cdf61d0fff6bafa24275b08932909fa`, werkrevisor 0.41.2.
🟡 werkrevisor: YELLOW / HUMAN_REVIEW
Change kind:
mixed.Reasons
Classifier
6 of 6 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 62968, calls 1, tokens in 60951 / out 32074 (reasoning included in out), duration 208.0 s, cost 0.0511 USD (reported), classifier `jev-1.13.0` calls 6, tokens in 4741, cost 0.0002 USD, build file judge `jev-1.13.0` calls 8, tokens in 20338, cost 0.0009 USD, phases: path_judge 0.5 s, classifier 0.5 s, context 0.4 s, model_review 206.1 s, config: defaults + host + repository (.werkrevisor.toml at main2 answers ignored because of a confidence below [classifier] min_confidence.
7704a8e).Reviewed head `948cbc85b6e5278d8f6976c1376ac60b7bd58e08` against base `7704a8e89cdf61d0fff6bafa24275b08932909fa`, werkrevisor 0.41.2.