Names follow javagil.de #86

Merged
ai-reviewer merged 3 commits from claude-code/javagil-names into main 2026-10-14 23:06:03 +02:00
Collaborator

The shared workflow gets a rule for names: on the JVM, packages, Maven groups and Gradle plugin IDs start with de.javagil.<repo>.
A PR that moves many files starts only when no other PR of the repository is open.
The moves of the repositories follow in PRs of their own.

See doc/prs/2026-10-14-PR#86-javagil-names.md.

🤖 Generated with Claude Code

The shared workflow gets a rule for names: on the JVM, packages, Maven groups and Gradle plugin IDs start with `de.javagil.<repo>`. A PR that moves many files starts only when no other PR of the repository is open. The moves of the repositories follow in PRs of their own. See doc/prs/2026-10-14-PR#86-javagil-names.md. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
claude-code added 1 commit 2026-10-14 22:58:18 +02:00
PR document: names follow javagil.de; werkregie moves to de.javagil.werkregie
werkator build succeeded after 00:58
werkator/dependencies build succeeded after 00:16
1d7bf8cec4
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-code changed title from WIP: Names follow javagil.de; werkregie moves to de.javagil.werkregie to WIP: Names follow javagil.de 2026-10-14 22:59:29 +02:00
claude-code added 1 commit 2026-10-14 22:59:29 +02:00
Names follow javagil.de; a move starts only when no other PR is open
werkator build succeeded after 00:59
werkator/dependencies build succeeded after 00:15
ai-review/assessment AI review passed; approved by werkrevisor; merge waits for 2 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit
ai-review/gate build succeeded after 01:45
5a53d29f8d
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-code marked the pull request as ready for review 2026-10-14 23:01:15 +02:00
Collaborator
🟢 werkrevisor GREEN for 5a53d29, superseded by the result for 71c8fcc

🟢 werkrevisor: GREEN / PASS

Gate: approved by werkrevisor; merge waits for 2 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit.

Change kind: docs_only.

Reasons

  • hint 2 finding(s) of low severity or rated minor by Jev: doc/prs/2026-10-14-PR#86-javagil-names.md:30, doc/prs/2026-10-14-PR#86-javagil-names.md:11-12

Findings

  1. Non-standard Terminology at doc/prs/2026-10-14-PR#86-javagil-names.md:30, severity unknown, counted as medium, hint, as a line comment

  2. Unclear Werkcrappit Status at doc/prs/2026-10-14-PR#86-javagil-names.md:11-12, severity unknown, counted as medium, hint, as a line comment

Classifier

4 of 4 units passed all questions (1 PR document(s)).

Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 5171, calls 1, tokens in 5107 / out 19650 (reasoning included in out), duration 102.4 s, cost 0.0251 USD (reported), classifier `jev-1.13.0` calls 4, tokens in 2766, cost 0.0001 USD, finding judge `jev-1.13.0` calls 2, tokens in 2214, cost 0.0001 USD, phases: classifier 0.3 s, context 0.1 s, model_review 101.4 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main c8a1de7).
Reviewed head `5a53d29f8d62ab018cd6fd269ce8a6372608db52` against base `c8a1de77df860833eafa0b352a65db9464117461`, werkrevisor 0.41.2.
<!-- werkrevisor:5a53d29f8d62ab018cd6fd269ce8a6372608db52 --> <!-- werkrevisor-verdict:GREEN --> <!-- werkrevisor-blocks:36f325689bc2c5df8ab6f187e7f3ff38,d6379cce3737e6ae8b8222831734ce31,fceea5408806fa873b872f3c81903d77,96ae67aa719b9b47a6f4d6c9e3928e63,011cf7c5681c3202c115b53056abb406 --> <!-- werkrevisor-folded --> <details><summary>🟢 werkrevisor GREEN for <code>5a53d29</code>, superseded by <a href="http://git.javagil.de/mi/werkregie/pulls/86#issuecomment-5928">the result for <code>71c8fcc</code></a></summary> ## 🟢 werkrevisor: GREEN / PASS Gate: approved by werkrevisor; merge waits for 2 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit. Change kind: `docs_only`. ### Reasons - **hint** 2 finding(s) of low severity or rated minor by Jev: doc/prs/2026-10-14-PR#86-javagil-names.md:30, doc/prs/2026-10-14-PR#86-javagil-names.md:11-12 ### Findings 1. **Non-standard Terminology** at `doc/prs/2026-10-14-PR#86-javagil-names.md:30`, severity unknown, counted as medium, hint, as a line comment 2. **Unclear Werkcrappit Status** at `doc/prs/2026-10-14-PR#86-javagil-names.md:11-12`, severity unknown, counted as medium, hint, as a line comment ### Classifier 4 of 4 units passed all questions (1 PR document(s)). <sub> Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 5171, calls 1, tokens in 5107 / out 19650 (reasoning included in out), duration 102.4 s, cost 0.0251 USD (reported), classifier `jev-1.13.0` calls 4, tokens in 2766, cost 0.0001 USD, finding judge `jev-1.13.0` calls 2, tokens in 2214, cost 0.0001 USD, phases: classifier 0.3 s, context 0.1 s, model_review 101.4 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main c8a1de7).<br> Reviewed head `5a53d29f8d62ab018cd6fd269ce8a6372608db52` against base `c8a1de77df860833eafa0b352a65db9464117461`, werkrevisor 0.41.2. </sub> </details>
ai-reviewer approved these changes 2026-10-14 23:03:03 +02:00
Dismissed
ai-reviewer left a comment
Collaborator

werkrevisor: GREEN / PASS for 5a53d29f8d62ab018cd6fd269ce8a6372608db52.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `5a53d29f8d62ab018cd6fd269ce8a6372608db52`. The result comment of werkrevisor holds the details. <!-- werkrevisor-review:5a53d29f8d62ab018cd6fd269ce8a6372608db52 -->
@@ -0,0 +8,4 @@
## Problem
The Werk repositories name their code in three ways: `de.hoennig` in werkator, werkjournal, werkregie and werkrevisor,
Collaborator

Unclear Werkcrappit Status, severity unknown, counted as medium (werkrevisor)

hint; Jev: real 0.65, severity 1.1 of 3

The Problem section lists three naming schemes, including de.javagil.werkcrappit. This already follows the new rule (de.javagil.<repo>), so werkcrappit does not need to move. The PR document groups werkcrappit with the non-compliant repositories without distinguishing its status, while the plan correctly omits a werkcrappit move sub-item. A reader might infer that werkcrappit also needs a move. The PR document should note that werkcrappit already follows the new rule.

**Unclear Werkcrappit Status**, severity unknown, counted as medium (werkrevisor) hint; Jev: real 0.65, severity 1.1 of 3 The Problem section lists three naming schemes, including `de.javagil.werkcrappit`. This already follows the new rule (`de.javagil.<repo>`), so werkcrappit does not need to move. The PR document groups werkcrappit with the non-compliant repositories without distinguishing its status, while the plan correctly omits a werkcrappit move sub-item. A reader might infer that werkcrappit also needs a move. The PR document should note that werkcrappit already follows the new rule.
claude-code marked this conversation as resolved
@@ -0,0 +27,4 @@
on the JVM, packages, Maven groups and Gradle plugin IDs start with `de.javagil.<repo>`.
- `doc/agentic-workflow.md`, "Scope of a PR": a PR that moves or renames many files starts only when no other PR
of the repository is open, and the move is all it does.
- The plan gets the moves per repository; the CHANGELOG node of werkcrappit is `[^]` since werkcrappit PR#70.
Collaborator

Non-standard Terminology, severity unknown, counted as medium (werkrevisor)

hint; Jev: real 0.79, severity 1.1 of 3

The PR document refers to a plan entry as "the CHANGELOG node of werkcrappit", but in werkbaum terminology "node" refers to top-level entries with # prefix. The referenced item is a sub-item under #ops.version, not a node. A reader searching for a "CHANGELOG node" in the plan would not find one. The PR document should use clearer wording, e.g., "the CHANGELOG entry of werkcrappit".

**Non-standard Terminology**, severity unknown, counted as medium (werkrevisor) hint; Jev: real 0.79, severity 1.1 of 3 The PR document refers to a plan entry as "the CHANGELOG node of werkcrappit", but in werkbaum terminology "node" refers to top-level entries with `#` prefix. The referenced item is a sub-item under `#ops.version`, not a node. A reader searching for a "CHANGELOG node" in the plan would not find one. The PR document should use clearer wording, e.g., "the CHANGELOG entry of werkcrappit".
claude-code marked this conversation as resolved
@@ -0,0 +8,4 @@
## Problem
The Werk repositories name their code in three ways: `de.hoennig` in werkator, werkjournal, werkregie and werkrevisor,
Author
Collaborator

Fixed in 71c8fcc: werkcrappit already follows the rule; the others move.

Fixed in `71c8fcc`: werkcrappit already follows the rule; the others move.
@@ -0,0 +27,4 @@
- `doc/agentic-workflow.md`, "Code and Comments": names follow javagil.de in the way of their ecosystem;
on the JVM, packages, Maven groups and Gradle plugin IDs start with `de.javagil.<repo>`.
- `doc/agentic-workflow.md`, "Scope of a PR": a PR that moves or renames many files starts only when no other PR
of the repository is open, and the move is all it does.
Author
Collaborator

No change: the shared workflow calls each item of a Werkbaum file a node, e.g. "A PR sets its nodes to [x]" in "The Plan in Werkbaum"; the #id only addresses a node.

No change: the shared workflow calls each item of a Werkbaum file a node, e.g. "A PR sets its nodes to `[x]`" in "The Plan in Werkbaum"; the `#id` only addresses a node.
claude-code added 1 commit 2026-10-14 23:03:40 +02:00
The PR document says that werkcrappit already follows the rule
werkator build succeeded after 00:59
werkator/dependencies build succeeded after 00:16
ai-review/assessment AI review passed; approved by werkrevisor; merge scheduled for when the checks succeed
ai-review/gate build succeeded after 02:17
71c8fcc1f1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-code dismissed ai-reviewer's review 2026-10-14 23:03:40 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Collaborator

🟢 werkrevisor: GREEN / PASS

Change kind: docs_only.

Reasons

  • hint approval of werkrevisor for 5a53d29 not carried over: 1 approved block(s) are missing
  • hint 2 finding(s) of low severity or rated minor by Jev: doc/prs/2026-10-14-PR#86-javagil-names.md:27-31, doc/prs/2026-10-14-PR#86-javagil-names.md:13
  • hint model recommends merge with caution

Findings

  1. Underspecified scope at doc/prs/2026-10-14-PR#86-javagil-names.md:27-31, severity unknown, counted as medium

    hint; Jev: real 0.79, severity 1.9 of 3

    The PR document's Solution section describes only the JVM rule (de.javagil.<repo>), but doc/agentic-workflow.md also adds rules for Go modules (git.javagil.de/<owner>/<repo>) and npm packages (@javagil). The Solution mentions "in the way of their ecosystem" without listing these additional ecosystems, and the Werkbaum node #ops.names title only references the JVM rule. The PR document should describe all three ecosystems so the change is fully specified, or the additional rules should be removed from the workflow.

  2. Unclear wording at doc/prs/2026-10-14-PR#86-javagil-names.md:13, severity unknown, counted as medium

    hint; Jev: real 0.76, severity 1.0 of 3

    The sentence "Their packages and plugins are published under git.javagil.de" is imprecise: Maven and Gradle artifacts are published on registries (Maven Central, Gradle Plugin Portal), not on a Git server, and "published under" is ambiguous. The phrasing should make clear whether it means "hosted on", "owned by", or something else.

Classifier

4 of 4 units passed all questions (1 PR document(s)).

Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 5190, calls 1, tokens in 5125 / out 31584 (reasoning included in out), duration 134.5 s, cost 0.0394 USD (reported), classifier `jev-1.13.0` calls 4, tokens in 2782, cost 0.0001 USD, finding judge `jev-1.13.0` calls 2, tokens in 2254, cost 0.0001 USD, phases: classifier 0.3 s, context 0.1 s, model_review 133.5 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main c8a1de7).
Reviewed head `71c8fcc1f1c528d47c51baff135c3d92da12476d` against base `c8a1de77df860833eafa0b352a65db9464117461`, werkrevisor 0.41.2.
<!-- werkrevisor:71c8fcc1f1c528d47c51baff135c3d92da12476d --> <!-- werkrevisor-verdict:GREEN --> <!-- werkrevisor-blocks:36f325689bc2c5df8ab6f187e7f3ff38,d6379cce3737e6ae8b8222831734ce31,ae5847407f4196894567f0638e9e7bc9,96ae67aa719b9b47a6f4d6c9e3928e63,011cf7c5681c3202c115b53056abb406 --> ## 🟢 werkrevisor: GREEN / PASS Change kind: `docs_only`. ### Reasons - **hint** approval of werkrevisor for `5a53d29` not carried over: 1 approved block(s) are missing - **hint** 2 finding(s) of low severity or rated minor by Jev: doc/prs/2026-10-14-PR#86-javagil-names.md:27-31, doc/prs/2026-10-14-PR#86-javagil-names.md:13 - **hint** model recommends merge with caution ### Findings 1. **Underspecified scope** at `doc/prs/2026-10-14-PR#86-javagil-names.md:27-31`, severity unknown, counted as medium hint; Jev: real 0.79, severity 1.9 of 3 The PR document's Solution section describes only the JVM rule (`de.javagil.<repo>`), but `doc/agentic-workflow.md` also adds rules for Go modules (`git.javagil.de/<owner>/<repo>`) and npm packages (`@javagil`). The Solution mentions "in the way of their ecosystem" without listing these additional ecosystems, and the Werkbaum node #ops.names title only references the JVM rule. The PR document should describe all three ecosystems so the change is fully specified, or the additional rules should be removed from the workflow. 2. **Unclear wording** at `doc/prs/2026-10-14-PR#86-javagil-names.md:13`, severity unknown, counted as medium hint; Jev: real 0.76, severity 1.0 of 3 The sentence "Their packages and plugins are published under git.javagil.de" is imprecise: Maven and Gradle artifacts are published on registries (Maven Central, Gradle Plugin Portal), not on a Git server, and "published under" is ambiguous. The phrasing should make clear whether it means "hosted on", "owned by", or something else. ### Classifier 4 of 4 units passed all questions (1 PR document(s)). <sub> Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 5190, calls 1, tokens in 5125 / out 31584 (reasoning included in out), duration 134.5 s, cost 0.0394 USD (reported), classifier `jev-1.13.0` calls 4, tokens in 2782, cost 0.0001 USD, finding judge `jev-1.13.0` calls 2, tokens in 2254, cost 0.0001 USD, phases: classifier 0.3 s, context 0.1 s, model_review 133.5 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main c8a1de7).<br> Reviewed head `71c8fcc1f1c528d47c51baff135c3d92da12476d` against base `c8a1de77df860833eafa0b352a65db9464117461`, werkrevisor 0.41.2. </sub>
ai-reviewer left a comment
Collaborator

werkrevisor: GREEN / PASS for 71c8fcc1f1c528d47c51baff135c3d92da12476d.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `71c8fcc1f1c528d47c51baff135c3d92da12476d`. The result comment of werkrevisor holds the details. <!-- werkrevisor-review:71c8fcc1f1c528d47c51baff135c3d92da12476d -->
ai-reviewer scheduled this pull request to auto merge when all checks succeed 2026-10-14 23:06:00 +02:00
ai-reviewer merged commit 6c8c6b0455 into main 2026-10-14 23:06:03 +02:00
ai-reviewer deleted branch claude-code/javagil-names 2026-10-14 23:06:03 +02:00
Sign in to join this conversation.
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mi/werkregie#86