werkprobe builds with Temurin 25 #15
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: mi/werkprobe#15
Reference in New Issue
Block a user
werkprobe builds with Temurin 25 and keeps Java 17 bytecode, as werkregie ADR 0001 decides.
🤖 Generated with Claude Code
🟡 werkrevisor YELLOW for
346b605, superseded by the result for09dcd30🟡 werkrevisor: YELLOW / HUMAN_REVIEW
Change kind:
mixed.Reasons
Findings
[medium] Gradle/Spring Boot compatibility with JDK 25 at
build.gradle:21-29, hint, as a line comment[low] Foojay download in sandbox at
settings.gradle:13-16, hint, as a line commentClassifier
4 of 4 units passed all questions (1 PR document(s)).
Usage: model `openrouter/anthropic/claude-sonnet-5.5`, LLM done, tokens counted before the call 10272, calls 1, tokens in 9909 / out 557 (reasoning included in out), duration 33.2 s, cost 0.0254 USD (reported), classifier `jev-1.13.0` calls 4, tokens in 2724, cost 0.0001 USD, finding judge `jev-1.13.0` calls 1, tokens in 1890, cost 0.0001 USD, build file judge `jev-1.13.0` calls 3, tokens in 2117, cost 0.0001 USD, phases: path_judge 0.3 s, classifier 0.3 s, context 1.8 s, model_review 30.1 s, finding_judge 0.3 s, config: defaults + host + repository (.werkrevisor.toml at main5da1d2e).Reviewed head `346b6055e67a40f161d2bb5af46fb2e9b46fcf79` against base `5da1d2ef0064909c67d0f891102ed935bc33a46b`, werkrevisor 0.32.7.
werkrevisor: YELLOW / HUMAN_REVIEW for
346b6055e67a40f161d2bb5af46fb2e9b46fcf79.The result comment of werkrevisor holds the details.
@@ -199,2 +198,2 @@environment. The bytecode targets Java 17, which is what the managedwebspaces have, so `tools/deploy.sh` can send it to one.JDK from 17 up runs Gradle, which builds with Temurin 25 and loads it withFoojay where it is missing (werkregie ADR 0001). The bytecode targetsWriting rule: more than one sentence on a line (werkrevisor writing rule)
Fix the line, or reply why it stays, and resolve this comment.
Fixed in
09dcd30.@@ -23,3 +21,1 @@// Hostsharing managed webspaces run, and tools/deploy.sh sends the result// to one of them. Requesting a 17 toolchain instead would demand a JDK 17// that the build environment does not have.// Compiled with Temurin 25, the JDK of all werk repositories (werkregie ADR 0001),[medium] Gradle/Spring Boot compatibility with JDK 25 (werkrevisor)
hint; Jev: real 0.42, severity 2.0 of 3
The toolchain now compiles and runs tests and
piteston JDK 25, while the comment at the plugins block still pins Spring Boot 3.5 for Java 17. The PR claims it was checked locally, but the container tests were not run (they need werkdock). Test runs on JDK 25 with Testcontainers 1.21.4 and the PIT 1.30.0 mutation engine are therefore unverified until CI runs. Also, the Gradle wrapper version is not shown in the diff. Foojay 1.0.0 and running Gradle itself on JDK 25 may need a recent Gradle; confirm the wrapper version supports it.No change. The CI build of
346b605ran the tests, the container tests with Testcontainers in werkdock's sandbox included, and is green.pitestpassed locally with Temurin 25; the CI does not run it. Gradle 9.6.0 runs on the sandbox's OpenJDK 21, not on 25; only the toolchain is 25. The comment at the plugins block stays true: Spring Boot 3.5 is kept for the Java 17 bytecode.@@ -10,4 +10,9 @@ pluginManagement {}}// Loads the Temurin 25 of the toolchain where only another JDK is installed, e.g. in Werkator's build sandbox.[low] Foojay download in sandbox (werkrevisor)
hint
The Foojay resolver downloads Temurin 25 from the network on first build. The Werkator werkdock sandbox may have no internet access or a cold cache, which would make the CI build fail at toolchain resolution. The PR does not state that the sandbox can reach the download hosts or that a cache is kept. Confirm this in CI.
No change. The sandbox reaches the network, and the builds on mih09 share one Gradle home: Foojay downloaded Temurin 25.0.4.1 into it once, for werkrevisor PR#82, and the CI of this PR is green.
🟡 werkrevisor: YELLOW / HUMAN_REVIEW
Change kind:
mixed.Reasons
Findings
[medium] Foojay resolver depends on network in sandbox at
settings.gradle:13-16, YELLOW, as a line comment[medium] Spring Boot 3.5 with Java 25 toolchain at
build.gradle:21-29, hint, as a line commentClassifier
4 of 4 units passed all questions (1 PR document(s)).
Usage: model `openrouter/anthropic/claude-sonnet-5.5`, LLM done, tokens counted before the call 10314, calls 1, tokens in 9948 / out 547 (reasoning included in out), duration 37.1 s, cost 0.0254 USD (reported), classifier `jev-1.13.0` calls 4, tokens in 2724, cost 0.0001 USD, finding judge `jev-1.13.0` calls 2, tokens in 3092, cost 0.0001 USD, build file judge `jev-1.13.0` calls 3, tokens in 2117, cost 0.0001 USD, phases: path_judge 0.3 s, classifier 0.3 s, context 2.8 s, model_review 33.0 s, finding_judge 0.4 s, config: defaults + host + repository (.werkrevisor.toml at main5da1d2e).Reviewed head `09dcd3013c75ba451169ca5254e8b5c598c3abab` against base `5da1d2ef0064909c67d0f891102ed935bc33a46b`, werkrevisor 0.32.7.
werkrevisor: YELLOW / HUMAN_REVIEW for
09dcd3013c75ba451169ca5254e8b5c598c3abab.The result comment of werkrevisor holds the details.
@@ -23,3 +21,1 @@// Hostsharing managed webspaces run, and tools/deploy.sh sends the result// to one of them. Requesting a 17 toolchain instead would demand a JDK 17// that the build environment does not have.// Compiled with Temurin 25, the JDK of all werk repositories (werkregie ADR 0001),[medium] Spring Boot 3.5 with Java 25 toolchain (werkrevisor)
hint; Jev: real 0.56, severity 2.0 of 3
The toolchain now runs the Gradle test and pitest tasks on JDK 25, while
options.release = 17only fixes the compile target. Test and pitest run on the 25 JVM with Spring Boot 3.5.16, and pitest 1.30.0 and its JUnit 5 plugin 1.2.3 must support Java 25 class files and runtime. The PR document claims a local check passed, so the risk is mainly in CI. The sandbox needs network access to Foojay and a JDK download, otherwise the build fails; this is not verified in the diff.@@ -10,4 +10,9 @@ pluginManagement {}}// Loads the Temurin 25 of the toolchain where only another JDK is installed, e.g. in Werkator's build sandbox.[medium] Foojay resolver depends on network in sandbox (werkrevisor)
YELLOW; Jev: real 0.56, severity 2.9 of 3
The build now depends on downloading a JDK through the Foojay API at build time. If Werkator's werkdock sandbox has no outbound network access, or the JDK cache is not persisted between builds, every CI build fails or re-downloads Temurin 25. The old setup used the JDK already in the rootfs. Whether the sandbox has network access is not visible in the diff.