3.1 KiB
PR#2: The links of the framed views open in the top window
WARNING: This document describes only the change applied in this PR. It may already be outdated once the next PR is merged. Historic PR documentation is not maintained along with new PRs; treat it as a snapshot.
Problem
The browser check of werkkompass PR#1 found that the copyright, imprint and privacy links
of the staircase and the workflow view turn the view blank:
they load inside the iframe of the view, and michael.hoennig.de refuses to be framed (X-Frame-Options: DENY).
The fallback href of the back arrow of the workflow view names the old file agentic-ai-software-development.html.
A click is handled by the script, but a middle click opens a missing page on javagil.de.
Non-Goals
- No other change of the views.
- No automated test; the human decided to add checks together with the build step.
Specification
Feature: links of the framed views
Scenario#2.01: a footer link of a framed view opens in the browser window
… so that the visitor reaches the imprint and the privacy policy from every view.
- Given the staircase or the workflow view is shown
- When the visitor clicks "Imprint", "Privacy" or "Michael Hönnig" in its footer
- Then the browser window shows that page of michael.hoennig.de instead of a blank view
Verified by
- the browser check below; there are no automated tests yet
Scenario#2.02: the back arrow of the workflow view opens the staircase also in a new tab
… so that a middle click on the arrow works like a click.
- Given the workflow view is shown
- When the visitor opens the back arrow in a new tab
- Then the new tab shows the staircase view of the same page
Verified by
- the browser check below; there are no automated tests yet
Solution
- The three footer links of both framed views get
target="_top"; so they open in the browser window, like the links of the page itself. - The back arrow of the workflow view links to
#engineering-activities, like the arrows of the staircase view. Asrcdocdocument resolves it against the URL of the page. - Version 1.0.1.
Browser Check
Checked on a local HTTP server in Chromium on 2026-10-14:
| Check | Before | After |
|---|---|---|
| "Imprint" in the staircase view | blank view | the imprint in the browser window |
| "Privacy" in the workflow view | blank view | the privacy policy in the browser window |
back arrow of the workflow view, resolved href |
…/agentic-ai-software-development.html#engineering-activities |
…/index.html#engineering-activities |
| arrows between the views, back and forward in the history | passed | passed |
| messages in the console | none | none |
After the merge, the human installs the new version.
Open Questions
None.
Additional Changes
Findings of werkrevisor on werkkompass PR#1, left for this PR by decision of the human:
README.mdnames the installed filevibe-engineering.htmland the address https://javagil.de/vibe-engineering..werkrevisor.tomlexplains in plain words why a change of the risk analysis waits for the human.