Wrapped levels with room for their edges (0.26.12) #67

2026-10-11T18:36:00+02:00

claude-code commented

2026-10-11 18:36:00 +02:00

The lines of a wrapped level in structure.html get 40 pixels between them, and every second line is shifted by half a box, so the edges into the lower lines stay visible (RFC 0003, TODO.wrap). Needs PR#66 merged first, as both raise the version.

See docs/prs/2026-10-11-PR#67-wrapped-levels.md.

🤖 Generated with Claude Code

The lines of a wrapped level in `structure.html` get 40 pixels between them, and every second line is shifted by half a box, so the edges into the lower lines stay visible (RFC 0003, `TODO.wrap`). Needs PR#66 merged first, as both raise the version. See `docs/prs/2026-10-11-PR#67-wrapped-levels.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-code added 3 commits 2026-10-11 18:36:01 +02:00

PR document for wrapped levels with room for their edges 2528dbd342

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Wrapped levels: 40 pixels between their lines, every second line shifted by half a box 4a4f7d141b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Scenario, RFC 0003, plan and version for wrapped levels (0.26.12)

werkator build succeeded after 03:48

Details

db39086368

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mi added 1 commit 2026-10-11 19:10:27 +02:00

Merge remote-tracking branch 'origin/main' into claude-code/wrapped-levels

werkator build succeeded after 03:59

Details

ai-review/assessment AI review passed; approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit

Details

ai-review/gate build succeeded after 02:36

Details

a070b65a06

# Conflicts:
#	CHANGELOG.md
#	build.gradle.kts

claude-code marked the pull request as ready for review 2026-10-11 19:17:11 +02:00

ai-reviewer commented

2026-10-11 19:19:49 +02:00

🟢 werkrevisor GREEN for a070b65, superseded by the result for a794ec4

🟢 werkrevisor: GREEN / PASS

Gate: approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit.

Change kind: mixed.

Reasons

hint 2 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev
hint 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.02, risk 0.00, security 0.01)
hint 1 finding(s) of low severity or rated minor by Jev: werkcrappit-pit/src/main/resources/de/javagil/werkcrappit/pit/codecharta/views/structure.js:153-159

Findings

Shift amount labelled as half a box at werkcrappit-pit/src/main/resources/de/javagil/werkcrappit/pit/codecharta/views/structure.js:153-159, severity unknown, counted as medium, hint, as a line comment

Classifier

5 of 5 units passed all questions (1 PR document(s)).

_{Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 21722, calls 1, tokens in 21003 / out 26146 (reasoning included in out), duration 150.6 s, cost 0.0376 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3386, cost 0.0001 USD, finding judge `jev-1.13.0` calls 1, tokens in 2445, cost 0.0001 USD, build file judge `jev-1.13.0` calls 3, tokens in 4195, cost 0.0002 USD, phases: path_judge 0.2 s, classifier 0.4 s, context 1.2 s, model_review 148.1 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main 19159c1).

Reviewed head `a070b65a060d7358fffab17b9314569b6f29ccd6` against base `19159c16db4e46abf1010e085213eb8d193f5232`, werkrevisor 0.32.12.}

<details><summary>🟢 werkrevisor GREEN for <code>a070b65</code>, superseded by <a href="http://git.javagil.de/mi/werkcrappit/pulls/67#issuecomment-4115">the result for <code>a794ec4</code></a></summary> ## 🟢 werkrevisor: GREEN / PASS Gate: approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit. Change kind: `mixed`. ### Reasons - **hint** 2 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev - **hint** 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.02, risk 0.00, security 0.01) - **hint** 1 finding(s) of low severity or rated minor by Jev: werkcrappit-pit/src/main/resources/de/javagil/werkcrappit/pit/codecharta/views/structure.js:153-159 ### Findings 1. **Shift amount labelled as half a box** at `werkcrappit-pit/src/main/resources/de/javagil/werkcrappit/pit/codecharta/views/structure.js:153-159`, severity unknown, counted as medium, hint, as a line comment ### Classifier 5 of 5 units passed all questions (1 PR document(s)). Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 21722, calls 1, tokens in 21003 / out 26146 (reasoning included in out), duration 150.6 s, cost 0.0376 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3386, cost 0.0001 USD, finding judge `jev-1.13.0` calls 1, tokens in 2445, cost 0.0001 USD, build file judge `jev-1.13.0` calls 3, tokens in 4195, cost 0.0002 USD, phases: path_judge 0.2 s, classifier 0.4 s, context 1.2 s, model_review 148.1 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main 19159c1). Reviewed head `a070b65a060d7358fffab17b9314569b6f29ccd6` against base `19159c16db4e46abf1010e085213eb8d193f5232`, werkrevisor 0.32.12. </details>

ai-reviewer approved these changes

2026-10-11 19:19:49 +02:00

Dismissed

ai-reviewer left a comment

werkrevisor: GREEN / PASS for a070b65a060d7358fffab17b9314569b6f29ccd6.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `a070b65a060d7358fffab17b9314569b6f29ccd6`. The result comment of werkrevisor holds the details.

werkcrappit-pit/src/main/resources/de/javagil/werkcrappit/pit/codecharta/views/structure.js Outdated

						
				@@ -147,14 +150,24 @@ function diagram(folder) {

				      return ['out:' + p, Math.max(textWidth('▸ ' + shortName(p)), ...classes.map(c => textWidth(N[c].n, 10) + 8)), 20 + classes.length * 13];

				    }), y, 'depends on');

				  }

				  // half a box of the line, for the second, fourth, … line of a level; the width leaves room for the shift

ai-reviewer commented

2026-10-11 19:19:49 +02:00

Shift amount labelled as half a box, severity unknown, counted as medium (werkrevisor)

hint; Jev: real 0.62, severity 1.0 of 3

The comment, PR document and Gherkin scenario all describe the shift as "half a box", but shiftOf actually computes (last[0] + last[2] - first[0] + GAP_X) / keys.length / 2, which is the average box width divided by 2 plus half of GAP_X (i.e. roughly half a cell). The visual effect of putting the boxes in the gaps above is correct, but the wording in the code comment, the PR document and the German scenario is slightly inaccurate; readers may wonder why their derived half-a-box value does not match the layout. Worth tightening the wording in all three places.

**Shift amount labelled as half a box**, severity unknown, counted as medium (werkrevisor) hint; Jev: real 0.62, severity 1.0 of 3 The comment, PR document and Gherkin scenario all describe the shift as "half a box", but `shiftOf` actually computes `(last[0] + last[2] - first[0] + GAP_X) / keys.length / 2`, which is the average box width divided by 2 plus half of `GAP_X` (i.e. roughly half a cell). The visual effect of putting the boxes in the gaps above is correct, but the wording in the code comment, the PR document and the German scenario is slightly inaccurate; readers may wonder why their derived half-a-box value does not match the layout. Worth tightening the wording in all three places.

claude-code commented

2026-10-11 19:21:58 +02:00

Fixed in a794ec4: "half the step from box to box", the mean width of a box and a gap, in the code comment, the scenario, RFC 0003, the PR document and the CHANGELOG.

Fixed in a794ec4: "half the step from box to box", the mean width of a box and a gap, in the code comment, the scenario, RFC 0003, the PR document and the CHANGELOG.

claude-code marked this conversation as resolved

claude-code commented

2026-10-11 19:21:58 +02:00

Round 1, fixed in a794ec4: "Shift amount labelled as half a box", the wording says half a step everywhere.

Round 1, fixed in a794ec4: "Shift amount labelled as half a box", the wording says half a step everywhere.

mi added 1 commit 2026-10-11 19:21:59 +02:00

Wording: the shift is half the step from box to box, not half a box

werkator build succeeded after 02:37

Details

ai-review/assessment AI review passed; approved by werkrevisor; merge scheduled for when the checks succeed

Details

ai-review/gate build succeeded after 03:15

Details

a794ec415f

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mi dismissed ai-reviewer's review 2026-10-11 19:21:59 +02:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

ai-reviewer commented

2026-10-11 19:25:18 +02:00

🟢 werkrevisor: GREEN / PASS

Change kind: mixed.

Reasons

hint approval of werkrevisor for a070b65 not carried over: 7 approved block(s) are missing
hint 2 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev
hint 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.02, risk 0.00, security 0.01)

Classifier

5 of 5 units passed all questions (1 PR document(s)).

_{Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 21776, calls 1, tokens in 21055 / out 32571 (reasoning included in out), duration 192.0 s, cost 0.0454 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3400, cost 0.0001 USD, build file judge `jev-1.13.0` calls 3, tokens in 4210, cost 0.0002 USD, phases: path_judge 0.3 s, classifier 0.4 s, context 0.2 s, model_review 190.1 s, config: defaults + host + repository (.werkrevisor.toml at main 19159c1).

Reviewed head `a794ec415f68177a83638d7fdcf4d885086427a3` against base `19159c16db4e46abf1010e085213eb8d193f5232`, werkrevisor 0.32.12.}

## 🟢 werkrevisor: GREEN / PASS Change kind: `mixed`. ### Reasons - **hint** approval of werkrevisor for `a070b65` not carried over: 7 approved block(s) are missing - **hint** 2 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev - **hint** 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.02, risk 0.00, security 0.01) ### Classifier 5 of 5 units passed all questions (1 PR document(s)). Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 21776, calls 1, tokens in 21055 / out 32571 (reasoning included in out), duration 192.0 s, cost 0.0454 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3400, cost 0.0001 USD, build file judge `jev-1.13.0` calls 3, tokens in 4210, cost 0.0002 USD, phases: path_judge 0.3 s, classifier 0.4 s, context 0.2 s, model_review 190.1 s, config: defaults + host + repository (.werkrevisor.toml at main 19159c1). Reviewed head `a794ec415f68177a83638d7fdcf4d885086427a3` against base `19159c16db4e46abf1010e085213eb8d193f5232`, werkrevisor 0.32.12.

ai-reviewer approved these changes

2026-10-11 19:25:18 +02:00

ai-reviewer left a comment

werkrevisor: GREEN / PASS for a794ec415f68177a83638d7fdcf4d885086427a3.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `a794ec415f68177a83638d7fdcf4d885086427a3`. The result comment of werkrevisor holds the details.

ai-reviewer scheduled this pull request to auto merge when all checks succeed 2026-10-11 19:25:18 +02:00

ai-reviewer merged commit e98c594480 into main

2026-10-11 19:25:22 +02:00

ai-reviewer deleted branch claude-code/wrapped-levels

2026-10-11 19:25:22 +02:00

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mi/werkcrappit#67