The Groovy DSL tested against the published plugins (0.26.8) #63

Merged
ai-reviewer merged 4 commits from claude-code/groovy-dsl into main 2026-10-11 17:18:50 +02:00
Collaborator

The Groovy DSL example of @MC-029: a fixture in the Groovy DSL against the published plugins, and the tested setup in the README.

See docs/prs/2026-10-11-PR#63-groovy-dsl.md.

🤖 Generated with Claude Code

The Groovy DSL example of `@MC-029`: a fixture in the Groovy DSL against the published plugins, and the tested setup in the README. See `docs/prs/2026-10-11-PR#63-groovy-dsl.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
claude-code added 3 commits 2026-10-11 17:08:53 +02:00
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
README's Groovy DSL, acceptance map, compatibility and plan (0.26.8)
werkator build succeeded after 02:58
ai-review/assessment AI review passed; approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit
ai-review/gate build succeeded after 02:23
cc923310c2
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-code marked the pull request as ready for review 2026-10-11 17:12:05 +02:00
Collaborator
🟢 werkrevisor GREEN for cc92331, superseded by the result for 7da8a01

🟢 werkrevisor: GREEN / PASS

Gate: approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit.

Change kind: mixed.

Reasons

  • hint 5 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev
  • hint 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.01)
  • hint 1 finding(s) of low severity or rated minor by Jev: docs/prs/2026-10-11-PR#63-groovy-dsl.md:30
  • hint model recommends merge with caution

Findings

  1. Unclear wording at docs/prs/2026-10-11-PR#63-groovy-dsl.md:30, severity unknown, counted as medium, hint, as a line comment

Classifier

5 of 5 units passed all questions (1 PR document(s)).
1 answer ignored because of a confidence below [classifier] min_confidence.

Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 11823, calls 1, tokens in 11401 / out 11714 (reasoning included in out), duration 137.1 s, cost 0.0174 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3357, cost 0.0001 USD, finding judge `jev-1.13.0` calls 1, tokens in 1370, cost 0.0001 USD, build file judge `jev-1.13.0` calls 6, tokens in 4017, cost 0.0002 USD, phases: path_judge 0.5 s, classifier 0.4 s, context 1.1 s, model_review 134.3 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main d05e44c).
Reviewed head `cc923310c2100ddc3bbf51fb4714ad5e6d20913e` against base `d05e44cb6c86b9f1d1c8e9c4094dc0a62cc8fdf4`, werkrevisor 0.32.7.
<!-- werkrevisor:cc923310c2100ddc3bbf51fb4714ad5e6d20913e --> <!-- werkrevisor-verdict:GREEN --> <!-- werkrevisor-blocks:ab7f5c19f32c63de1ee2db9978748e13,5795a28ef1e8a6c3a063e0986290b224,96bc80c1109adddce9db46a9533dbe47,92315029dc915a40269e1ef3609bb10a,2c91041df07f4758ca8ff0e62cdd9015,5f4fabaad572bc0d7f156e4ab0e3543f,2b63943a2759df4a98fcaddb548fdb4d,0db997edc168cbbc280b32856151dce5,94a7e5f83c6ef1c2a6d2ee6cdbf569b8,3ce0a9c977e4abcbe4b38460a1c200dc,4f42955c21e1bbc294ed862f7146f083,b4d412320a2719cc4baab57ac1d8beb6,52d8dd6c08a3915f9ea5ebf39c51a88c --> <!-- werkrevisor-folded --> <details><summary>🟢 werkrevisor GREEN for <code>cc92331</code>, superseded by <a href="http://git.javagil.de/mi/werkcrappit/pulls/63#issuecomment-4029">the result for <code>7da8a01</code></a></summary> ## 🟢 werkrevisor: GREEN / PASS Gate: approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit. Change kind: `mixed`. ### Reasons - **hint** 5 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev - **hint** 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.01) - **hint** 1 finding(s) of low severity or rated minor by Jev: docs/prs/2026-10-11-PR#63-groovy-dsl.md:30 - **hint** model recommends merge with caution ### Findings 1. **Unclear wording** at `docs/prs/2026-10-11-PR#63-groovy-dsl.md:30`, severity unknown, counted as medium, hint, as a line comment ### Classifier 5 of 5 units passed all questions (1 PR document(s)). 1 answer ignored because of a confidence below [classifier] min_confidence. <sub> Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 11823, calls 1, tokens in 11401 / out 11714 (reasoning included in out), duration 137.1 s, cost 0.0174 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3357, cost 0.0001 USD, finding judge `jev-1.13.0` calls 1, tokens in 1370, cost 0.0001 USD, build file judge `jev-1.13.0` calls 6, tokens in 4017, cost 0.0002 USD, phases: path_judge 0.5 s, classifier 0.4 s, context 1.1 s, model_review 134.3 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main d05e44c).<br> Reviewed head `cc923310c2100ddc3bbf51fb4714ad5e6d20913e` against base `d05e44cb6c86b9f1d1c8e9c4094dc0a62cc8fdf4`, werkrevisor 0.32.7. </sub> </details>
ai-reviewer approved these changes 2026-10-11 17:14:35 +02:00
Dismissed
ai-reviewer left a comment
Collaborator

werkrevisor: GREEN / PASS for cc923310c2100ddc3bbf51fb4714ad5e6d20913e.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `cc923310c2100ddc3bbf51fb4714ad5e6d20913e`. The result comment of werkrevisor holds the details. <!-- werkrevisor-review:cc923310c2100ddc3bbf51fb4714ad5e6d20913e -->
@@ -0,0 +27,4 @@
- The fixture `gate-groovy` is `gate-java` with `settings.gradle` and `build.gradle` in the Groovy DSL,
using the published plugins and the blocks `pitest`, `werkcrappit` and `codeCharta`.
- `GroovyDslFunctionalTest` checks the report with real values, the exact gate on a decimal limit and the export.
- The README shows the tested Groovy setup; a limit there can be an integer or a decimal, as checked by hand with `30`.
Collaborator

Unclear wording, severity unknown, counted as medium (werkrevisor)

hint; Jev: real 0.84, severity 1.1 of 3

The phrase "as checked by hand with 30" in the Solution section is misleading. The functional tests exercise limits of 4 (integer) and 3.3333 (decimal) via -PmaxCrap=..., not 30; the value 30 is only the illustrative example in the README. No manual run with 30 is performed, and saying "checked by hand" suggests a verification that did not occur.

**Unclear wording**, severity unknown, counted as medium (werkrevisor) hint; Jev: real 0.84, severity 1.1 of 3 The phrase "as checked by hand with `30`" in the Solution section is misleading. The functional tests exercise limits of 4 (integer) and 3.3333 (decimal) via `-PmaxCrap=...`, not `30`; the value `30` is only the illustrative example in the README. No manual run with `30` is performed, and saying "checked by hand" suggests a verification that did not occur.
Author
Collaborator

Fixed in 7da8a01: the manual run did happen, with maxMutationCrap = 30 written in the fixture's build.gradle (mutationCrapCheck passed); the document now says so and that the tests pass the limit as a Gradle property.

Fixed in 7da8a01: the manual run did happen, with `maxMutationCrap = 30` written in the fixture's `build.gradle` (`mutationCrapCheck` passed); the document now says so and that the tests pass the limit as a Gradle property.
claude-code marked this conversation as resolved
Author
Collaborator

Round 1, fixed in 7da8a01: "Unclear wording", the PR document says how the integer limit was checked.

Round 1, fixed in 7da8a01: "Unclear wording", the PR document says how the integer limit was checked.
mi added 1 commit 2026-10-11 17:15:59 +02:00
PR document: how the integer limit was checked
ai-review/assessment AI review passed; approved by werkrevisor; merge scheduled for when the checks succeed
ai-review/gate build succeeded after 01:44
werkator build succeeded after 02:42
7da8a01d52
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mi dismissed ai-reviewer's review 2026-10-11 17:15:59 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Collaborator

🟢 werkrevisor: GREEN / PASS

Change kind: mixed.

Reasons

  • hint approval of werkrevisor for cc92331 not carried over: 1 approved block(s) are missing
  • hint 5 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev
  • hint 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.02, risk 0.00, security 0.01)

Classifier

5 of 5 units passed all questions (1 PR document(s)).

Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 11726, calls 1, tokens in 11311 / out 13530 (reasoning included in out), duration 101.3 s, cost 0.0196 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3391, cost 0.0001 USD, build file judge `jev-1.13.0` calls 6, tokens in 4017, cost 0.0002 USD, phases: path_judge 0.5 s, classifier 0.5 s, context 0.3 s, model_review 99.7 s, config: defaults + host + repository (.werkrevisor.toml at main d05e44c).
Reviewed head `7da8a01d5259c25d8cc2e84c83c097d65061d8d7` against base `d05e44cb6c86b9f1d1c8e9c4094dc0a62cc8fdf4`, werkrevisor 0.32.7.
<!-- werkrevisor:7da8a01d5259c25d8cc2e84c83c097d65061d8d7 --> <!-- werkrevisor-verdict:GREEN --> <!-- werkrevisor-blocks:ab7f5c19f32c63de1ee2db9978748e13,5795a28ef1e8a6c3a063e0986290b224,96bc80c1109adddce9db46a9533dbe47,92315029dc915a40269e1ef3609bb10a,2c91041df07f4758ca8ff0e62cdd9015,5f4fabaad572bc0d7f156e4ab0e3543f,70aff951851f3803262856aec1cd17f0,0db997edc168cbbc280b32856151dce5,94a7e5f83c6ef1c2a6d2ee6cdbf569b8,3ce0a9c977e4abcbe4b38460a1c200dc,4f42955c21e1bbc294ed862f7146f083,b4d412320a2719cc4baab57ac1d8beb6,52d8dd6c08a3915f9ea5ebf39c51a88c --> ## 🟢 werkrevisor: GREEN / PASS Change kind: `mixed`. ### Reasons - **hint** approval of werkrevisor for `cc92331` not carried over: 1 approved block(s) are missing - **hint** 5 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev - **hint** 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.02, risk 0.00, security 0.01) ### Classifier 5 of 5 units passed all questions (1 PR document(s)). <sub> Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 11726, calls 1, tokens in 11311 / out 13530 (reasoning included in out), duration 101.3 s, cost 0.0196 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3391, cost 0.0001 USD, build file judge `jev-1.13.0` calls 6, tokens in 4017, cost 0.0002 USD, phases: path_judge 0.5 s, classifier 0.5 s, context 0.3 s, model_review 99.7 s, config: defaults + host + repository (.werkrevisor.toml at main d05e44c).<br> Reviewed head `7da8a01d5259c25d8cc2e84c83c097d65061d8d7` against base `d05e44cb6c86b9f1d1c8e9c4094dc0a62cc8fdf4`, werkrevisor 0.32.7. </sub>
ai-reviewer left a comment
Collaborator

werkrevisor: GREEN / PASS for 7da8a01d5259c25d8cc2e84c83c097d65061d8d7.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `7da8a01d5259c25d8cc2e84c83c097d65061d8d7`. The result comment of werkrevisor holds the details. <!-- werkrevisor-review:7da8a01d5259c25d8cc2e84c83c097d65061d8d7 -->
ai-reviewer scheduled this pull request to auto merge when all checks succeed 2026-10-11 17:17:46 +02:00
ai-reviewer merged commit 0819bd40a9 into main 2026-10-11 17:18:50 +02:00
ai-reviewer deleted branch claude-code/groovy-dsl 2026-10-11 17:18:50 +02:00
Sign in to join this conversation.
No Reviewers
No labels
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mi/werkcrappit#63