RFC 0003, dependencies outside a package, levels as rows, a matrix (0.23.2) #49
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: mi/werkcrappit#49
Reference in New Issue
Block a user
RFC 0003, accepted, extends the structure view:
No change to the plugins. See
docs/prs/2026-10-09-PR#49-rfc-structure-view-context.md.🤖 Generated with Claude Code
WIP: RFC 0003, dependencies outside a package (0.23.2)to RFC 0003, dependencies outside a package, levels as rows, a matrix (0.23.2)🟢 werkrevisor GREEN for
a7b20f8, superseded by the result for2373ccb🟢 werkrevisor: GREEN / PASS
Gate: approved by werkrevisor; merge waits for 4 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit.
Change kind:
mixed.Reasons
Findings
WIP Contradiction at
docs/prs/2026-10-09-PR#49-rfc-structure-view-context.md:45, severity unknown, counted as medium, hint, as a line commentChangelog Describes Unimplemented Features at
CHANGELOG.md:6-14, severity unknown, counted as medium, hint, as a line commentClassifier
4 of 4 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 13262, calls 1, tokens in 12755 / out 10870 (reasoning included in out), duration 53.6 s, cost 0.0168 USD (reported), classifier `jev-1.13.0` calls 4, tokens in 3133, cost 0.0001 USD, finding judge `jev-1.13.0` calls 2, tokens in 3084, cost 0.0001 USD, build file judge `jev-1.13.0` calls 1, tokens in 656, cost 0.0000 USD, phases: path_judge 0.2 s, classifier 0.2 s, context 0.2 s, model_review 52.4 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main70b1e41).Reviewed head `a7b20f88e6f85d15a6f51e1d8309b392249b2456` against base `70b1e4187eb8512d8ebd7cb99be814e06b05456c`, werkrevisor 0.30.1.
werkrevisor: GREEN / PASS for
a7b20f88e6f85d15a6f51e1d8309b392249b2456.The result comment of werkrevisor holds the details.
@@ -3,6 +3,16 @@Every pull request adds its version here, newest first.The version in `build.gradle.kts` must match the top entry; `VersionConsistencyTest` checks it.## 0.23.2Changelog Describes Unimplemented Features, severity unknown, counted as medium (werkrevisor)
hint; Jev: real 0.84, severity 1.7 of 3
The 0.23.2 entry begins with "No change to the plugins." then describes in the present tense features ("each level diagram also shows...", "A second view...gets a tab of its own") that the CHANGELOG itself states are not part of this release. A changelog entry should describe what shipped in the version, not what the future implementation PRs of section 8 will deliver; placing that text under "## 0.23.2" risks misleading anyone who reads it as the release notes for the published 0.23.2 artifacts.
Fixed in
2373ccb: the 0.23.2 entry says the views are planned, not yet built, and describes what the accepted RFC plans.@@ -0,0 +42,4 @@Werkator is the pilot, hsadmin-ng follows in a step of its own.- The decisions were taken with mock-ups 3 to 8 from hsadmin-ng's code city of 2026-10-09.- Version 0.23.2; no change to the plugins.- The human user accepted the RFC on 2026-10-09; its status is `accepted`.WIP Contradiction, severity unknown, counted as medium (werkrevisor)
hint; Jev: real 0.73, severity 1.2 of 3
The PR description says "Stays WIP until the human user releases the RFC" yet this PR document states "The human user accepted the RFC on 2026-10-09; its status is
accepted." The two statements contradict each other on whether the PR must remain WIP. Resolve the state before merge: either re-add theWIP:prefix to the title or drop the "Stays WIP" line from the PR description so werkrevisor and the human reviewer see one clear status.Fixed: the PR description no longer says it stays WIP; the human user accepted the RFC on 2026-10-09, as the PR document says.
WIP:is off the title.@@ -133,1 +224,4 @@A sub-folder box and a package box outside lead down or across to that folder's diagram;a breadcrumb of the folder's path above the diagram leads back up to each parent.The browser's back button works too: each step changes the URL's fragment, `#<node ID>`, and the page draws that folder.- [x] Static or interactive?Writing rule: paragraph with 9 sentences, more than 5 (werkrevisor writing rule)
Fix the line, or reply why it stays, and resolve this comment.
Fixed in
2373ccb: the item is split into four sub-items of at most three sentences.@@ -162,0 +293,4 @@- [x] Can the pages be switched off?No. `mutationCrapCodeCharta` always writes both, without a new option: they take milliseconds and load nothing.- [x] Does the matrix keep its state in the URL?Yes. The open packages are in the URL's fragment, so the back button, a reload and a shared link keep them, as in the diagram.Writing rule: more than one sentence on a line (werkrevisor writing rule)
Fix the line, or reply why it stays, and resolve this comment.
Fixed in
2373ccb: "No." and "Yes." are joined to their sentence with a colon; the long line is wrapped.New commits pushed, approval review dismissed automatically according to repository settings
Answer to the werkrevisor review of
a7b20f8:2373ccb; the 0.23.2 entry says the views are planned, not yet built.2373ccb.build.gradle.kts: the version only, 0.23.2.All four threads have a reply and are resolved.
🟢 werkrevisor: GREEN / PASS
Change kind:
mixed.Reasons
Classifier
4 of 4 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 13277, calls 1, tokens in 12770 / out 13188 (reasoning included in out), duration 96.2 s, cost 0.0196 USD (reported), classifier `jev-1.13.0` calls 4, tokens in 3133, cost 0.0001 USD, build file judge `jev-1.13.0` calls 1, tokens in 656, cost 0.0000 USD, phases: path_judge 0.3 s, classifier 0.3 s, context 0.2 s, model_review 94.6 s, config: defaults + host + repository (.werkrevisor.toml at main70b1e41).Reviewed head `2373ccb55c98e7fe986268e673fc9dc3bb8b9a13` against base `70b1e4187eb8512d8ebd7cb99be814e06b05456c`, werkrevisor 0.30.1.
werkrevisor: GREEN / PASS for
2373ccb55c98e7fe986268e673fc9dc3bb8b9a13.The result comment of werkrevisor holds the details.