39 lines
1.5 KiB
Markdown
39 lines
1.5 KiB
Markdown
# PR#158: The Codex Review Holds the Merge on Werkator
|
|
|
|
> **WARNING:** This document describes only the change applied in this PR.
|
|
> It may already be outdated once the next PR is merged.
|
|
> Historic PR documentation is not maintained along with new PRs; treat it as a snapshot.
|
|
|
|
## Related Links
|
|
|
|
- [werkrevisor PR#88](https://git.javagil.de/mi/werkrevisor/pulls/88): the runner of the Codex review and `[codex] mode`.
|
|
- [werkrevisor PR#105](https://git.javagil.de/mi/werkrevisor/pulls/105): the first PR through the gate.
|
|
|
|
## Problem
|
|
|
|
Werkator runs the builds and the review gate of all werk repositories, with their secrets.
|
|
Since PR#153 the Codex review only advises on Werkator.
|
|
On werkrevisor the gate works since werkrevisor PR#105:
|
|
an open Codex finding held the merge, and after the fix the automerge followed without a human.
|
|
The user chose Werkator as the second repository with `gate`.
|
|
|
|
## Non-Goals
|
|
|
|
- No change of the code of Werkator.
|
|
|
|
## Solution
|
|
|
|
- `.werkrevisor.toml`: `[codex] mode = "gate"`.
|
|
- AGENTS.md: the branch protection also requires `ai-review/codex`.
|
|
- Werkbaum: the node of the Codex review below `#process` holds the merge.
|
|
- Version v1.42.2, internal.
|
|
|
|
The runner reads the mode at the head of `main`, so this PR itself is not held by `ai-review/codex`.
|
|
After the merge the human adds `ai-review/codex` to the required status checks of `main`,
|
|
e.g. with `tools/branch-protection` of werkrevisor, first with `--dry-run`.
|
|
With the workstation off, a Werkator PR waits with the status `pending`.
|
|
|
|
## Open Questions
|
|
|
|
None.
|