mi/werkator
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Deflake the maxConcurrent-1 BuildExecutor test #20

Open
mi wants to merge 0 commits from mi/deflake-maxconcurrent-test AGit into main
pull from: mi/deflake-maxconcurrent-test
merge into: :main
Conversation 0 Commits - Files Changed -
mi commented 2026-09-04 08:52:39 +02:00
Owner
Copy Link
Copy Source

The build of branch-a slept one second while the test asserted, without
any synchronization, that branch-b was still PENDING.
Under CPU contention on the mih09 host the sleep could elapse first, so
branch-b was already RUNNING or SUCCESS when the assertion ran.
branch-a now blocks until the test creates a gate file, and the test
first waits for branch-a to be RUNNING; the PENDING assertion no longer
depends on timing.

Co-Authored-By: Claude Opus 5 noreply@anthropic.com

The build of branch-a slept one second while the test asserted, without any synchronization, that branch-b was still PENDING. Under CPU contention on the mih09 host the sleep could elapse first, so branch-b was already RUNNING or SUCCESS when the assertion ran. branch-a now blocks until the test creates a gate file, and the test first waits for branch-a to be RUNNING; the PENDING assertion no longer depends on timing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
mi added 1 commit 2026-09-04 08:52:39 +02:00
test(build): gate the maxConcurrent-1 test instead of racing a sleep 9221550a2a 
The build of branch-a slept one second while the test asserted, without
any synchronization, that branch-b was still PENDING.
Under CPU contention on the mih09 host the sleep could elapse first, so
branch-b was already RUNNING or SUCCESS when the assertion ran.
branch-a now blocks until the test creates a gate file, and the test
first waits for branch-a to be RUNNING; the PENDING assertion no longer
depends on timing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
mi added 1 commit 2026-09-04 08:53:07 +02:00
docs(prs): the deflake-maxconcurrent-test PR-doc 5c73c4cc21 
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
mi marked the pull request as ready for review 2026-09-04 08:59:58 +02:00
This branch is already included in the target branch. There is nothing to merge.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin refs/pull/20/head:mi/deflake-maxconcurrent-test
git checkout mi/deflake-maxconcurrent-test
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
mi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mi/werkator#20