Slot tests without waiting (v1.38.8) #141

2026-10-10T11:04:59+02:00

claude-code commented

2026-10-10 11:04:59 +02:00

BuildSlotsUnitTest proves a waiting build with a 300 ms timeout in every test; it now sees the build queue at the semaphore. See docs/prs/2026-10-10-PR#141-slot-tests-without-waiting.md.

🤖 Generated with Claude Code

BuildSlotsUnitTest proves a waiting build with a 300 ms timeout in every test; it now sees the build queue at the semaphore. See docs/prs/2026-10-10-PR#141-slot-tests-without-waiting.md. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

mi added 2 commits 2026-10-10 11:23:44 +02:00

WIP: slot tests observe a waiting build instead of sleeping 81b17a0e16

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Slot tests observe a waiting build instead of sleeping (v1.38.8)

werkator build succeeded after 02:46

Details

ai-review/assessment AI review passed; approved by werkrevisor; merge scheduled for when the checks succeed

Details

ai-review/gate build succeeded after 04:06

Details

8419b2cf87

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mi force-pushed mihoe/slots-tests-without-waiting from a9267ddcea to 8419b2cf87

2026-10-10 11:23:44 +02:00

Compare

claude-code marked the pull request as ready for review 2026-10-10 11:29:49 +02:00

ai-reviewer commented

2026-10-10 11:34:00 +02:00

🟢 werkrevisor: GREEN / PASS

Change kind: mixed.

Reasons

hint 2 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev
hint 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.01)
hint 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (each larger than [review] max_full_file_chars = 80000): src/main/resources/templates/releases.html
hint 1 finding(s) of low severity or rated minor by Jev: docs/prs/2026-10-10-PR#141-slot-tests-without-waiting.md:20

Findings

[low] Awkward Wording at docs/prs/2026-10-10-PR#141-slot-tests-without-waiting.md:20

hint

The closing clause "and fails at once then" in the Scenarios section is grammatically awkward: "then" is dangling and the reader has to infer what condition would trigger the failure. The new helper uses eventually(5.seconds), so when neither the build is queued nor done, the test fails only after that 5-second polling window, not "at once". A clearer phrasing would state explicitly what happens when neither condition is met within the timeout.

Classifier

5 of 5 units passed all questions (1 PR document(s)).
1 answer ignored because of a confidence below [classifier] min_confidence.

_{Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 21372, calls 1, tokens in 20593 / out 21239 (reasoning included in out), duration 240.5 s, cost 0.0316 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3509, cost 0.0001 USD, finding judge `none` calls 0, tokens in 0, cost 0.0000 USD, excerpt selection `openrouter/openai/gpt-6-luna` calls 1, tokens in 29478 / out 132, cost 0.0038 USD (reported), build file judge `jev-1.13.0` calls 3, tokens in 3850, cost 0.0002 USD, phases: path_judge 0.3 s, classifier 0.5 s, context 5.6 s, model_review 233.8 s, finding_judge 0.0 s, config: defaults + host + repository (.werkrevisor.toml at main a142c40).

Reviewed head `8419b2cf87d3f1e86251f91935c0a04b204abe9c` against base `a142c40192a339294d5f66e11beaf27278d75509`, werkrevisor 0.31.3.}

## 🟢 werkrevisor: GREEN / PASS Change kind: `mixed`. ### Reasons - **hint** 2 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev - **hint** 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.01) - **hint** 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (each larger than [review] max_full_file_chars = 80000): src/main/resources/templates/releases.html - **hint** 1 finding(s) of low severity or rated minor by Jev: docs/prs/2026-10-10-PR#141-slot-tests-without-waiting.md:20 ### Findings 1. **[low] Awkward Wording** at `docs/prs/2026-10-10-PR#141-slot-tests-without-waiting.md:20` hint The closing clause "and fails at once then" in the Scenarios section is grammatically awkward: "then" is dangling and the reader has to infer what condition would trigger the failure. The new helper uses `eventually(5.seconds)`, so when neither the build is queued nor done, the test fails only after that 5-second polling window, not "at once". A clearer phrasing would state explicitly what happens when neither condition is met within the timeout. ### Classifier 5 of 5 units passed all questions (1 PR document(s)). 1 answer ignored because of a confidence below [classifier] min_confidence. <sub> Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 21372, calls 1, tokens in 20593 / out 21239 (reasoning included in out), duration 240.5 s, cost 0.0316 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3509, cost 0.0001 USD, finding judge `none` calls 0, tokens in 0, cost 0.0000 USD, excerpt selection `openrouter/openai/gpt-6-luna` calls 1, tokens in 29478 / out 132, cost 0.0038 USD (reported), build file judge `jev-1.13.0` calls 3, tokens in 3850, cost 0.0002 USD, phases: path_judge 0.3 s, classifier 0.5 s, context 5.6 s, model_review 233.8 s, finding_judge 0.0 s, config: defaults + host + repository (.werkrevisor.toml at main a142c40).<br> Reviewed head `8419b2cf87d3f1e86251f91935c0a04b204abe9c` against base `a142c40192a339294d5f66e11beaf27278d75509`, werkrevisor 0.31.3. </sub>

ai-reviewer approved these changes

2026-10-10 11:34:01 +02:00

ai-reviewer left a comment

werkrevisor: GREEN / PASS for 8419b2cf87d3f1e86251f91935c0a04b204abe9c.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `8419b2cf87d3f1e86251f91935c0a04b204abe9c`. The result comment of werkrevisor holds the details.

ai-reviewer scheduled this pull request to auto merge when all checks succeed 2026-10-10 11:34:01 +02:00

ai-reviewer merged commit c8366c1420 into main

2026-10-10 11:34:04 +02:00

ai-reviewer deleted branch mihoe/slots-tests-without-waiting

2026-10-10 11:34:04 +02:00

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mi/werkator#141