Pull-request target builds: trigger.onPullRequestTarget (v1.36.0) #117

2026-10-04T21:34:38+02:00

mi commented

2026-10-04 21:34:38 +02:00

Pull-request target builds: trigger.onPullRequestTarget runs every open, non-draft pull request once per head commit, on a fresh checkout of its base.
The definition is host-only: a branch can neither add, change nor switch off such a build, so the pull request under review cannot fake the status or reach the secrets.
The status goes to the head SHA; the build gets WERKATOR_PR_* and WERKATOR_GITEA_*.
export:forgejo maps it to pull_request_target.

Motivation: an AI review gate (werkrevisor, PR-Agent based) as a merge condition.
Details: the PR-doc under docs/prs/ (still with the placeholder PR#33, renamed in a follow-up commit).

🤖 Generated with Claude Code

Pull-request target builds: `trigger.onPullRequestTarget` runs every open, non-draft pull request once per head commit, on a fresh checkout of its base. The definition is host-only: a branch can neither add, change nor switch off such a build, so the pull request under review cannot fake the status or reach the secrets. The status goes to the head SHA; the build gets `WERKATOR_PR_*` and `WERKATOR_GITEA_*`. `export:forgejo` maps it to `pull_request_target`. Motivation: an AI review gate (werkrevisor, PR-Agent based) as a merge condition. Details: the PR-doc under `docs/prs/` (still with the placeholder PR#33, renamed in a follow-up commit). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

mi added 10 commits 2026-10-04 22:10:29 +02:00

trigger.onPullRequestTarget: a host-only build definition a branch can neither add, change nor switch off 03fe3d6efb

The branch layer loses every pull-request target definition before the merge,
and the host's definitions are put back as the primary configuration resolves them,
so not even an inherited builds.default setting comes from the branch.
Combinations with other triggers, requirePullRequest, builds.default and follow-ups are refused at start.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Open pull requests are read with head, base, draft and fork marks; a refresh answers with this read alone b2262434b3

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

A pull-request target build runs its base in a fresh workspace, reports on its head and knows its pull request 55bf9657f7

The settings come from the primary configuration alone, and a definition run without
its pull request (or pull-request data on any other definition) is refused.
The result records the pull request, so a re-run builds the same head on the same base.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

The watcher enqueues every open, non-draft pull request once per head; re-runs keep the recorded pull request 625084d616

The decision lives in PullRequestTargets, fed by this cycle's read of the forge and the primary definitions only.
Without a forge connection the watcher says once that the builds never run.
Startup recovery, UI restart and retry re-run a pull-request target build with its recorded pull request,
and such a build triggers no follow-ups.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

export:forgejo maps onPullRequestTarget to pull_request_target on the base, skipping drafts f6722c933f

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Pull-request target builds documented: configuration reference, init template, invariants, PR-doc; v1.36.0 925c2dd119

The release notes of v1.35.0 get their missing closing </ul>.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs: PR#117 replaces the PR#33 placeholder in the PR-doc and the scenario IDs 3b479609f2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

export:forgejo writes pull_request_target in the job header and steps of PR#115, its notes as a topic of their own 3ea2beb7c5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

PullRequestTargetBuildIntegrationTest waits for the terminal Gitea status, which is posted after the result is stored b512c74c21

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

ktlint wraps the context name the Scenario#117 rename made too long

werkator build succeeded after 02:25

Details

cb93e4cace

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mi force-pushed mihoe/pull-request-target from 250ddd0ca8 to cb93e4cace

2026-10-04 22:10:29 +02:00

Compare

mi marked the pull request as ready for review 2026-10-05 05:10:25 +02:00

mi added 1 commit 2026-10-05 05:13:50 +02:00

Merge remote-tracking branch 'origin/main' into mihoe/pull-request-target

werkator build succeeded after 02:36

Details

557abccbe5

# Conflicts:
#	build.gradle.kts
#	src/main/resources/templates/releases.html

mi merged commit 39df99e81d into main

2026-10-05 05:33:09 +02:00

mi deleted branch mihoe/pull-request-target

2026-10-05 05:33:09 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mi/werkator#117