Answer to the review of 7c9395f (rebased onto 0.57.0, version 0.58.0):
- Codex: no findings.
- werkrevisor YELLOW: only the structural reasons, the risky paths
**/*secret*and the size; left…
153a693727
werkrevisor 0.59.0: hs-review --attach posts the checked draft and its diagrams to the PR
ddb8e56722
Review round 4: unreadable backups stop purge; fetch brings a missing old value into secrets.env; local errors exit with 2
b93e8637e6
Review round 1: Gitea probe checks the write scopes; purge only by backup names; unreadable configs are errors
Holds not: this file changes only the version, 0.57.1, as the PR document states under its title (Version: patch). The implementation is in werkrevisor/cli.py and werkrevisor/prlens.py.
Fixed in 7cc5832: the test puts an earlier SVG into the output directory and next to the draft; after a run without new diagrams both are empty and the draft has no Diagrams section.
5f58756837
werkrevisor 0.57.0: review-report uses prlens.ASSET_PREFIX; Scenario#129.03 runs a GREEN dry run
83f489aad4
hs-review draws the diagrams also for GREEN; a run without new diagrams shows none of an earlier run
No change; the finding does not hold for docker run --env-file. docker/cli's parser (pkg/kvfile/kvfile.go, parseKeyValueFile) interprets neither quotes nor escapes: it trims leading whitespace…
e9c77a3328
Review: a line of 64 KiB stays on the command line; two builds may create the env-file directory together
Fixed in e9c77a3: fits also requires the UTF-8 line KEY=VALUE to stay below 64 KiB; a longer one stays --env KEY=VALUE on the command line, as before. DockerEnvFileUnitTest covers a 70 KiB…
Fixed in e9c77a3: SecretFiles.createDirectoriesOwnerOnly takes a directory that another thread created in the meantime and fails only if the path is no directory. DockerEnvFileUnitTest starts…
Fixed in a9f44a8: the export is a plain assignment now, so set -e stops fetch with the exit code of the host. test_fetch_stops_if_the_host_holds_no_single_value exited with 0 without the…