werkrevisor 0.64.0: draft-review --attach --checked posts a draft with the reason why its last points do not hold #136

2026-10-23T12:30:08+02:00

claude-code commented

2026-10-23 12:30:08 +02:00

See docs/prs for the PR document.

🤖 Generated with Claude Code

See docs/prs for the PR document. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-code added 1 commit 2026-10-23 12:30:08 +02:00

PR document: draft-review --attach --checked posts a draft with the reason why its last points do not hold fd2f4cb0ac

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-code added 1 commit 2026-10-23 12:30:10 +02:00

PR document gets the number 136

werkator build succeeded after 02:40

Details

werkator/werkrevisor-statistics build succeeded after 00:34

Details

e656dc6fdd

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-code added 1 commit 2026-10-23 12:32:24 +02:00

werkrevisor 0.64.0: draft-review --attach --checked posts a draft with the reason why its last points do not hold

ai-review/codex Codex review passed

werkator build succeeded after 00:12

Details

ai-review/assessment AI review passed; approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit

Details

ai-review/gate build succeeded after 12:07

Details

werkator/werkrevisor-statistics build succeeded after 00:39

Details

16c1057b0c

--checked REASON or --checked-file FILE|- replaces the line '> **Draft:** …' with 'Checked before posting'
and the reason; an empty reason is refused. No one has to edit the report.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-code marked the pull request as ready for review 2026-10-23 12:35:25 +02:00

ai-reviewer commented

2026-10-23 12:47:33 +02:00

🟢 werkrevisor GREEN for 16c1057, superseded by the result for 7a74f17

🟢 werkrevisor: GREEN / PASS

Gate: approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit.

Change kind: mixed.

Reasons

hint writing rules violated in the changed docs: docs/prs/2026-10-23-PR#136-attach-checked.md:59: more than one sentence on a line
hint 6 changed file(s) that neither weaken the checks, touch security nor show a risk category of the repository config according to Jev
hint 1 build change(s) of low risk according to Jev: statistics/build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.02)
hint 9 changed file(s) agree with the PR document according to Jev
hint the model review failed: TimeoutError: review exceeded 720 seconds (advisory: Jev judged every changed file)

Classifier

6 of 6 units passed all questions (1 PR document(s)).
2 answers ignored because of a confidence below [classifier] min_confidence.

_{Usage: model `openrouter/minimax/minimax-m3`, LLM failed (TimeoutError), tokens counted before the call 32045, duration 725.2 s, cost unknown, classifier `jev-1.14.0` calls 6, tokens in 4733, cost 0.0002 USD, PR document check `jev-1.14.0` calls 9, tokens in 19262, cost 0.0008 USD, build file judge `jev-1.14.0` calls 7, tokens in 6311, cost 0.0003 USD, phases: path_judge 0.4 s, classifier 0.4 s, doc_check 0.5 s, context 0.3 s, model_review 723.2 s, config: defaults + host + repository (.werkrevisor.toml at main 4ed2f1d).

Reviewed head `16c1057b0c5f9532384dbf6a346beabaffe184a2` against base `4ed2f1d19761bbc81b86dedd0e55b56ce8d27908`, werkrevisor 0.62.0.}

<details><summary>🟢 werkrevisor GREEN for <code>16c1057</code>, superseded by <a href="http://git.javagil.de/mi/werkrevisor/pulls/136#issuecomment-7227">the result for <code>7a74f17</code></a></summary> ## 🟢 werkrevisor: GREEN / PASS Gate: approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit. Change kind: `mixed`. ### Reasons - **hint** writing rules violated in the changed docs: docs/prs/2026-10-23-PR#136-attach-checked.md:59: more than one sentence on a line - **hint** 6 changed file(s) that neither weaken the checks, touch security nor show a risk category of the repository config according to Jev - **hint** 1 build change(s) of low risk according to Jev: statistics/build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.02) - **hint** 9 changed file(s) agree with the PR document according to Jev - **hint** the model review failed: TimeoutError: review exceeded 720 seconds (advisory: Jev judged every changed file) ### Classifier 6 of 6 units passed all questions (1 PR document(s)). 2 answers ignored because of a confidence below [classifier] min_confidence. Usage: model `openrouter/minimax/minimax-m3`, LLM failed (TimeoutError), tokens counted before the call 32045, duration 725.2 s, cost unknown, classifier `jev-1.14.0` calls 6, tokens in 4733, cost 0.0002 USD, PR document check `jev-1.14.0` calls 9, tokens in 19262, cost 0.0008 USD, build file judge `jev-1.14.0` calls 7, tokens in 6311, cost 0.0003 USD, phases: path_judge 0.4 s, classifier 0.4 s, doc_check 0.5 s, context 0.3 s, model_review 723.2 s, config: defaults + host + repository (.werkrevisor.toml at main 4ed2f1d). Reviewed head `16c1057b0c5f9532384dbf6a346beabaffe184a2` against base `4ed2f1d19761bbc81b86dedd0e55b56ce8d27908`, werkrevisor 0.62.0. </details>

ai-reviewer approved these changes

2026-10-23 12:47:33 +02:00

Dismissed

ai-reviewer left a comment

werkrevisor: GREEN / PASS for 16c1057b0c5f9532384dbf6a346beabaffe184a2.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `16c1057b0c5f9532384dbf6a346beabaffe184a2`. The result comment of werkrevisor holds the details.

docs/prs/2026-10-23-PR#136-attach-checked.md Outdated

						
				@@ -0,0 +56,4 @@

				- `werkrevisor/reviewreport.py`: `attach` takes a reason; `confirm` replaces the draft line with

				  "> **Checked before posting:**" and the reason as a quote, or puts both under the title of a draft

				  whose draft line a human deleted. An empty reason is refused before any write.

ai-reviewer commented

2026-10-23 12:47:33 +02:00

Writing rule: more than one sentence on a line (werkrevisor writing rule)

Fix the line, or reply why it stays, and resolve this comment.

**Writing rule: more than one sentence on a line** (werkrevisor writing rule) Fix the line, or reply why it stays, and resolve this comment.

claude-code commented

2026-10-23 12:48:08 +02:00

Fixed in 7a74f17: one sentence per line.

Fixed in `7a74f17`: one sentence per line.

claude-code marked this conversation as resolved

claude-code added 1 commit 2026-10-23 12:48:10 +02:00

PR document: one sentence per line

werkator build succeeded after 00:14

Details

werkator/werkrevisor-statistics build succeeded after 00:32

Details

ai-review/assessment AI review passed; approved by werkrevisor; merge scheduled for when the checks succeed

Details

ai-review/codex 1 open Codex finding(s); resolve each line comment

ai-review/gate build succeeded after 12:07

Details

7a74f17525

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-code dismissed ai-reviewer's review 2026-10-23 12:48:10 +02:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

ai-reviewer commented

2026-10-23 12:49:01 +02:00

Codex review: not critical

The change adds an explicit confirmation reason when posting draft comments; it does not alter authorization, credentials, or merge gates. Stale-head, mismatched-review, empty-reason, and duplicate-post protections remain effective.

No findings.

The merge waits for the status ai-review/codex: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here.

_{Model `gpt-6-astra`, effort high, tokens in 167609 (cached 120832) / out 1485, 59.6 s, 10 commands; reviewed head `16c1057b0c5f9532384dbf6a346beabaffe184a2`.}

## Codex review: not critical The change adds an explicit confirmation reason when posting draft comments; it does not alter authorization, credentials, or merge gates. Stale-head, mismatched-review, empty-reason, and duplicate-post protections remain effective. No findings. The merge waits for the status `ai-review/codex`: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here. Model `gpt-6-astra`, effort high, tokens in 167609 (cached 120832) / out 1485, 59.6 s, 10 commands; reviewed head `16c1057b0c5f9532384dbf6a346beabaffe184a2`.

ai-reviewer commented

2026-10-23 13:09:48 +02:00

🟢 werkrevisor GREEN for 7a74f17, superseded by the result for 02b8505

🟢 werkrevisor: GREEN / PASS

Change kind: mixed.

Reasons

hint approval of werkrevisor for 16c1057 not carried over: 1 approved block(s) are missing
hint 6 changed file(s) that neither weaken the checks, touch security nor show a risk category of the repository config according to Jev
hint 1 build change(s) of low risk according to Jev: statistics/build.gradle.kts (weakens checks 0.02, risk 0.00, security 0.02)
hint 9 changed file(s) agree with the PR document according to Jev
hint the model review failed: TimeoutError: review exceeded 720 seconds (advisory: Jev judged every changed file)

Classifier

6 of 6 units passed all questions (1 PR document(s)).
2 answers ignored because of a confidence below [classifier] min_confidence.

_{Usage: model `openrouter/minimax/minimax-m3`, LLM failed (TimeoutError), tokens counted before the call 32054, duration 724.9 s, cost unknown, classifier `jev-1.14.0` calls 6, tokens in 4734, cost 0.0002 USD, PR document check `jev-1.14.0` calls 9, tokens in 19271, cost 0.0008 USD, build file judge `jev-1.14.0` calls 7, tokens in 6311, cost 0.0003 USD, phases: path_judge 0.4 s, classifier 0.3 s, doc_check 0.6 s, context 0.3 s, model_review 722.8 s, config: defaults + host + repository (.werkrevisor.toml at main 4ed2f1d).

Reviewed head `7a74f17525ae0d2ba0c5fa1c31044b3b7de6a10f` against base `4ed2f1d19761bbc81b86dedd0e55b56ce8d27908`, werkrevisor 0.62.0.}

<details><summary>🟢 werkrevisor GREEN for <code>7a74f17</code>, superseded by <a href="http://git.javagil.de/mi/werkrevisor/pulls/136#issuecomment-7252">the result for <code>02b8505</code></a></summary> ## 🟢 werkrevisor: GREEN / PASS Change kind: `mixed`. ### Reasons - **hint** approval of werkrevisor for `16c1057` not carried over: 1 approved block(s) are missing - **hint** 6 changed file(s) that neither weaken the checks, touch security nor show a risk category of the repository config according to Jev - **hint** 1 build change(s) of low risk according to Jev: statistics/build.gradle.kts (weakens checks 0.02, risk 0.00, security 0.02) - **hint** 9 changed file(s) agree with the PR document according to Jev - **hint** the model review failed: TimeoutError: review exceeded 720 seconds (advisory: Jev judged every changed file) ### Classifier 6 of 6 units passed all questions (1 PR document(s)). 2 answers ignored because of a confidence below [classifier] min_confidence. Usage: model `openrouter/minimax/minimax-m3`, LLM failed (TimeoutError), tokens counted before the call 32054, duration 724.9 s, cost unknown, classifier `jev-1.14.0` calls 6, tokens in 4734, cost 0.0002 USD, PR document check `jev-1.14.0` calls 9, tokens in 19271, cost 0.0008 USD, build file judge `jev-1.14.0` calls 7, tokens in 6311, cost 0.0003 USD, phases: path_judge 0.4 s, classifier 0.3 s, doc_check 0.6 s, context 0.3 s, model_review 722.8 s, config: defaults + host + repository (.werkrevisor.toml at main 4ed2f1d). Reviewed head `7a74f17525ae0d2ba0c5fa1c31044b3b7de6a10f` against base `4ed2f1d19761bbc81b86dedd0e55b56ce8d27908`, werkrevisor 0.62.0. </details>

ai-reviewer approved these changes

2026-10-23 13:09:48 +02:00

Dismissed

ai-reviewer left a comment

werkrevisor: GREEN / PASS for 7a74f17525ae0d2ba0c5fa1c31044b3b7de6a10f.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `7a74f17525ae0d2ba0c5fa1c31044b3b7de6a10f`. The result comment of werkrevisor holds the details.

ai-reviewer scheduled this pull request to auto merge when all checks succeed 2026-10-23 13:09:48 +02:00

ai-reviewer reviewed

2026-10-23 13:12:05 +02:00

ai-reviewer left a comment

Codex review of 7a74f17525ae0d2ba0c5fa1c31044b3b7de6a10f

Codex review of `7a74f17525ae0d2ba0c5fa1c31044b3b7de6a10f`

werkrevisor/reviewreport.py Outdated

						
				@@ -77,0 +85,4 @@

				    drafts = [i for i, line in enumerate(header) if line.startswith(DRAFT_LINE)]

				    if drafts:

				        header[drafts[0]:drafts[0] + 1] = block

				        header = [line for i, line in enumerate(header) if not (line.startswith(DRAFT_LINE) and i > drafts[0])]

ai-reviewer commented

2026-10-23 13:12:05 +02:00

[low] Draft-line cleanup can delete the supplied reason (Codex review)

The cleanup runs after inserting the reason and also filters its lines. For example, --checked '**Draft:** the remaining finding is already covered.' successfully posts only the “Checked before posting” label, silently deleting the entire explanation. Remove original draft lines before inserting the reason so supplied text is preserved.

Fix it, or reply why it does not hold, and resolve this comment.

**[low] Draft-line cleanup can delete the supplied reason** (Codex review) The cleanup runs after inserting the reason and also filters its lines. For example, `--checked '**Draft:** the remaining finding is already covered.'` successfully posts only the “Checked before posting” label, silently deleting the entire explanation. Remove original draft lines before inserting the reason so supplied text is preserved. Fix it, or reply why it does not hold, and resolve this comment.

claude-code commented

2026-10-23 13:14:04 +02:00

Fixed in 02b8505: confirm removes the draft lines before it inserts the reason, and attach checks for a draft line only without a reason. Red/green: test_a_reason_that_quotes_the_draft_line_stays_whole failed before the fix and passes with it.

Fixed in `02b8505`: `confirm` removes the draft lines before it inserts the reason, and `attach` checks for a draft line only without a reason. Red/green: `test_a_reason_that_quotes_the_draft_line_stays_whole` failed before the fix and passes with it.

claude-code marked this conversation as resolved

ai-reviewer commented

2026-10-23 13:12:05 +02:00

Codex review: not critical

The change adds confirmation text to manually posted draft comments. It does not alter merge gates, authorization, credentials, or existing stored data.

Findings

[low] Draft-line cleanup can delete the supplied reason at werkrevisor/reviewreport.py:88, as a line comment

The merge waits for the status ai-review/codex: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here.

_{Model `gpt-6-astra`, effort high, tokens in 258147 (cached 205952) / out 1549, 66.2 s, 7 commands; reviewed head `7a74f17525ae0d2ba0c5fa1c31044b3b7de6a10f`.}

## Codex review: not critical The change adds confirmation text to manually posted draft comments. It does not alter merge gates, authorization, credentials, or existing stored data. ### Findings 1. **[low] Draft-line cleanup can delete the supplied reason** at `werkrevisor/reviewreport.py:88`, as a line comment The merge waits for the status `ai-review/codex`: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here. Model `gpt-6-astra`, effort high, tokens in 258147 (cached 205952) / out 1549, 66.2 s, 7 commands; reviewed head `7a74f17525ae0d2ba0c5fa1c31044b3b7de6a10f`.

claude-code added 1 commit 2026-10-23 13:14:06 +02:00

--checked keeps a reason whole that starts with the words of the draft line

ai-review/assessment AI review passed; approved by werkrevisor; merge already scheduled

Details

werkator build succeeded after 00:20

Details

werkator/werkrevisor-statistics build succeeded after 00:59

Details

ai-review/gate build succeeded after 12:22

Details

ai-review/codex Codex review passed

02b8505916

Found by the Codex review of 16c1057 (line comment 7230).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-code dismissed ai-reviewer's review 2026-10-23 13:14:06 +02:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

ai-reviewer commented

2026-10-23 13:30:09 +02:00

🟢 werkrevisor: GREEN / PASS

Change kind: mixed.

Reasons

hint approval of werkrevisor for 7a74f17 not carried over: 4 approved block(s) are missing
hint 6 changed file(s) that neither weaken the checks, touch security nor show a risk category of the repository config according to Jev
hint 1 build change(s) of low risk according to Jev: statistics/build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.02)
hint 9 changed file(s) agree with the PR document according to Jev
hint the model review failed: TimeoutError: review exceeded 720 seconds (advisory: Jev judged every changed file)

Classifier

6 of 6 units passed all questions (1 PR document(s)).
1 answer ignored because of a confidence below [classifier] min_confidence.

_{Usage: model `openrouter/minimax/minimax-m3`, LLM failed (TimeoutError), tokens counted before the call 32268, duration 736.1 s, cost unknown, classifier `jev-1.14.0` calls 6, tokens in 4734, cost 0.0002 USD, PR document check `jev-1.14.0` calls 9, tokens in 19815, cost 0.0008 USD, build file judge `jev-1.14.0` calls 7, tokens in 6549, cost 0.0003 USD, phases: path_judge 0.3 s, classifier 0.4 s, doc_check 0.5 s, context 1.0 s, model_review 733.3 s, config: defaults + host + repository (.werkrevisor.toml at main 4ed2f1d).

Reviewed head `02b8505916532b5245b733ad3ee88ac778bd5df4` against base `4ed2f1d19761bbc81b86dedd0e55b56ce8d27908`, werkrevisor 0.62.0.}

## 🟢 werkrevisor: GREEN / PASS Change kind: `mixed`. ### Reasons - **hint** approval of werkrevisor for `7a74f17` not carried over: 4 approved block(s) are missing - **hint** 6 changed file(s) that neither weaken the checks, touch security nor show a risk category of the repository config according to Jev - **hint** 1 build change(s) of low risk according to Jev: statistics/build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.02) - **hint** 9 changed file(s) agree with the PR document according to Jev - **hint** the model review failed: TimeoutError: review exceeded 720 seconds (advisory: Jev judged every changed file) ### Classifier 6 of 6 units passed all questions (1 PR document(s)). 1 answer ignored because of a confidence below [classifier] min_confidence. Usage: model `openrouter/minimax/minimax-m3`, LLM failed (TimeoutError), tokens counted before the call 32268, duration 736.1 s, cost unknown, classifier `jev-1.14.0` calls 6, tokens in 4734, cost 0.0002 USD, PR document check `jev-1.14.0` calls 9, tokens in 19815, cost 0.0008 USD, build file judge `jev-1.14.0` calls 7, tokens in 6549, cost 0.0003 USD, phases: path_judge 0.3 s, classifier 0.4 s, doc_check 0.5 s, context 1.0 s, model_review 733.3 s, config: defaults + host + repository (.werkrevisor.toml at main 4ed2f1d). Reviewed head `02b8505916532b5245b733ad3ee88ac778bd5df4` against base `4ed2f1d19761bbc81b86dedd0e55b56ce8d27908`, werkrevisor 0.62.0.

ai-reviewer approved these changes

2026-10-23 13:30:09 +02:00

ai-reviewer left a comment

werkrevisor: GREEN / PASS for 02b8505916532b5245b733ad3ee88ac778bd5df4.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `02b8505916532b5245b733ad3ee88ac778bd5df4`. The result comment of werkrevisor holds the details.

ai-reviewer commented

2026-10-23 13:31:54 +02:00

Codex review: not critical

The change adds an explicit confirmation reason to posted draft comments while preserving commit checks. It does not alter merge gates, authentication, permissions, or existing data irreversibly.

No findings.

The merge waits for the status ai-review/codex: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here.

_{Model `gpt-6-astra`, effort high, tokens in 232146 (cached 193920) / out 1415, 46.2 s, 9 commands; reviewed head `02b8505916532b5245b733ad3ee88ac778bd5df4`.}

## Codex review: not critical The change adds an explicit confirmation reason to posted draft comments while preserving commit checks. It does not alter merge gates, authentication, permissions, or existing data irreversibly. No findings. The merge waits for the status `ai-review/codex`: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here. Model `gpt-6-astra`, effort high, tokens in 232146 (cached 193920) / out 1415, 46.2 s, 9 commands; reviewed head `02b8505916532b5245b733ad3ee88ac778bd5df4`.

ai-reviewer merged commit 2bb445fd25 into main

2026-10-23 13:31:57 +02:00

ai-reviewer deleted branch claude-code/attach-checked

2026-10-23 13:31:57 +02:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mi/werkrevisor#136