1.7 KiB
PR#104: The Codex Review Holds the Merge on werkrevisor
WARNING: This document describes only the change applied in this PR. It may already be outdated once the next PR is merged. Historic PR documentation is not maintained along with new PRs; treat it as a snapshot.
Related Links
Problem
werkrevisor is the merge gate of all werk repositories and reviews its own PRs.
A change that weakens the gate is then reviewed by the weakened gate.
The Codex review is independent of werkrevisor;
in advise it found real defects that werkrevisor missed, e.g. in PR#90 and PR#91.
The user chose werkrevisor as the first repository with gate.
Non-Goals
- No
gatein other repositories; werkator stays onadvise. - No change of the runner.
Solution
.werkrevisor.toml:[codex] mode = "gate".- Werkbaum:
#model.codex.gated,gatein werkrevisor. - Version 0.41.3.
The runner reads the mode at the head of main, so this PR itself is not held by ai-review/codex.
Steps of the human after the merge, in this order:
- Wait until the runner has set
ai-review/codexon the open PRs, at most 5 minutes. - Add
ai-review/codexto the required status checks ofmain, e.g. withtools/branch-protection https://git.javagil.de/mi/werkrevisor main --contexts ai-review/codex --approvers ai-reviewer,mi, first with--dry-run: the tool keeps the required contexts, but also sets its other fields.
With the workstation off, a werkrevisor PR waits with the status pending.
Open Questions
None.