werkrevisor 0.20.3: the statistics service is called statistics, not server #34
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: mi/werkrevisor#34
Reference in New Issue
Block a user
See the PR doc.
🤖 Generated with Claude Code
🟡 werkrevisor YELLOW for
8c244e0, superseded by the result for537b48a🟡 werkrevisor: YELLOW / HUMAN_REVIEW
Change kind:
mixed.11 files changed only mechanically and were not reviewed by the model: statistics/gradle/wrapper/gradle-wrapper.jar (renamed), statistics/gradle/wrapper/gradle-wrapper.properties (renamed), statistics/gradlew (renamed) and 8 more.
Reasons
Findings
[medium] Scenario#34.01 not verifiable from the diff at
docs/prs/2026-10-06-PR#34-statistics-instead-of-server.md:24-35, hint, as a line comment[low] Scenario#34.02 has no automated verification at
docs/prs/2026-10-06-PR#34-statistics-instead-of-server.md:37-47, hint, as a line commentClassifier
5 of 6 units passed all questions (1 PR document(s)).
Usage: model `openrouter/anthropic/claude-sonnet-5.5`, LLM done, tokens counted before the call 45803, calls 1, tokens in 46053 / out 548 (reasoning included in out), duration 21.8 s, cost 0.0976 USD (reported), classifier `jev-1.13.0` calls 6, tokens in 4674, cost 0.0002 USD, finding judge `jev-1.13.0` calls 1, tokens in 1538, cost 0.0001 USD, config: defaults + host + repository (.werkrevisor.toml at base1 answer ignored because of a confidence below [classifier] min_confidence.
760f9a5).Reviewed head `8c244e0f600ae2937f5380399907499ae778c0fd` against base `760f9a5c639a24c46061977badc072faa92fb077`, werkrevisor 0.20.2.
werkrevisor: YELLOW / HUMAN_REVIEW for
8c244e0f600ae2937f5380399907499ae778c0fd.The result comment of werkrevisor holds the details.
@@ -0,0 +21,4 @@### Feature: the statistics service is named after its purpose#### Scenario#34.01: the build of the statistics service names it[medium] Scenario#34.01 not verifiable from the diff (werkrevisor)
hint; Jev: real 0.65, severity 1.5 of 3
Scenario#34.01 specifies the status context
werkator/werkrevisor-statisticsand the build directory. Both belong to the Werkator machine config on mih09, which is not part of this PR. The "Verified by" entry says "checked by the build of this PR", but a PR build cannot check its own status name if the host config is changed outside the repository. The scenario also names implementation details (status context, directory), as the classifier hint notes.Fixed in
537b48a: the scenario about the status context is gone, since the machine config on mih09 is outside this repository; the Solution names that change. The build of this PR reportedwerkator/werkrevisor-statistics=success, which shows the config works.@@ -0,0 +34,4 @@- Werkator machine config of mih09, checked by the build of this PR.#### Scenario#34.02: the service reads its settings from `WERKREVISOR_STATISTICS_*`[low] Scenario#34.02 has no automated verification (werkrevisor)
hint
The renamed
WERKREVISOR_STATISTICS_*variables are only verified by a manual deployment check. The integration test sets the properties directly (werkrevisor.statistics.*) and never resolves the environment variable placeholders inapplication.properties. A typo in a placeholder would pass the tests and silently fall back to the default values or empty tokens.Fixed in
537b48a:SettingsIntegrationTestsets theWERKREVISOR_STATISTICS_*names and checks that port, address and tokens arrive; it failed with a typo in the placeholder of the read tokens. The database placeholder is not asserted:UsageApiIntegrationTestsetswerkrevisor.statistics.databaseas JVM system property, which overrides the placeholder in the same test JVM.Answer to the review of
8c244e0(YELLOW):.werkrevisor.toml, the Gradle files): renamed only, plus the version bump; needs the human review.implementation_detailsand the two hints on the scenarios: fixed in537b48a, threads resolved.README.md:843(137 characters): wrapped in537b48a.🟡 werkrevisor: YELLOW / HUMAN_REVIEW
Change kind:
mixed.11 files changed only mechanically and were not reviewed by the model: statistics/gradle/wrapper/gradle-wrapper.jar (renamed), statistics/gradle/wrapper/gradle-wrapper.properties (renamed), statistics/gradlew (renamed) and 8 more.
Reasons
Classifier
5 of 5 units passed all questions (1 PR document(s)).
Usage: model `openrouter/anthropic/claude-sonnet-5.5`, LLM done, tokens counted before the call 46739, calls 1, tokens in 47156 / out 96 (reasoning included in out), duration 9.6 s, cost 0.0953 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3767, cost 0.0002 USD, config: defaults + host + repository (.werkrevisor.toml at base760f9a5).Reviewed head `537b48abb21e9e971c2fb8db33306b17f90b7c82` against base `760f9a5c639a24c46061977badc072faa92fb077`, werkrevisor 0.20.2.