werkrevisor 0.43.0: a moved file with only package and import changes is mechanical #112
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: mi/werkrevisor#112
Reference in New Issue
Block a user
See the PR document under docs/prs/.
🤖 Generated with Claude Code
🟢 werkrevisor GREEN for
f6573c2, superseded by the result forc6d0737🟢 werkrevisor: GREEN / PASS
Gate: approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit.
Change kind:
mixed.Reasons
Findings
docs/prs/2026-10-15-PR#112-mechanical-moves.md:36-38, severity unknown, counted as medium, hint, as a line commentClassifier
9 of 9 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 24297, calls 1, tokens in 23432 / out 24281 (reasoning included in out), duration 233.7 s, cost 0.0361 USD (reported), classifier `jev-1.13.0` calls 9, tokens in 7225, cost 0.0003 USD, finding judge `jev-1.13.0` calls 1, tokens in 1629, cost 0.0001 USD, change summary `openrouter/minimax/minimax-m3` via Minimax calls 1, tokens in 2196 / out 1019, cost 0.0019 USD (reported), PR document check `jev-1.13.0` calls 9, tokens in 11572, cost 0.0005 USD, build file judge `jev-1.13.0` calls 5, tokens in 3828, cost 0.0002 USD, phases: path_judge 0.4 s, classifier 0.6 s, change_summary 9.7 s, doc_check 0.6 s, context 0.2 s, model_review 221.4 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main5 answers ignored because of a confidence below [classifier] min_confidence.
0ece9bf).Reviewed head `f6573c20a678ddd4806fb787e41418b3b2e143fb` against base `0ece9bf09bcc205405495844359a845e54163da2`, werkrevisor 0.42.4.
werkrevisor: GREEN / PASS for
f6573c20a678ddd4806fb787e41418b3b2e143fb.The result comment of werkrevisor holds the details.
@@ -0,0 +33,4 @@… so that a package move across many files needs no human for its size.- **Given** a renamed Kotlin file whose diff changes only its `package` and `import` linesDoc Scenario Mismatch, severity unknown, counted as medium (werkrevisor)
hint; Jev: real 0.84, severity 1.7 of 3
Scenario#112.01 says "a renamed Kotlin file" but both tests linked under "Verified by" (test_rename_with_only_package_and_import_changes and test_moved_files_do_not_count_for_the_size_limits) use .java paths and the implementation works for any language whose import regex matches. A reader could wrongly infer the rule is Kotlin-only, while in practice the documented verification is for Java. The wording should drop "Kotlin" (e.g. "a renamed source file") or mention "Java/Kotlin" and the tests should match.
Fixed in
c6d0737: Scenario#112.01 now says "a renamed Java or Kotlin file", matching the tests and the built-in package and import regexes.Codex review of
f6573c20a678ddd4806fb787e41418b3b2e143fb@@ -125,2 +126,3 @@return RENAMEDif f.status not in _MODIFIED or file_diff is None or file_diff.binary or f.changed_lines == 0:# A package move renames each file and changes only its package and import lines.if not (renamed or f.status in _MODIFIED) or file_diff is None or file_diff.binary or f.changed_lines == 0:[high] Preserve whitespace protection from the old filename (Codex review)
Renamed files now reach whitespace classification, but whitespace_significant checks only f.path. Renaming src/main/worker.py to src/main/worker while dedenting process() out of an if block therefore produces 'renamed, whitespace', despite changing behavior in a Python script that retains its shebang. Both paths remain in the main category, so the new category guard permits this. Reproduced: the base rejects mechanical classification; the head returns mechanical_only with zero counted lines, bypassing review. Check whitespace protection against both filenames.
Fix it, or reply why it does not hold, and resolve this comment.
Fixed in
c6d0737: a renamed file with changed lines must keep its file extension, andwhitespace_significantis checked against the old and the new name. Red/green:test_rename_keeps_the_rules_of_the_old_name(src/worker.py→src/workerwith a dedent, andA.py→A.java) fails without the fix and passes with it.⚠️ werkrevisor ERROR for
?, superseded by the result forc6d0737Codex review: critical
This change relaxes the merge gate by exempting additional renamed files from model review, Jev review, and size limits. Incorrect classification can let behavioral changes merge without review.
Findings
werkrevisor/mechanical.py:128, as a line commentThe merge waits for the status
Model `gpt-6-astra`, effort high, tokens in 323164 (cached 267776) / out 2204, 79.4 s, 14 commands; reviewed head `f6573c20a678ddd4806fb787e41418b3b2e143fb`.ai-review/codex: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here.New commits pushed, approval review dismissed automatically according to repository settings
🟢 werkrevisor: GREEN / PASS
Change kind:
mixed.Reasons
f6573c2not carried over: 3 approved block(s) are missingClassifier
9 of 9 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 24985, calls 1, tokens in 24101 / out 14049 (reasoning included in out), duration 133.5 s, cost 0.0241 USD (reported), classifier `jev-1.13.0` calls 9, tokens in 7281, cost 0.0003 USD, change summary `openrouter/minimax/minimax-m3` via Minimax calls 1, tokens in 2513 / out 957, cost 0.0019 USD (reported), PR document check `jev-1.13.0` calls 9, tokens in 11349, cost 0.0005 USD, build file judge `jev-1.13.0` calls 5, tokens in 4136, cost 0.0002 USD, phases: path_judge 0.4 s, classifier 0.6 s, change_summary 9.7 s, doc_check 0.6 s, context 0.4 s, model_review 121.3 s, config: defaults + host + repository (.werkrevisor.toml at main4 answers ignored because of a confidence below [classifier] min_confidence.
0ece9bf).Reviewed head `c6d0737e3fe1e0133f5b8ad5ddbe928c1d2b921a` against base `0ece9bf09bcc205405495844359a845e54163da2`, werkrevisor 0.42.4.
werkrevisor: GREEN / PASS for
c6d0737e3fe1e0133f5b8ad5ddbe928c1d2b921a.The result comment of werkrevisor holds the details.
Codex review: critical
The change relaxes the merge gate by allowing more renamed files to bypass model and Jev review and size limits. Incorrect classification could therefore let consequential changes merge without review, so human review is required.
No findings.
The merge waits for the status
Model `gpt-6-astra`, effort high, tokens in 266942 (cached 211712) / out 1123, 51.8 s, 11 commands; reviewed head `c6d0737e3fe1e0133f5b8ad5ddbe928c1d2b921a`.ai-review/codex: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here.