Parallel work shares its minutes in the Werkjournal proposal #53
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: mi/werkregie#53
Reference in New Issue
Block a user
Each minute of a day counts once; entries active at the same time share it.
🤖 Generated with Claude Code
🟠 werkrevisor ORANGE for
f73ce94, superseded by the result for53c3c20🟠 werkrevisor: ORANGE / FINDINGS
Change kind:
mixed.Reasons
Findings
Per-entry rounding breaks the "adds up to the clock" invariant at
dashboard/src/main/kotlin/de/hoennig/werkregie/dashboard/journal/JournalProposal.kt:124-134, severity unknown, counted as medium, ORANGE, as a line commentUnrelated planning additions at
doc/werkregie.werkbaum:166-177, severity unknown, counted as medium, hint, as a line commentClassifier
6 of 6 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 23487, calls 1, tokens in 22587 / out 28145 (reasoning included in out), duration 187.0 s, cost 0.0405 USD (reported), classifier `jev-1.13.0` calls 6, tokens in 4274, cost 0.0002 USD, finding judge `jev-1.13.0` calls 2, tokens in 5636, cost 0.0002 USD, build file judge `jev-1.13.0` calls 4, tokens in 4243, cost 0.0002 USD, phases: path_judge 0.4 s, classifier 0.4 s, context 3.9 s, model_review 181.7 s, finding_judge 0.2 s, config: defaults + host + repository (.werkrevisor.toml at main1 answer ignored because of a confidence below [classifier] min_confidence.
333c45e).Reviewed head `f73ce94126379e24fe17556af7bdccbd47753d46` against base `333c45ece75b21d648af85160e283d1b3550846f`, werkrevisor 0.39.0.
werkrevisor: ORANGE / FINDINGS for
f73ce94126379e24fe17556af7bdccbd47753d46.The result comment of werkrevisor holds the details.
@@ -121,3 +123,2 @@private fun entry(day: LocalDate, group: Group): ProposedEntry {val minutes = Spans.merge(group.spans).sumOf { Duration.between(it.from, it.to).toMinutes() }/** The minutes of each entry, its spans given: each stretch of time is divided equally among the entries active in it. */Per-entry rounding breaks the "adds up to the clock" invariant, severity unknown, counted as medium (werkrevisor)
ORANGE; Jev: real 0.82, severity 3.0 of 3
sharedMinutesconverts each entry's accumulated seconds independently viaMath.round(it / 60), so the sum of the proposed minutes can differ from the union of the spans (the clock time) by roughly half a minute per entry. The PR document and the Werkbaum both state the goal as "the entries of a day add up to the time of the clock", yet the manual verification itself records 652 min in entries against 643 min of clock time on 2026-10-12, a 9-minute gap that contradicts the stated invariant. Either the rounding should be done once over the union (e.g. accumulate the seconds before dividing) or the PR document and Werkbaum note should be adjusted to acknowledge the rounding. The new test only asserts the specific 90/30 split and does not check the sum-equals-union property.Fixed in
53c3c20: the minutes are rounded by the largest remainders, so the entries add up to the rounded union; a new test checks three entries of 10 shared minutes, which gave 3+3+3 before and give 3+3+4 now.The 9 min gap in the PR document was a wrong reference: the 643 min counted the Claude transcripts of think only. The union of all spans of the recorded day, actions included, is 652 min; the PR document says so now.
Unrelated planning additions, severity unknown, counted as medium (werkrevisor)
hint; Jev: real 0.77, severity 0.9 of 3
The Werkbaum file gains two new
[?]items that have nothing to do with the journal feature: "[?] Push notification when a pull request needs the user" under#dash.pwaand "[?] #dash.notify: Matrix as a notification channel, for colleagues too" as a top-level node. The file's own header states "Each PR updates this file with the status its merge brings", and the PR title, description and PR document all focus on the journal proposal. These two unrelated ideas should either be moved into their own PR or, at minimum, be called out in the PR description.No change: this PR adds only one line to doc/werkregie.werkbaum, the note of PR#53 under #dash.journal.proposal (see
git diff origin/main...HEAD -- doc/werkregie.werkbaum).The two ideas "Push notification when a pull request needs the user" and "#dash.notify" stand on main already; they appear in the context of the diff only.
🟢 werkrevisor: GREEN / PASS
Change kind:
mixed.Reasons
Classifier
6 of 6 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 24115, calls 1, tokens in 23195 / out 16425 (reasoning included in out), duration 77.6 s, cost 0.0266 USD (reported), classifier `jev-1.13.0` calls 6, tokens in 4299, cost 0.0002 USD, build file judge `jev-1.13.0` calls 4, tokens in 4498, cost 0.0002 USD, phases: path_judge 0.2 s, classifier 0.5 s, context 0.2 s, model_review 76.2 s, config: defaults + host + repository (.werkrevisor.toml at main1 answer ignored because of a confidence below [classifier] min_confidence.
333c45e).Reviewed head `53c3c20b0d1bf68ce34931580299fb9209c965e4` against base `333c45ece75b21d648af85160e283d1b3550846f`, werkrevisor 0.39.0.
werkrevisor: GREEN / PASS for
53c3c20b0d1bf68ce34931580299fb9209c965e4.The result comment of werkrevisor holds the details.