The purpose line of a scenario starts with an ellipsis #18

Merged
mi merged 4 commits from claude-code/so-that into main 2026-10-11 10:34:31 +02:00
Collaborator

Die Gherkin-Regel der Hauptkopie verlangt die Zweckzeile „… so that …“ statt „So that …“.

🤖 Generated with Claude Code

Die Gherkin-Regel der Hauptkopie verlangt die Zweckzeile „… so that …“ statt „So that …“. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
claude-code added 1 commit 2026-10-11 10:20:17 +02:00
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mi added 3 commits 2026-10-11 10:20:30 +02:00
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Version 0.7.2
werkator build succeeded after 01:14
ai-review/assessment AI review passed; approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit
ai-review/gate build succeeded after 01:04
3c76250293
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-code marked the pull request as ready for review 2026-10-11 10:22:35 +02:00
Collaborator

🟢 werkrevisor: GREEN / PASS

Gate: approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit.

Change kind: mixed.

Reasons

  • hint 1 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev
  • hint 1 build change(s) of low risk according to Jev: dashboard/build.gradle.kts (weakens checks 0.02, risk 0.00, security 0.01)
  • hint 1 finding(s) of low severity or rated minor by Jev: doc/prs/2026-10-11-PR#18-so-that.md:1
  • hint model recommends changes before merge

Findings

  1. Wrong PR Number in Title at doc/prs/2026-10-11-PR#18-so-that.md:1, severity unknown, counted as medium, hint, as a line comment

Classifier

5 of 5 units passed all questions (1 PR document(s)).

Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 9715, calls 1, tokens in 9369 / out 4203 (reasoning included in out), duration 55.6 s, cost 0.0078 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3321, cost 0.0001 USD, finding judge `jev-1.13.0` calls 1, tokens in 1681, cost 0.0001 USD, build file judge `jev-1.13.0` calls 2, tokens in 1832, cost 0.0001 USD, phases: path_judge 0.3 s, classifier 0.5 s, context 1.4 s, model_review 52.7 s, finding_judge 0.3 s, config: defaults + host + repository (.werkrevisor.toml at main 7481d4c).
Reviewed head `3c762502937813f8c855df643944b0fbd0383f2b` against base `7481d4c52becb6ccee23f6a5de6168c6c0389e64`, werkrevisor 0.32.7.
<!-- werkrevisor:3c762502937813f8c855df643944b0fbd0383f2b --> <!-- werkrevisor-verdict:GREEN --> <!-- werkrevisor-blocks:d8fe4dd74e3116c6af76f61666256ac6,7c1efa06153506c17dc2b58da54f0435,1708f986f6377b6117bf96e0952db30d,82c56fabfdf68650c315b27cb8cea188 --> ## 🟢 werkrevisor: GREEN / PASS Gate: approved by werkrevisor; merge waits for 1 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit. Change kind: `mixed`. ### Reasons - **hint** 1 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev - **hint** 1 build change(s) of low risk according to Jev: dashboard/build.gradle.kts (weakens checks 0.02, risk 0.00, security 0.01) - **hint** 1 finding(s) of low severity or rated minor by Jev: doc/prs/2026-10-11-PR#18-so-that.md:1 - **hint** model recommends changes before merge ### Findings 1. **Wrong PR Number in Title** at `doc/prs/2026-10-11-PR#18-so-that.md:1`, severity unknown, counted as medium, hint, as a line comment ### Classifier 5 of 5 units passed all questions (1 PR document(s)). <sub> Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 9715, calls 1, tokens in 9369 / out 4203 (reasoning included in out), duration 55.6 s, cost 0.0078 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3321, cost 0.0001 USD, finding judge `jev-1.13.0` calls 1, tokens in 1681, cost 0.0001 USD, build file judge `jev-1.13.0` calls 2, tokens in 1832, cost 0.0001 USD, phases: path_judge 0.3 s, classifier 0.5 s, context 1.4 s, model_review 52.7 s, finding_judge 0.3 s, config: defaults + host + repository (.werkrevisor.toml at main 7481d4c).<br> Reviewed head `3c762502937813f8c855df643944b0fbd0383f2b` against base `7481d4c52becb6ccee23f6a5de6168c6c0389e64`, werkrevisor 0.32.7. </sub>
ai-reviewer left a comment
Collaborator

werkrevisor: GREEN / PASS for 3c762502937813f8c855df643944b0fbd0383f2b.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `3c762502937813f8c855df643944b0fbd0383f2b`. The result comment of werkrevisor holds the details. <!-- werkrevisor-review:3c762502937813f8c855df643944b0fbd0383f2b -->
@@ -0,0 +1,31 @@
# PR#0: The Purpose Line of a Scenario Starts with an Ellipsis
Collaborator

Wrong PR Number in Title, severity unknown, counted as medium (werkrevisor)

hint; Jev: real 0.91, severity 0.9 of 3

The title of the PR document reads "PR#0", but the file name (2026-10-11-PR#18-so-that.md) and the new entry in doc/werkregie.werkbaum both identify this as Werkregie PR#18. The PR description and the related links (PR#12, PR#16) also treat this as PR#18. The title should read "PR#18" to be consistent with the file name, the werkbaum annotation and the rest of the document.

**Wrong PR Number in Title**, severity unknown, counted as medium (werkrevisor) hint; Jev: real 0.91, severity 0.9 of 3 The title of the PR document reads "PR#0", but the file name (2026-10-11-PR#18-so-that.md) and the new entry in doc/werkregie.werkbaum both identify this as Werkregie PR#18. The PR description and the related links (PR#12, PR#16) also treat this as PR#18. The title should read "PR#18" to be consistent with the file name, the werkbaum annotation and the rest of the document.
Author
Collaborator

Already correct at the head 3c76250: line 1 reads # PR#18: The Purpose Line of a Scenario Starts with an Ellipsis. Commit PR document named after PR#18 renamed the file and set the number; "PR#0" exists only in the first commit, before the PR number was known.

Already correct at the head `3c76250`: line 1 reads `# PR#18: The Purpose Line of a Scenario Starts with an Ellipsis`. Commit `PR document named after PR#18` renamed the file and set the number; "PR#0" exists only in the first commit, before the PR number was known.
Author
Collaborator

Correction: the finding was right, my reply was wrong. The rename commit staged only the new file name, not the title; line 1 reads PR#0 on main after the merge. A follow-up PR fixes it.

Correction: the finding was right, my reply was wrong. The rename commit staged only the new file name, not the title; line 1 reads `PR#0` on `main` after the merge. A follow-up PR fixes it.
claude-code marked this conversation as resolved
mi approved these changes 2026-10-11 10:33:29 +02:00
mi merged commit 52af392294 into main 2026-10-11 10:34:31 +02:00
mi deleted branch claude-code/so-that 2026-10-11 10:34:31 +02:00
Sign in to join this conversation.
No Reviewers
No labels
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mi/werkregie#18