One Matrix client per machine #11
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: mi/werkregie#11
Reference in New Issue
Block a user
Fix of PR#8: only one process of a machine runs the Matrix client, the one holding
sync.lock; another one readsmessages.jsonalong and takes over when the first ends.matrix loginrefuses while another process syncs.PR document:
doc/prs/2026-10-10-PR#11-matrix-one-client.md. 68 tests green, no compiler warnings. Version 0.4.3.🤖 Generated with Claude Code
🟠 werkrevisor ORANGE for
a416479, superseded by the result forf8895e2🟠 werkrevisor: ORANGE / FINDINGS
Change kind:
mixed.Reasons
Findings
Lock leak on error path at
dashboard/src/main/kotlin/de/hoennig/werkregie/dashboard/sources/MatrixSource.kt:170-190, severity unknown, counted as medium, ORANGE, as a line commentUnclear Given/When/Then at
doc/prs/2026-10-10-PR#11-matrix-one-client.md:38-44, severity unknown, counted as medium, hint, as a line commentClassifier
6 of 8 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 17975, calls 1, tokens in 17412 / out 14727 (reasoning included in out), duration 67.6 s, cost 0.0229 USD (reported), classifier `jev-1.13.0` calls 8, tokens in 5955, cost 0.0003 USD, finding judge `jev-1.13.0` calls 2, tokens in 3372, cost 0.0001 USD, build file judge `jev-1.13.0` calls 4, tokens in 4046, cost 0.0002 USD, phases: path_judge 0.3 s, classifier 0.5 s, context 0.2 s, model_review 65.5 s, finding_judge 0.2 s, config: defaults + host.2 answers ignored because of a confidence below [classifier] min_confidence.
Reviewed head `a4164793637b9fbed846bdae69e5aa954c13228f` against base `c2ec294e26491048e4e9bea389bcf1fd3c3f3de0`, werkrevisor 0.32.2.
werkrevisor: ORANGE / FINDINGS for
a4164793637b9fbed846bdae69e5aa954c13228f.The result comment of werkrevisor holds the details.
@@ -166,5 +166,5 @@} finally {client.closeSuspending()}}Lock leak on error path, severity unknown, counted as medium (werkrevisor)
ORANGE; Jev: real 0.88, severity 2.6 of 3
In
login(), thetry { ... } finally { ... }only wraps the access toclient.userId.full to client.deviceId. IfbaseUrl(...),classicLoginWithPassword(...).getOrThrow(), oropenClient(...).getOrThrow()throws after the lock is acquired, the lock is never released, andsync.lockstays held by the still-open file channel until the process exits. The current CLI usage masks this because the process exits after login (and the OS reclaims the lock), but the bug will manifest iflogin()is ever called from a longer-lived process or retried in the same process. The fix is to move thelock.release()into a try-finally that also wraps theopenClientcall.Fixed in
f8895e2: the channel of the lock is closed on every path after it was taken (lock.channel().use { … }). Red/green: the test "a failed login frees the lock" failed without the fix and passes with it.@@ -0,0 +35,4 @@- [MatrixSourceTest "a second process reads the messages along, without a client of its own"](../../dashboard/src/test/kotlin/de/hoennig/werkregie/dashboard/sources/MatrixSourceTest.kt)#### Scenario#11.02: the second process takes overUnclear Given/When/Then, severity unknown, counted as medium (werkrevisor)
hint; Jev: real 0.75, severity 1.2 of 3
In Scenario#11.02, the Given clause "a process reads along" is a consequence of the lock being held by another process rather than the precondition itself, and the When "the syncing process ends" does not mention the lock becoming available. Compared to 11.01 and 11.03 (which use "Given one process of the machine syncs Matrix"), this scenario leaves the reader guessing why a reading process would suddenly start a client. A clearer Given would name the lock state (e.g. "Given one process of the machine holds
sync.lockand another reads along frommessages.json") and the When would name the trigger (e.g. "When the syncing process ends and the lock is released").Fixed in
f8895e2: Scenario#11.02 now names the relay and the local mode, "Given the relay syncs, and the local mode shows its messages", "When the relay stops"; Scenario#11.01 no longer namesmessages.json.⚠️ werkrevisor ERROR for
a416479, superseded by the result forf8895e2⚠️ werkrevisor: ERROR / review not completed, human action needed
Change kind:
mixed.Reasons
Findings
Lock leak on error path at
dashboard/src/main/kotlin/de/hoennig/werkregie/dashboard/sources/MatrixSource.kt:170-190, severity unknown, counted as medium, ORANGE, as a line commentUnclear Given/When/Then at
doc/prs/2026-10-10-PR#11-matrix-one-client.md:38-44, severity unknown, counted as medium, hint, as a line commentClassifier
6 of 8 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 17975, calls 1, tokens in 17412 / out 14727 (reasoning included in out), duration 67.6 s, cost 0.0229 USD (reported), classifier `jev-1.13.0` calls 8, tokens in 5955, cost 0.0003 USD, finding judge `jev-1.13.0` calls 2, tokens in 3372, cost 0.0001 USD, build file judge `jev-1.13.0` calls 4, tokens in 4046, cost 0.0002 USD, phases: path_judge 0.3 s, classifier 0.5 s, context 0.2 s, model_review 65.5 s, finding_judge 0.2 s, config: defaults + host.2 answers ignored because of a confidence below [classifier] min_confidence.
Reviewed head `a4164793637b9fbed846bdae69e5aa954c13228f` against base `c2ec294e26491048e4e9bea389bcf1fd3c3f3de0`, werkrevisor 0.32.2.
🟡 werkrevisor YELLOW for
f8895e2, superseded by the result for960a446🟡 werkrevisor: YELLOW / HUMAN_REVIEW
Change kind:
mixed.Reasons
Findings
doc/prs/2026-10-10-PR#11-matrix-one-client.md:72, severity unknown, counted as medium, hint, as a line commentClassifier
7 of 8 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 18795, calls 1, tokens in 18210 / out 23975 (reasoning included in out), duration 112.3 s, cost 0.0342 USD (reported), classifier `jev-1.13.0` calls 8, tokens in 6021, cost 0.0003 USD, finding judge `jev-1.13.0` calls 1, tokens in 1072, cost 0.0000 USD, build file judge `jev-1.13.0` calls 4, tokens in 4563, cost 0.0002 USD, phases: path_judge 0.3 s, classifier 0.7 s, context 0.2 s, model_review 110.5 s, finding_judge 0.2 s, config: defaults + host.1 answer ignored because of a confidence below [classifier] min_confidence.
Reviewed head `f8895e2a4de2aa8a06b2c71967efa81630627af0` against base `c2ec294e26491048e4e9bea389bcf1fd3c3f3de0`, werkrevisor 0.32.2.
werkrevisor: YELLOW / HUMAN_REVIEW for
f8895e2a4de2aa8a06b2c71967efa81630627af0.The result comment of werkrevisor holds the details.
@@ -0,0 +69,4 @@On each fetch it tries the lock again and starts its own client once it gets it.- `matrix login` takes the lock first and refuses while another process holds it.- The directory `<stateDir>/matrix/` gets mode 0700 also when the lock creates it first.- `matrix login` frees the lock on every path, also when the login fails (finding of werkrevisor).Meta-reference in Solution section, severity unknown, counted as medium (werkrevisor)
hint; Jev: real 0.61, severity 0.9 of 3
The Solution bullet "matrix login frees the lock on every path, also when the login fails (finding of werkrevisor)." ends with a parenthetical "(finding of werkrevisor)" that points to the review process instead of describing the change itself; a PR document records what the change does, not how it was reviewed.
Fixed in
960a446: the parenthetical is gone; Scenario#11.02 now has one condition and one result.🟢 werkrevisor GREEN for
960a446, superseded by the result for6cc5199🟢 werkrevisor: GREEN / PASS
Gate: approved by werkrevisor; merge waits for 2 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit.
Change kind:
mixed.Reasons
Findings
Werkbaum indentation at
doc/werkregie.werkbaum:33, severity unknown, counted as medium, hint, as a line commentMarkdown tag rendered away at
doc/prs/2026-10-10-PR#11-matrix-one-client.md:66-71, severity unknown, counted as medium, hint, as a line commentClassifier
8 of 8 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 18842, calls 1, tokens in 18251 / out 8318 (reasoning included in out), duration 198.3 s, cost 0.0111 USD (reported), classifier `jev-1.13.0` calls 8, tokens in 6003, cost 0.0003 USD, finding judge `jev-1.13.0` calls 2, tokens in 2974, cost 0.0001 USD, build file judge `jev-1.13.0` calls 4, tokens in 4563, cost 0.0002 USD, phases: path_judge 0.2 s, classifier 0.5 s, context 0.3 s, model_review 196.7 s, finding_judge 0.3 s, config: defaults + host.3 answers ignored because of a confidence below [classifier] min_confidence.
Reviewed head `960a4464f23c23b9d9f6ebabf3c60b287b49f031` against base `c2ec294e26491048e4e9bea389bcf1fd3c3f3de0`, werkrevisor 0.32.2.
werkrevisor: GREEN / PASS for
960a4464f23c23b9d9f6ebabf3c60b287b49f031.The result comment of werkrevisor holds the details.
@@ -0,0 +63,4 @@## Solution- The process that holds the file lock `<stateDir>/matrix/sync.lock` runs the client.Markdown tag rendered away, severity unknown, counted as medium (werkrevisor)
hint; Jev: real 0.91, severity 1.1 of 3
The document uses
<stateDir>in two places (lines 66 and 71). Markdown treats an unescaped<...>as an HTML tag and strips it, so the rendered path becomes just/matrix/sync.lockand/matrix/instead of<stateDir>/matrix/sync.lockand<stateDir>/matrix/. In line 71 the closing>also appears after/matrix/rather than afterstateDir, so the markup is malformed and the directory name is unclear. Use backticks or escape the angle brackets so the placeholder is preserved.No change: both
<stateDir>stand inside backticks, i.e. in code spans, where Markdown renders<and>literally; Gitea shows<stateDir>/matrix/sync.lockin full.@@ -30,6 +30,7 @@" Werkregie PR#5: it does; the spike is in dashboard/spikes/matrix-sdk.- [^] Login as a device of its own, in the relay (S) :#dash.matrix.sdk" Werkregie PR#8: werkregie-dashboard matrix login; the session lives in an H2 file." Werkregie PR#11: one client per machine; a second process reads along.Werkbaum indentation, severity unknown, counted as medium (werkrevisor)
hint; Jev: real 0.79, severity 1.4 of 3
The new description
" Werkregie PR#11: one client per machine; a second process reads along.is added one column to the left of its parent bullet- [^] Login as a device of its own, in the relay (S). The previous description on the same bullet is indented two columns further (under the bullet). With the new line at the parent level it reads as a description of#dash.matrixrather than of the Login item it actually explains, and the Werkbaum viewer will likely misassociate it.Aligned in
6cc5199. The association was right before: a"line belongs to the preceding node whatever its indentation (Werkbaum SPEC, descriptions); the parser attaches both lines to "Login as a device of its own".New commits pushed, approval review dismissed automatically according to repository settings
🟠 werkrevisor ORANGE for
6cc5199, superseded by the result for5ecf800🟠 werkrevisor: ORANGE / FINDINGS
Change kind:
mixed.Reasons
960a446not carried over: 1 approved block(s) are missingFindings
dashboard/src/main/kotlin/de/hoennig/werkregie/dashboard/sources/MatrixSource.kt:80-87, severity unknown, counted as medium, ORANGE, as a line commentClassifier
8 of 8 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 18841, calls 1, tokens in 18250 / out 19671 (reasoning included in out), duration 118.7 s, cost 0.0290 USD (reported), classifier `jev-1.13.0` calls 8, tokens in 6003, cost 0.0003 USD, finding judge `jev-1.13.0` calls 1, tokens in 1612, cost 0.0001 USD, build file judge `jev-1.13.0` calls 4, tokens in 4563, cost 0.0002 USD, phases: path_judge 0.3 s, classifier 0.6 s, context 0.2 s, model_review 116.9 s, finding_judge 0.2 s, config: defaults + host.3 answers ignored because of a confidence below [classifier] min_confidence.
Reviewed head `6cc5199ba96a0dd34f00b7eba0ed3ec58cf6ba39` against base `c2ec294e26491048e4e9bea389bcf1fd3c3f3de0`, werkrevisor 0.32.2.
werkrevisor: ORANGE / FINDINGS for
6cc5199ba96a0dd34f00b7eba0ed3ec58cf6ba39.The result comment of werkrevisor holds the details.
@@ -66,1 +77,4 @@/** Whether this process runs the client, rather than reading along. */internal val syncing: Boolean get() = lock != nulloverride fun fetch(now: Instant, since: Instant): List<Item> {Possible Race Condition, severity unknown, counted as medium (werkrevisor)
ORANGE; Jev: real 0.86, severity 2.9 of 3
In
fetch(), the assignmentif (lock == null) lock = tryLock(dir)is a non-atomic read-modify-write on a@Volatilefield. If two threads callfetch()concurrently, both can readlock == nulland both invoketryLock(). Only one acquires the OS-level lock; the other receivesnulland then writesnullback tolock, overwriting the successful acquisition. After the race, the field reportslock == nulleven though the first thread still holds the OS lock, sosyncingreturnsfalseand the source falls back toreadSaved()for the rest of the run, while sync is actually happening in the background andmessages.jsonis being updated. The user-facingnote()likewise misreports "liest mit". The existingsynchronized(items)blocks and the new@Volatileonlocksuggest concurrentfetch()is a realistic scenario; the assignment should be wrapped insynchronizedor useAtomicReference.compareAndSet.Fixed in
5ecf800: the check and the assignment run insynchronized(this), so a taken lock is never overwritten with null. In the dashboard only one refresh per source runs at a time (Dashboard.refreshIfDue), so the race needed a caller outside it.🟢 werkrevisor GREEN for
5ecf800, superseded by the result forc8d10a7🟢 werkrevisor: GREEN / PASS
Change kind:
mixed.Reasons
Classifier
8 of 8 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 18894, calls 1, tokens in 18301 / out 4495 (reasoning included in out), duration 27.1 s, cost 0.0109 USD (reported), classifier `jev-1.13.0` calls 8, tokens in 6003, cost 0.0003 USD, build file judge `jev-1.13.0` calls 4, tokens in 4586, cost 0.0002 USD, phases: path_judge 0.2 s, classifier 0.5 s, context 0.3 s, model_review 25.8 s, config: defaults + host.3 answers ignored because of a confidence below [classifier] min_confidence.
Reviewed head `5ecf8006220d3016c73f26f8b1e7d9aab7eff210` against base `c2ec294e26491048e4e9bea389bcf1fd3c3f3de0`, werkrevisor 0.32.2.
werkrevisor: GREEN / PASS for
5ecf8006220d3016c73f26f8b1e7d9aab7eff210.The result comment of werkrevisor holds the details.
5ecf800622toc8d10a76e8New commits pushed, approval review dismissed automatically according to repository settings
🟢 werkrevisor: GREEN / PASS
Change kind:
mixed.Reasons
5ecf800not carried over: 2 approved block(s) are missingClassifier
8 of 8 units passed all questions (1 PR document(s)).
Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 18929, calls 1, tokens in 18333 / out 13292 (reasoning included in out), duration 73.7 s, cost 0.0214 USD (reported), classifier `jev-1.13.0` calls 8, tokens in 6003, cost 0.0003 USD, build file judge `jev-1.13.0` calls 4, tokens in 5908, cost 0.0002 USD, phases: path_judge 0.3 s, classifier 0.5 s, context 0.7 s, model_review 71.9 s, config: defaults + host + repository (.werkrevisor.toml at main3 answers ignored because of a confidence below [classifier] min_confidence.
09e0252).Reviewed head `c8d10a76e8d5ac63c731200d28fc9e6d55884a0e` against base `09e0252854adeda5d331455489f32ff84ee37ce7`, werkrevisor 0.32.2.
werkrevisor: GREEN / PASS for
c8d10a76e8d5ac63c731200d28fc9e6d55884a0e.The result comment of werkrevisor holds the details.