1.1 KiB
1.1 KiB
PR#145: The PR-Doc of PR#141 Says How Long a Slot Test Waits
WARNING: This document describes only the change applied in this PR. It may already be outdated once the next PR is merged. Historic PR-documentation is not maintained along with new PRs — treat it as a snapshot, not as current documentation.
The Problem
The PR-doc of PR#141 says that a slot test waits until a build queues at a semaphore or got through, "and fails at once then".
The helper isWaitingAt polls with eventually(5.seconds): when neither happens, the test fails after five seconds, not at once.
werkrevisor named the sentence in its review of PR#141, but since werkrevisor 0.31.0 a hint on documentation is no line comment,
so the PR merged with it.
Non-Goals
- No change to the tests or to
BuildSlots. - PR-docs stay snapshots; this PR corrects a statement about PR#141 itself, not a later change.
The Solution
- The PR-doc of PR#141 says that the test fails after five seconds when the build neither queues nor gets through.
- Version 1.38.12; the open PRs #137, #142 and #144 hold 1.38.9 to 1.38.11.