the sandbox config section is werkdock, not bwrap #19
@@ -1,6 +1,6 @@
|
|||||||
---
|
---
|
||||||
name: architecture
|
name: architecture
|
||||||
description: Detailed Werkator subsystem architecture — CLI wiring and exit codes, server mode, web UI, configuration system, git access, build execution (native, Docker, and bwrap), watcher poll cycle, and system metrics. Use when designing or modifying code in the commands, config, git, gitea, build, artifacts, watcher, metrics, or server packages, or when a question goes beyond the overview in AGENTS.md.
|
description: Detailed Werkator subsystem architecture — CLI wiring and exit codes, server mode, web UI, configuration system, git access, build execution (native, Docker, and the werkdock sandbox), watcher poll cycle, and system metrics. Use when designing or modifying code in the commands, config, git, gitea, build, artifacts, watcher, metrics, or server packages, or when a question goes beyond the overview in AGENTS.md.
|
||||||
---
|
---
|
||||||
|
|
||||||
# Werkator Architecture
|
# Werkator Architecture
|
||||||
@@ -49,7 +49,7 @@ Werkator is configured by three YAML files, deep-merged by `ConfigLoader` (later
|
|||||||
|
|
||||||
Every lookup falls back to the pre-rename name (`ConfigFiles`): `.gittally.yml`, and `.git/gittally/.gittally.yml` for the machine layer. Current name first, and where both exist the old one is ignored rather than merged — a missing config is not an error, so an un-renamed installation would otherwise start on defaults without a single failure.
|
Every lookup falls back to the pre-rename name (`ConfigFiles`): `.gittally.yml`, and `.git/gittally/.gittally.yml` for the machine layer. Current name first, and where both exist the old one is ignored rather than merged — a missing config is not an error, so an un-renamed installation would otherwise start on defaults without a single failure.
|
||||||
|
|
||||||
On top of those comes the **branch layer**: the `.werkator.yml` committed on a branch, applied by `loadWithBranchLayer` (the watcher passes the content read via `git show`, `loadForWorktree` the file in the build worktree). A branch describes its own CI and wins over both layers — the whole `builds` section — so a configuration can be tried out on a branch without touching other branches' builds. `stripPinned` removes what is not a description of this branch's build: `git`, `server`, `gitea`, `executor`, `watcher`, and — inside every `builds` definition as well as every legacy `branches` entry — `requirePullRequest`, `statusContext`, `docker.enabled`/`docker.network`, and `bwrap.enabled`/`bwrap.rootfs`/`bwrap.werkdock`.
|
On top of those comes the **branch layer**: the `.werkator.yml` committed on a branch, applied by `loadWithBranchLayer` (the watcher passes the content read via `git show`, `loadForWorktree` the file in the build worktree). A branch describes its own CI and wins over both layers — the whole `builds` section — so a configuration can be tried out on a branch without touching other branches' builds. `stripPinned` removes what is not a description of this branch's build: `git`, `server`, `gitea`, `executor`, `watcher`, and — inside every `builds` definition as well as every legacy `branches` entry — `requirePullRequest`, `statusContext`, `docker.enabled`/`docker.network`, and `werkdock.enabled`/`werkdock.rootfs`/`werkdock.binary` (the section was called `bwrap` until v1.2.0; `renameLegacySandbox` maps the old name onto the new one on every raw layer, before merging).
|
||||||
|
|
||||||
Each file is version-checked before merging (`werkator.version.since`/`below`, `ConfigVersions.verdict`), so the message can name the file to fix: `since` is hard in both directions — too old a Werkator, or a file written before `ConfigVersions.FORMAT_BROKE_IN` and read after it — while `below` only warns. There is no format version (`apiVersion`) on purpose: only one configuration generation is supported, and the declared version exists to make the incompatibility nameable.
|
Each file is version-checked before merging (`werkator.version.since`/`below`, `ConfigVersions.verdict`), so the message can name the file to fix: `since` is hard in both directions — too old a Werkator, or a file written before `ConfigVersions.FORMAT_BROKE_IN` and read after it — while `below` only warns. There is no format version (`apiVersion`) on purpose: only one configuration generation is supported, and the declared version exists to make the incompatibility nameable.
|
||||||
|
|
||||||
@@ -71,9 +71,9 @@ Everything repository-scoped goes through a `RepoContext` (`repo` package, ADR 0
|
|||||||
|
|
||||||
On context close (e.g. systemd SIGTERM), a `ContextClosedEvent` listener in `BuildExecutor` terminates the process trees of all executing builds and waits (bounded) until their results are persisted as INTERRUPTED — a shutdown is never recorded as FAILED. Builds still queued stay PENDING and start no process. Both are re-enqueued by the watcher's startup recovery; INTERRUPTED therefore publishes as Gitea state `pending`, not `failure` (`GiteaStateMapping`).
|
On context close (e.g. systemd SIGTERM), a `ContextClosedEvent` listener in `BuildExecutor` terminates the process trees of all executing builds and waits (bounded) until their results are persisted as INTERRUPTED — a shutdown is never recorded as FAILED. Builds still queued stay PENDING and start no process. Both are re-enqueued by the watcher's startup recovery; INTERRUPTED therefore publishes as Gitea state `pending`, not `failure` (`GiteaStateMapping`).
|
||||||
|
|
||||||
The runtime is selected per build behind the `BuildRunner` interface: `DispatchingBuildRunner` (`@Primary`) routes to native `ProcessBuildRunner` (the default), to `DockerBuildRunner` when `docker.enabled`, or to `BwrapBuildRunner` when `bwrap.enabled` — docker and bwrap are mutually exclusive per build and rejected in `buildSettings`, never picked silently. The Docker runner shells out to the `docker` CLI (no SDK): it (re)builds the configured image when the Dockerfile inputs changed (tracked via the `org.werkator.build-inputs-sha256` image label), maintains a per-repo Gradle cache volume, mounts the worktree and the Docker socket into a labelled (`org.hoennig.werkator`) `--rm --init` container, and repairs workspace ownership in-container after each command (under a rootless daemon the container runs as root, which is the host user, and the repair degenerates to `0:0`). Git works inside the container: the primary `.git` is mounted read-only with `.git/werkator/` masked by an empty tmpfs (credential isolation) and the worktree's admin dir mounted read-write (`gitMetadataMounts`). The returned `Process` is the attached `docker run` client, so log streaming and termination work exactly like native builds.
|
The runtime is selected per build behind the `BuildRunner` interface: `DispatchingBuildRunner` (`@Primary`) routes to native `ProcessBuildRunner` (the default), to `DockerBuildRunner` when `docker.enabled`, or to `WerkdockBuildRunner` when `werkdock.enabled` — docker and werkdock are mutually exclusive per build and rejected in `buildSettings`, never picked silently. The Docker runner shells out to the `docker` CLI (no SDK): it (re)builds the configured image when the Dockerfile inputs changed (tracked via the `org.werkator.build-inputs-sha256` image label), maintains a per-repo Gradle cache volume, mounts the worktree and the Docker socket into a labelled (`org.hoennig.werkator`) `--rm --init` container, and repairs workspace ownership in-container after each command (under a rootless daemon the container runs as root, which is the host user, and the repair degenerates to `0:0`). Git works inside the container: the primary `.git` is mounted read-only with `.git/werkator/` masked by an empty tmpfs (credential isolation) and the worktree's admin dir mounted read-write (`gitMetadataMounts`). The returned `Process` is the attached `docker run` client, so log streaming and termination work exactly like native builds.
|
||||||
|
|
||||||
`BwrapBuildRunner` (ADR 0008) is the third runtime, for hosts without root and without Docker — Hostsharing Managed Webspaces. It shells out to the `bwrap` CLI (no library): a prepared rootfs archive (`bwrap.rootfs`, built by `tools/build-bwrap-rootfs.sh`) is unpacked on demand into `.git/werkator/buildenv/<envKey>/rootfs` and bound read-only at `/`, with uid 0 inside mapped to the calling user; isolation is filesystem-only — network, uid, `/proc`, `/dev` are the host's by contract. It reuses the Docker runner's `gitMetadataMounts`; mount order matters (repo dir read-write before the metadata mounts and the workspace), and bind mountpoints missing from the rootfs are pre-created there, since the rootfs is a plain host directory while bwrap cannot mkdir against the read-only sandbox root. `bwrap.enabled`/`bwrap.rootfs` are pinned like the docker sandbox policy. The returned `Process` is the attached `bwrap` process, so streaming and cancellation are unchanged. The generic sandbox machinery is the standalone tool [Werkdock](https://git.javagil.de/mi/werkdock) (plan step 21: grown in `werkdock/`, consumed via the CLI since session C, its own repository since session E); the runner delegates to the `werkdock` CLI and this repository no longer carries its source.
|
`WerkdockBuildRunner` (ADR 0008) is the third runtime, for hosts without root and without Docker — Hostsharing Managed Webspaces. It shells out to the `bwrap` CLI (no library): a prepared rootfs archive (`werkdock.rootfs`, built by `tools/build-bwrap-rootfs.sh`) is unpacked on demand into `.git/werkator/buildenv/<envKey>/rootfs` and bound read-only at `/`, with uid 0 inside mapped to the calling user; isolation is filesystem-only — network, uid, `/proc`, `/dev` are the host's by contract. It reuses the Docker runner's `gitMetadataMounts`; mount order matters (repo dir read-write before the metadata mounts and the workspace), and bind mountpoints missing from the rootfs are pre-created there, since the rootfs is a plain host directory while bwrap cannot mkdir against the read-only sandbox root. `werkdock.enabled`/`werkdock.rootfs` are pinned like the docker sandbox policy. The returned `Process` is the attached `bwrap` process, so streaming and cancellation are unchanged. The generic sandbox machinery is the standalone tool [Werkdock](https://git.javagil.de/mi/werkdock) (plan step 21: grown in `werkdock/`, consumed via the CLI since session C, its own repository since session E); the runner delegates to the `werkdock` CLI and this repository no longer carries its source.
|
||||||
|
|
||||||
## Watcher
|
## Watcher
|
||||||
|
|
||||||
|
|||||||
@@ -40,9 +40,9 @@ All production code lives under `de.hoennig.werkator`, with sub-packages `comman
|
|||||||
- Everything repository-scoped (results, artifacts, worktrees, git and config access) goes through a `RepoContext`, never through an implicit current directory: the executor serializes per (context, branch) under one global `maxConcurrent`, the watcher polls every context in its own guard. `RepoRegistry` opens one context per entry of the instance configuration `~/.werkator.yml` (ADR 0009), or the current directory without one; the instance-level keys (`server`, `executor`, `watcher.pollInterval`) and the `defaults` block are folded into every repository's effective config by `ConfigLoader` itself, so no consumer reads the home file directly. Server routes carry the repository as `/repos/<name>/…` and `/api/repos/<name>/…`, with the unscoped form permanently meaning the served repository; the pages stay per repository and a drop-down in the page title switches between them.
|
- Everything repository-scoped (results, artifacts, worktrees, git and config access) goes through a `RepoContext`, never through an implicit current directory: the executor serializes per (context, branch) under one global `maxConcurrent`, the watcher polls every context in its own guard. `RepoRegistry` opens one context per entry of the instance configuration `~/.werkator.yml` (ADR 0009), or the current directory without one; the instance-level keys (`server`, `executor`, `watcher.pollInterval`) and the `defaults` block are folded into every repository's effective config by `ConfigLoader` itself, so no consumer reads the home file directly. Server routes carry the repository as `/repos/<name>/…` and `/api/repos/<name>/…`, with the unscoped form permanently meaning the served repository; the pages stay per repository and a drop-down in the page title switches between them.
|
||||||
- When config keys change, three places must stay in sync: the `WerkatorConfig` data classes, the `InitCommand` templates, and `docs/configuration.md`.
|
- When config keys change, three places must stay in sync: the `WerkatorConfig` data classes, the `InitCommand` templates, and `docs/configuration.md`.
|
||||||
- Every config file may declare `werkator.version.since`/`below` (the Werkator it is written for, never a format version — no API is involved). `since` is enforced in both directions, using `ConfigVersions.FORMAT_BROKE_IN` for "file predates a breaking change"; `below` only warns. A violation aborts the start for the machine and project config, but fails only that branch's builds for a branch config.
|
- Every config file may declare `werkator.version.since`/`below` (the Werkator it is written for, never a format version — no API is involved). `since` is enforced in both directions, using `ConfigVersions.FORMAT_BROKE_IN` for "file predates a breaking change"; `below` only warns. A violation aborts the start for the machine and project config, but fails only that branch's builds for a branch config.
|
||||||
- A branch describes its own CI: its committed `.werkator.yml` is the branch layer (`ConfigLoader.loadWithBranchLayer`, used by the watcher per origin branch and by `loadForWorktree` at build time) and takes precedence over `.git`/project — including the whole `builds` section, so a new configuration can be tried out on a branch without affecting other branches. Only the pinned set is stripped from that layer: secrets (`git`), host/repository sections (`server`, `gitea`, `executor`, `watcher`), the docker (`docker.enabled`, `docker.network`) and bubblewrap (`bwrap.enabled`, `bwrap.rootfs`, `bwrap.werkdock`) sandbox policies, and the trust gate (`requirePullRequest`). A branch must never reach credentials, disable its container or sandbox, change its network, substitute a foreign rootfs, raise global concurrency, or bypass its own pull-request gate; a branch's definitions apply to that branch alone.
|
- A branch describes its own CI: its committed `.werkator.yml` is the branch layer (`ConfigLoader.loadWithBranchLayer`, used by the watcher per origin branch and by `loadForWorktree` at build time) and takes precedence over `.git`/project — including the whole `builds` section, so a new configuration can be tried out on a branch without affecting other branches. Only the pinned set is stripped from that layer: secrets (`git`), host/repository sections (`server`, `gitea`, `executor`, `watcher`), the docker (`docker.enabled`, `docker.network`) and werkdock (`werkdock.enabled`, `werkdock.rootfs`, `werkdock.binary`) sandbox policies, and the trust gate (`requirePullRequest`). A branch must never reach credentials, disable its container or sandbox, change its network, substitute a foreign rootfs, raise global concurrency, or bypass its own pull-request gate; a branch's definitions apply to that branch alone.
|
||||||
- A build definition carries the complete description of its build, split in two: the `trigger` block (`onPush`, `atTimes`, `branches`, `activeWithin`) says when and for which branches it runs, everything else what it does. `builds.default` is the base every other definition inherits its settings — never its `trigger` — from. The split is structural so that a selector added to `TriggerConfig` later is non-inheritable by construction; writing a trigger key flat is refused, never ignored, because ignoring it leaves a build that silently stops running. A `!` prefix in `trigger.branches` excludes and always wins.
|
- A build definition carries the complete description of its build, split in two: the `trigger` block (`onPush`, `atTimes`, `branches`, `activeWithin`) says when and for which branches it runs, everything else what it does. `builds.default` is the base every other definition inherits its settings — never its `trigger` — from. The split is structural so that a selector added to `TriggerConfig` later is non-inheritable by construction; writing a trigger key flat is refused, never ignored, because ignoring it leaves a build that silently stops running. A `!` prefix in `trigger.branches` excludes and always wins.
|
||||||
- The inheritance is applied after all layers are merged: that order is what makes a build a branch invents inherit the host's sandbox policy instead of the data-class default, so the pinning also holds for a build the host has never heard of. Pinned are `requirePullRequest`, `statusContext`, `docker.enabled`, `docker.network`, `bwrap.enabled`, `bwrap.rootfs`, and `bwrap.werkdock`. Docker and bwrap are mutually exclusive per branch — enabling both is rejected at start.
|
- The inheritance is applied after all layers are merged: that order is what makes a build a branch invents inherit the host's sandbox policy instead of the data-class default, so the pinning also holds for a build the host has never heard of. Pinned are `requirePullRequest`, `statusContext`, `docker.enabled`, `docker.network`, `werkdock.enabled`, `werkdock.rootfs`, and `werkdock.binary`. Docker and werkdock are mutually exclusive per branch — enabling both is rejected at start. The section was called `bwrap` until v1.2.0 and is still read under that name, with a warning; the hard refusal waits for the release that sets `ConfigVersions.FORMAT_BROKE_IN`.
|
||||||
- `builds` or the legacy `branches`, never both: `branches` is read only while the merged config defines no build at all (`builds.maxConcurrent` is not one), and ignored with a warning as soon as one exists. The section is deprecated and goes away once the repositories have migrated; then `ConfigVersions.FORMAT_BROKE_IN` gets set and a leftover `branches:` key must be rejected by name — the version check alone cannot catch a file that declares no version.
|
- `builds` or the legacy `branches`, never both: `branches` is read only while the merged config defines no build at all (`builds.maxConcurrent` is not one), and ignored with a warning as soon as one exists. The section is deprecated and goes away once the repositories have migrated; then `ConfigVersions.FORMAT_BROKE_IN` gets set and a leftover `branches:` key must be rejected by name — the version check alone cannot catch a file that declares no version.
|
||||||
- Web UI: server-rendered Thymeleaf plus one hand-written `static/werkator.js` — no SPA framework, no frontend build pipeline; every fetch has a timeout and an explicit error badge; `UiFormats` and `werkator.js` must produce identical display formats.
|
- Web UI: server-rendered Thymeleaf plus one hand-written `static/werkator.js` — no SPA framework, no frontend build pipeline; every fetch has a timeout and an explicit error badge; `UiFormats` and `werkator.js` must produce identical display formats.
|
||||||
- Git and Docker access shells out to the CLIs (`GitCommandRunner`, `docker`) — no JGit, no Docker SDK.
|
- Git and Docker access shells out to the CLIs (`GitCommandRunner`, `docker`) — no JGit, no Docker SDK.
|
||||||
|
|||||||
+1
-1
@@ -13,7 +13,7 @@ group = "de.hoennig"
|
|||||||
// so the UI footer (BuildProperties), --version and the release notes identify what is
|
// so the UI footer (BuildProperties), --version and the release notes identify what is
|
||||||
// actually running; a deployment bundles whatever was committed since the last one.
|
// actually running; a deployment bundles whatever was committed since the last one.
|
||||||
// ReleaseVersionConsistencyTest fails the build if this and the top releases.html entry disagree.
|
// ReleaseVersionConsistencyTest fails the build if this and the top releases.html entry disagree.
|
||||||
version = "1.1.2"
|
version = "1.2.0"
|
||||||
|
|
||||||
java {
|
java {
|
||||||
toolchain {
|
toolchain {
|
||||||
|
|||||||
+11
-10
@@ -71,7 +71,7 @@ above, giving the precedence **branch > repo install > project**. It takes prece
|
|||||||
everything that describes how this branch is built: the whole `builds` section — its own
|
everything that describes how this branch is built: the whole `builds` section — its own
|
||||||
definitions and its overrides of the definitions from the project config, with
|
definitions and its overrides of the definitions from the project config, with
|
||||||
`buildCommand`, `cleanCommand`, `artifactDirs`, log file names, and
|
`buildCommand`, `cleanCommand`, `artifactDirs`, log file names, and
|
||||||
`docker.image`/`dockerfile`/`context`/`env` and `bwrap.env` inside them. That is how a new configuration is tried out: change it on a branch, and
|
`docker.image`/`dockerfile`/`context`/`env` and `werkdock.env` inside them. That is how a new configuration is tried out: change it on a branch, and
|
||||||
no other branch's builds are affected.
|
no other branch's builds are affected.
|
||||||
|
|
||||||
The branch layer is used in both places where it matters: the watcher reads the committed
|
The branch layer is used in both places where it matters: the watcher reads the committed
|
||||||
@@ -99,7 +99,7 @@ single branch may decide it:
|
|||||||
- the repository-side settings: the whole `gitea`, `executor`, and `watcher` sections;
|
- the repository-side settings: the whole `gitea`, `executor`, and `watcher` sections;
|
||||||
- the trust gate: `requirePullRequest`, and the Gitea status context: `statusContext`;
|
- the trust gate: `requirePullRequest`, and the Gitea status context: `statusContext`;
|
||||||
- the container sandbox policy: `docker.enabled`/`docker.network` and
|
- the container sandbox policy: `docker.enabled`/`docker.network` and
|
||||||
`bwrap.enabled`/`bwrap.rootfs`/`bwrap.werkdock` — host-pinned as
|
`werkdock.enabled`/`werkdock.rootfs`/`werkdock.binary` — host-pinned as
|
||||||
long as only the host's configuration sets them, master-pinned once the committed
|
long as only the host's configuration sets them, master-pinned once the committed
|
||||||
configuration does.
|
configuration does.
|
||||||
|
|
||||||
@@ -406,9 +406,9 @@ That is how a branch gets a build of its own without being built by the default
|
|||||||
`activeWithin` (e.g. `24h`) additionally keeps only branches whose origin head commit is younger than the duration — useful to run a nightly deep check over all recently active branches.
|
`activeWithin` (e.g. `24h`) additionally keeps only branches whose origin head commit is younger than the duration — useful to run a nightly deep check over all recently active branches.
|
||||||
Both parts combine as an intersection.
|
Both parts combine as an intersection.
|
||||||
|
|
||||||
Settings: `buildCommand`, `cleanCommand`, `artifactDirs`, `stdoutLog`/`stderrLog`, `requirePullRequest`, `statusContext`, and `docker` and `bwrap` with all their keys.
|
Settings: `buildCommand`, `cleanCommand`, `artifactDirs`, `stdoutLog`/`stderrLog`, `requirePullRequest`, `statusContext`, and `docker` and `werkdock` with all their keys.
|
||||||
A definition carries the complete description of its build; unset keys fall back to `builds.default` and then to Werkator's own defaults.
|
A definition carries the complete description of its build; unset keys fall back to `builds.default` and then to Werkator's own defaults.
|
||||||
`requirePullRequest`, `statusContext`, `docker.enabled`, `docker.network`, `bwrap.enabled`, `bwrap.rootfs`, and `bwrap.werkdock` are pinned (master-pinned, see [the branch layer](#the-branch-layer-a-branch-describes-its-own-ci)): they are read from the repo install/project config even when a branch sets them in its own committed config.
|
`requirePullRequest`, `statusContext`, `docker.enabled`, `docker.network`, `werkdock.enabled`, `werkdock.rootfs`, and `werkdock.binary` are pinned (master-pinned, see [the branch layer](#the-branch-layer-a-branch-describes-its-own-ci)): they are read from the repo install/project config even when a branch sets them in its own committed config.
|
||||||
Inheritance from `builds.default` covers the settings only — the `trigger` block says when and where *this* build runs and is never inherited.
|
Inheritance from `builds.default` covers the settings only — the `trigger` block says when and where *this* build runs and is never inherited.
|
||||||
Definitions are part of the branch layer: a branch may add its own and override those from the project config, for its own builds only.
|
Definitions are part of the branch layer: a branch may add its own and override those from the project config, for its own builds only.
|
||||||
Because the inheritance is applied after all layers are merged, a build a branch invents still inherits the host's `builds.default` — its sandbox policy included, which is what keeps the pinning effective for a build the host has never heard of.
|
Because the inheritance is applied after all layers are merged, a build a branch invents still inherits the host's `builds.default` — its sandbox policy included, which is what keeps the pinning effective for a build the host has never heard of.
|
||||||
@@ -464,22 +464,23 @@ Note that the rest of `.git` — including `.git/config` — is visible to build
|
|||||||
The Docker socket is mounted into the container and `DOCKER_HOST`/`TESTCONTAINERS_*` variables are set, so Testcontainers-based builds work inside the container.
|
The Docker socket is mounted into the container and `DOCKER_HOST`/`TESTCONTAINERS_*` variables are set, so Testcontainers-based builds work inside the container.
|
||||||
All Werkator containers carry `org.hoennig.werkator` labels; stale build containers of the repository are removed before the first Docker build after a restart.
|
All Werkator containers carry `org.hoennig.werkator` labels; stale build containers of the repository are removed before the first Docker build after a restart.
|
||||||
|
|
||||||
### Notes on `builds.<name>.bwrap`
|
### Notes on `builds.<name>.werkdock`
|
||||||
|
|
||||||
With `bwrap.enabled`, Werkator runs the build in a bubblewrap sandbox instead of native execution.
|
With `werkdock.enabled`, Werkator runs the build in a bubblewrap sandbox instead of native execution.
|
||||||
This is the third runtime, for hosts without root and without a Docker daemon (e.g. Hostsharing managed webspaces); see `docs/plan/17-bwrap-build-runtime.md` and ADR 0008.
|
This is the third runtime, for hosts without root and without a Docker daemon (e.g. Hostsharing managed webspaces); see `docs/plan/17-bwrap-build-runtime.md` and ADR 0008.
|
||||||
Since step 21 session C the sandbox is executed by the `werkdock` CLI (`bwrap.werkdock`, default: resolved via `PATH`) — Werkator no longer invokes `bwrap` itself; `bwrap` must be installed for werkdock.
|
Since step 21 session C the sandbox is executed by the `werkdock` CLI (`werkdock.binary`, default: resolved via `PATH`) — Werkator no longer invokes `bwrap` itself; `bwrap` must be installed for werkdock.
|
||||||
|
The section was called `bwrap` and its binary key `bwrap.werkdock` until v1.2.0; both are still read, with a warning naming the file, so an installation can be migrated at its next configuration edit rather than at the next update.
|
||||||
`werkdock doctor` checks the host's capability (it replaced the retired `tools/werkator-build-prerequisites.sh` in step 23).
|
`werkdock doctor` checks the host's capability (it replaced the retired `tools/werkator-build-prerequisites.sh` in step 23).
|
||||||
|
|
||||||
`bwrap.rootfs` names the prepared root filesystem archive — a Debian-base rootfs with the build tools (JDK, git, locales, project-specific tooling) built elsewhere, since `debootstrap` is unavailable on the target.
|
`werkdock.rootfs` names the prepared root filesystem archive — a Debian-base rootfs with the build tools (JDK, git, locales, project-specific tooling) built elsewhere, since `debootstrap` is unavailable on the target.
|
||||||
It is a local path or an `http(s)` URL; a URL is downloaded once into `.git/werkator/buildenv/`.
|
It is a local path or an `http(s)` URL; a URL is downloaded once into `.git/werkator/buildenv/`.
|
||||||
Build the archive with `tools/build-bwrap-rootfs.sh` on any machine with Docker.
|
Build the archive with `tools/build-bwrap-rootfs.sh` on any machine with Docker.
|
||||||
The archive is loaded once per source as the werkdock image `werkator-buildenv-<hash>` into werkdock's store (`$WERKDOCK_HOME`, default `~/.werkdock`) — shared by every repository of this OS user; the hash derives from the source string, so a changed `rootfs` loads a fresh image and stale ones can be removed from the store.
|
The archive is loaded once per source as the werkdock image `werkator-buildenv-<hash>` into werkdock's store (`$WERKDOCK_HOME`, default `~/.werkdock`) — shared by every repository of this OS user; the hash derives from the source string, so a changed `rootfs` loads a fresh image and stale ones can be removed from the store.
|
||||||
Per-repo Gradle caches persist in `.git/werkator/buildenv/home`, bound as `/root`.
|
Per-repo Gradle caches persist in `.git/werkator/buildenv/home`, bound as `/root`.
|
||||||
`bwrap.env` adds environment variables inside the sandbox; the environment is otherwise cleared (docker semantics) — the server's environment does not leak in.
|
`werkdock.env` adds environment variables inside the sandbox; the environment is otherwise cleared (docker semantics) — the server's environment does not leak in.
|
||||||
Files created inside the sandbox are owned by the host user, because uid 0 maps back to the unprivileged webspace user.
|
Files created inside the sandbox are owned by the host user, because uid 0 maps back to the unprivileged webspace user.
|
||||||
|
|
||||||
`docker` and `bwrap` are mutually exclusive per branch: enabling both is rejected at start, not silently picked.
|
`docker` and `werkdock` are mutually exclusive per branch: enabling both is rejected at start, not silently picked.
|
||||||
Git works inside the sandbox exactly as inside the Docker container: the primary `.git` is mounted read-only with `.git/werkator/` masked, so builds can run read-only git commands but never reach the machine config or the control token.
|
Git works inside the sandbox exactly as inside the Docker container: the primary `.git` is mounted read-only with `.git/werkator/` masked, so builds can run read-only git commands but never reach the machine config or the control token.
|
||||||
|
|
||||||
## `.git/werkator/.werkator.yml` (not committed)
|
## `.git/werkator/.werkator.yml` (not committed)
|
||||||
|
|||||||
+2
-2
@@ -185,7 +185,7 @@ The tarball unpacks to a `werkator/` directory, so it must not be extracted over
|
|||||||
Rollback is the reverse: stop, remove the new directory (or jar), move `.bak` back, start.
|
Rollback is the reverse: stop, remove the new directory (or jar), move `.bak` back, start.
|
||||||
|
|
||||||
`tools/remote --env-file .env.<instance> werkator instance-update` does the same sequence for any host, not only the webspace layout it was written for.
|
`tools/remote --env-file .env.<instance> werkator instance-update` does the same sequence for any host, not only the webspace layout it was written for.
|
||||||
Three optional keys in the env file name what differs (see the script's header): `WERKATOR_REPO_DIR` (directory of the watched repository, which also names the systemd unit), `WERKATOR_INSTALL_DIR` (where the runtime bundle is unpacked), and `WERKATOR_SANDBOX` (`bwrap`, the default, or `docker` — a Docker host has no werkdock binary and no rootfs archive to upload).
|
Three optional keys in the env file name what differs (see the script's header): `WERKATOR_REPO_DIR` (directory of the watched repository, which also names the systemd unit), `WERKATOR_INSTALL_DIR` (where the runtime bundle is unpacked), and `WERKATOR_SANDBOX` (`werkdock`, the default, or `docker` — a Docker host has no werkdock binary and no rootfs archive to upload).
|
||||||
Their defaults are the layout `instance-install` creates, so an env file that names none of them behaves exactly as before.
|
Their defaults are the layout `instance-install` creates, so an env file that names none of them behaves exactly as before.
|
||||||
The upload happens before the service is stopped and every artifact is checksum-verified after the transfer, so a dropped connection costs the transfer and not the running service.
|
The upload happens before the service is stopped and every artifact is checksum-verified after the transfer, so a dropped connection costs the transfer and not the running service.
|
||||||
|
|
||||||
@@ -329,7 +329,7 @@ Werkator runs as a systemd *user* service on the assigned localhost port ("eigen
|
|||||||
Werkator is never built on the webspace: the runtime bundle and the werkdock binary are built locally and uploaded (ADR 0006).
|
Werkator is never built on the webspace: the runtime bundle and the werkdock binary are built locally and uploaded (ADR 0006).
|
||||||
All steps are driven by `tools/remote`; commands name their role — `instance-*` manages the installed Werkator, `repo-*` the repository it watches.
|
All steps are driven by `tools/remote`; commands name their role — `instance-*` manages the installed Werkator, `repo-*` the repository it watches.
|
||||||
Each instance is a pair of files (step 23): a transport env file selected with `--env-file` (default `.env`), and a YAML fragment in the configuration schema, named by its `WERKATOR_INIT_CONFIG` key and installed remotely via `werkator init --apply` — e.g. `.env.mih34` + `.env.mih34.yml`, both gitignored.
|
Each instance is a pair of files (step 23): a transport env file selected with `--env-file` (default `.env`), and a YAML fragment in the configuration schema, named by its `WERKATOR_INIT_CONFIG` key and installed remotely via `werkator init --apply` — e.g. `.env.mih34` + `.env.mih34.yml`, both gitignored.
|
||||||
The fragment carries the Werkator configuration (`server.port`, `publicBaseUrl`, systemd limits, `builds.default.bwrap.*`); the env file only says where and how to reach the host.
|
The fragment carries the Werkator configuration (`server.port`, `publicBaseUrl`, systemd limits, `builds.default.werkdock.*`); the env file only says where and how to reach the host.
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
tools/remote --env-file .env.mih34 werkator check-prerequisites # uploads werkdock, runs its doctor
|
tools/remote --env-file .env.mih34 werkator check-prerequisites # uploads werkdock, runs its doctor
|
||||||
|
|||||||
@@ -43,17 +43,17 @@ class ProcessBuildRunner : BuildRunner {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Selects the runtime per branch: Docker when `branches.<name>.docker.enabled`,
|
* Selects the runtime per branch: Docker when `builds.<name>.docker.enabled`, the
|
||||||
* bubblewrap when `branches.<name>.bwrap.enabled`, native shell execution otherwise
|
* werkdock sandbox when `builds.<name>.werkdock.enabled`, native shell execution
|
||||||
* (the unchanged default). Docker and bwrap are mutually exclusive per branch and are
|
* otherwise (the unchanged default). Docker and werkdock are mutually exclusive per
|
||||||
* rejected together at config load, so the branch order here never has to "pick".
|
* branch and are rejected together at config load, so the order here never has to "pick".
|
||||||
*/
|
*/
|
||||||
@Primary
|
@Primary
|
||||||
@Component
|
@Component
|
||||||
class DispatchingBuildRunner(
|
class DispatchingBuildRunner(
|
||||||
private val processBuildRunner: ProcessBuildRunner,
|
private val processBuildRunner: ProcessBuildRunner,
|
||||||
private val dockerBuildRunner: DockerBuildRunner,
|
private val dockerBuildRunner: DockerBuildRunner,
|
||||||
private val bwrapBuildRunner: BwrapBuildRunner,
|
private val werkdockBuildRunner: WerkdockBuildRunner,
|
||||||
) : BuildRunner {
|
) : BuildRunner {
|
||||||
override fun start(
|
override fun start(
|
||||||
command: String,
|
command: String,
|
||||||
@@ -66,7 +66,7 @@ class DispatchingBuildRunner(
|
|||||||
val runner =
|
val runner =
|
||||||
when {
|
when {
|
||||||
branchConfig.docker.enabled -> dockerBuildRunner
|
branchConfig.docker.enabled -> dockerBuildRunner
|
||||||
branchConfig.bwrap.enabled -> bwrapBuildRunner
|
branchConfig.werkdock.enabled -> werkdockBuildRunner
|
||||||
else -> processBuildRunner
|
else -> processBuildRunner
|
||||||
}
|
}
|
||||||
return runner.start(command, workingDir, environment, repoDir, branchConfig, onAuxProcess)
|
return runner.start(command, workingDir, environment, repoDir, branchConfig, onAuxProcess)
|
||||||
|
|||||||
+17
-17
@@ -1,7 +1,7 @@
|
|||||||
package de.hoennig.werkator.build
|
package de.hoennig.werkator.build
|
||||||
|
|
||||||
import de.hoennig.werkator.config.BranchConfig
|
import de.hoennig.werkator.config.BranchConfig
|
||||||
import de.hoennig.werkator.config.BwrapConfig
|
import de.hoennig.werkator.config.WerkdockConfig
|
||||||
import de.hoennig.werkator.git.GitCommandRunner
|
import de.hoennig.werkator.git.GitCommandRunner
|
||||||
import org.slf4j.LoggerFactory
|
import org.slf4j.LoggerFactory
|
||||||
import org.springframework.stereotype.Component
|
import org.springframework.stereotype.Component
|
||||||
@@ -13,7 +13,7 @@ import java.security.MessageDigest
|
|||||||
* Runs build commands inside a bubblewrap user-namespace sandbox (Step 17 / ADR 0008),
|
* Runs build commands inside a bubblewrap user-namespace sandbox (Step 17 / ADR 0008),
|
||||||
* for hosts without root and without a Docker daemon (e.g. Hostsharing managed
|
* for hosts without root and without a Docker daemon (e.g. Hostsharing managed
|
||||||
* webspaces). Since step 21 session C it no longer assembles the raw `bwrap` argv:
|
* webspaces). Since step 21 session C it no longer assembles the raw `bwrap` argv:
|
||||||
* it shells out to the `werkdock` CLI (`bwrap.werkdock`, default via PATH) — the same
|
* it shells out to the `werkdock` CLI (`werkdock.binary`, default via PATH) — the same
|
||||||
* pattern as git and docker, CLI, no library.
|
* pattern as git and docker, CLI, no library.
|
||||||
*
|
*
|
||||||
* The rootfs archive becomes a werkdock *image*, loaded once per source
|
* The rootfs archive becomes a werkdock *image*, loaded once per source
|
||||||
@@ -36,10 +36,10 @@ import java.security.MessageDigest
|
|||||||
* native builds.
|
* native builds.
|
||||||
*/
|
*/
|
||||||
@Component
|
@Component
|
||||||
class BwrapBuildRunner(
|
class WerkdockBuildRunner(
|
||||||
private val commandRunner: GitCommandRunner,
|
private val commandRunner: GitCommandRunner,
|
||||||
) : BuildRunner {
|
) : BuildRunner {
|
||||||
private val log = LoggerFactory.getLogger(BwrapBuildRunner::class.java)
|
private val log = LoggerFactory.getLogger(WerkdockBuildRunner::class.java)
|
||||||
|
|
||||||
/** Replaceable process launcher so unit tests can capture the assembled `werkdock` argv. */
|
/** Replaceable process launcher so unit tests can capture the assembled `werkdock` argv. */
|
||||||
internal var processStarter: (List<String>, Path) -> Process = { command, dir ->
|
internal var processStarter: (List<String>, Path) -> Process = { command, dir ->
|
||||||
@@ -54,14 +54,14 @@ class BwrapBuildRunner(
|
|||||||
branchConfig: BranchConfig,
|
branchConfig: BranchConfig,
|
||||||
onAuxProcess: (Process) -> Unit,
|
onAuxProcess: (Process) -> Unit,
|
||||||
): Process {
|
): Process {
|
||||||
val bwrap = branchConfig.bwrap
|
val sandbox = branchConfig.werkdock
|
||||||
require(bwrap.rootfs.isNotBlank()) { "branches.<name>.bwrap.rootfs must be set when bwrap.enabled is true" }
|
require(sandbox.rootfs.isNotBlank()) { "builds.<name>.werkdock.rootfs must be set when werkdock.enabled is true" }
|
||||||
val werkdock = bwrap.werkdock.ifBlank { "werkdock" }
|
val werkdock = sandbox.binary.ifBlank { "werkdock" }
|
||||||
val image = imageName(bwrap.rootfs)
|
val image = imageName(sandbox.rootfs)
|
||||||
ensureImage(werkdock, image, bwrap, repoDir, onAuxProcess)
|
ensureImage(werkdock, image, sandbox, repoDir, onAuxProcess)
|
||||||
val homeDir = repoDir.resolve(BUILDENV_DIR).resolve(HOME_DIR)
|
val homeDir = repoDir.resolve(BUILDENV_DIR).resolve(HOME_DIR)
|
||||||
Files.createDirectories(homeDir)
|
Files.createDirectories(homeDir)
|
||||||
val args = invocation(command, workingDir, environment, repoDir, bwrap, werkdock, image, homeDir)
|
val args = invocation(command, workingDir, environment, repoDir, sandbox, werkdock, image, homeDir)
|
||||||
return processStarter(args, repoDir)
|
return processStarter(args, repoDir)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -73,7 +73,7 @@ class BwrapBuildRunner(
|
|||||||
private fun ensureImage(
|
private fun ensureImage(
|
||||||
werkdock: String,
|
werkdock: String,
|
||||||
image: String,
|
image: String,
|
||||||
bwrap: BwrapConfig,
|
sandbox: WerkdockConfig,
|
||||||
repoDir: Path,
|
repoDir: Path,
|
||||||
onAuxProcess: (Process) -> Unit,
|
onAuxProcess: (Process) -> Unit,
|
||||||
) {
|
) {
|
||||||
@@ -81,10 +81,10 @@ class BwrapBuildRunner(
|
|||||||
if (image in loaded) {
|
if (image in loaded) {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
val envDir = repoDir.resolve(BUILDENV_DIR).resolve(sourceKey(bwrap.rootfs))
|
val envDir = repoDir.resolve(BUILDENV_DIR).resolve(sourceKey(sandbox.rootfs))
|
||||||
Files.createDirectories(envDir)
|
Files.createDirectories(envDir)
|
||||||
val archive = localArchive(bwrap.rootfs, envDir, repoDir, onAuxProcess)
|
val archive = localArchive(sandbox.rootfs, envDir, repoDir, onAuxProcess)
|
||||||
log.info("loading build environment {} as werkdock image {}", bwrap.rootfs, image)
|
log.info("loading build environment {} as werkdock image {}", sandbox.rootfs, image)
|
||||||
commandRunner.runOrThrow(
|
commandRunner.runOrThrow(
|
||||||
listOf(werkdock, "load", "-i", archive, "--name", image),
|
listOf(werkdock, "load", "-i", archive, "--name", image),
|
||||||
repoDir,
|
repoDir,
|
||||||
@@ -93,7 +93,7 @@ class BwrapBuildRunner(
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Resolves [BwrapConfig.rootfs] to a local archive path: a bare or `file:` path is
|
* Resolves [WerkdockConfig.rootfs] to a local archive path: a bare or `file:` path is
|
||||||
* used as-is; an `http(s)` URL is downloaded once into the buildenv cache.
|
* used as-is; an `http(s)` URL is downloaded once into the buildenv cache.
|
||||||
*/
|
*/
|
||||||
private fun localArchive(
|
private fun localArchive(
|
||||||
@@ -123,7 +123,7 @@ class BwrapBuildRunner(
|
|||||||
workspace: Path,
|
workspace: Path,
|
||||||
environment: Map<String, String>,
|
environment: Map<String, String>,
|
||||||
repoDir: Path,
|
repoDir: Path,
|
||||||
bwrap: BwrapConfig,
|
sandbox: WerkdockConfig,
|
||||||
werkdock: String,
|
werkdock: String,
|
||||||
image: String,
|
image: String,
|
||||||
homeDir: Path,
|
homeDir: Path,
|
||||||
@@ -148,7 +148,7 @@ class BwrapBuildRunner(
|
|||||||
for ((key, value) in environment) {
|
for ((key, value) in environment) {
|
||||||
args += listOf("-e", "$key=$value")
|
args += listOf("-e", "$key=$value")
|
||||||
}
|
}
|
||||||
for ((key, value) in bwrap.env) {
|
for ((key, value) in sandbox.env) {
|
||||||
args += listOf("-e", "$key=$value")
|
args += listOf("-e", "$key=$value")
|
||||||
}
|
}
|
||||||
args += listOf("-w", "$workspaceAbs")
|
args += listOf("-w", "$workspaceAbs")
|
||||||
@@ -242,12 +242,13 @@ class InitCommand(
|
|||||||
context: "." # Docker build context used with dockerfile
|
context: "." # Docker build context used with dockerfile
|
||||||
network: "" # Docker network mode for the build container; empty = Docker default (pinned)
|
network: "" # Docker network mode for the build container; empty = Docker default (pinned)
|
||||||
env: {} # additional environment variables set inside the build container
|
env: {} # additional environment variables set inside the build container
|
||||||
# bubblewrap user-namespace sandbox — for hosts without root and without a
|
# werkdock sandbox (bubblewrap user namespace) — for hosts without root and
|
||||||
# Docker daemon (e.g. Hostsharing managed webspaces). Mutually exclusive with docker.
|
# without a Docker daemon (e.g. Hostsharing managed webspaces). Mutually
|
||||||
bwrap:
|
# exclusive with docker. Called bwrap before v1.2.0, still read under that name.
|
||||||
enabled: false # run clean/build in a bwrap sandbox instead of natively (pinned)
|
werkdock:
|
||||||
|
enabled: false # run clean/build in the sandbox instead of natively (pinned)
|
||||||
rootfs: "" # prepared rootfs archive (path or URL); required when enabled (pinned)
|
rootfs: "" # prepared rootfs archive (path or URL); required when enabled (pinned)
|
||||||
werkdock: werkdock # the werkdock CLI executing the sandbox; default resolves via PATH (pinned)
|
binary: werkdock # the werkdock CLI executing the sandbox; default resolves via PATH (pinned)
|
||||||
env: {} # additional environment variables set inside the sandbox
|
env: {} # additional environment variables set inside the sandbox
|
||||||
# Gitea check this build reports as; empty uses gitea.statusContext.
|
# Gitea check this build reports as; empty uses gitea.statusContext.
|
||||||
# Two builds of one commit under the same context overwrite each other.
|
# Two builds of one commit under the same context overwrite each other.
|
||||||
|
|||||||
@@ -42,8 +42,8 @@ data class BuildDefinition(
|
|||||||
val statusContext: String? = null,
|
val statusContext: String? = null,
|
||||||
/** Overrides of the docker settings; null inherits them. */
|
/** Overrides of the docker settings; null inherits them. */
|
||||||
val docker: DockerOverrides? = null,
|
val docker: DockerOverrides? = null,
|
||||||
/** Overrides of the bwrap settings; null inherits them. */
|
/** Overrides of the werkdock settings; null inherits them. */
|
||||||
val bwrap: BwrapOverrides? = null,
|
val werkdock: WerkdockOverrides? = null,
|
||||||
) {
|
) {
|
||||||
/** The settings this build runs with: [branchConfig] with this definition applied; unset values fall through. */
|
/** The settings this build runs with: [branchConfig] with this definition applied; unset values fall through. */
|
||||||
fun applyTo(branchConfig: BranchConfig): BranchConfig =
|
fun applyTo(branchConfig: BranchConfig): BranchConfig =
|
||||||
@@ -64,12 +64,12 @@ data class BuildDefinition(
|
|||||||
network = docker?.network ?: branchConfig.docker.network,
|
network = docker?.network ?: branchConfig.docker.network,
|
||||||
env = docker?.env ?: branchConfig.docker.env,
|
env = docker?.env ?: branchConfig.docker.env,
|
||||||
),
|
),
|
||||||
bwrap =
|
werkdock =
|
||||||
branchConfig.bwrap.copy(
|
branchConfig.werkdock.copy(
|
||||||
enabled = bwrap?.enabled ?: branchConfig.bwrap.enabled,
|
enabled = werkdock?.enabled ?: branchConfig.werkdock.enabled,
|
||||||
rootfs = bwrap?.rootfs ?: branchConfig.bwrap.rootfs,
|
rootfs = werkdock?.rootfs ?: branchConfig.werkdock.rootfs,
|
||||||
werkdock = bwrap?.werkdock ?: branchConfig.bwrap.werkdock,
|
binary = werkdock?.binary ?: branchConfig.werkdock.binary,
|
||||||
env = bwrap?.env ?: branchConfig.bwrap.env,
|
env = werkdock?.env ?: branchConfig.werkdock.env,
|
||||||
),
|
),
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -169,13 +169,13 @@ data class DockerOverrides(
|
|||||||
val env: Map<String, String>? = null,
|
val env: Map<String, String>? = null,
|
||||||
)
|
)
|
||||||
|
|
||||||
/** Nullable bubblewrap overrides of a [BuildDefinition]; null values inherit the branch's setting. */
|
/** Nullable werkdock overrides of a [BuildDefinition]; null values inherit the branch's setting. */
|
||||||
data class BwrapOverrides(
|
data class WerkdockOverrides(
|
||||||
/** Run the build in the bwrap sandbox instead of natively. Pinned — a branch must not escape its sandbox. */
|
/** Run the build in the sandbox instead of natively. Pinned — a branch must not escape its sandbox. */
|
||||||
val enabled: Boolean? = null,
|
val enabled: Boolean? = null,
|
||||||
/** Rootfs archive source. Pinned — a branch must not substitute a foreign rootfs. */
|
/** Rootfs archive source. Pinned — a branch must not substitute a foreign rootfs. */
|
||||||
val rootfs: String? = null,
|
val rootfs: String? = null,
|
||||||
/** The werkdock CLI executing the sandbox. Pinned — a branch must not substitute the executing binary. */
|
/** The werkdock CLI executing the sandbox. Pinned — a branch must not substitute the executing binary. */
|
||||||
val werkdock: String? = null,
|
val binary: String? = null,
|
||||||
val env: Map<String, String>? = null,
|
val env: Map<String, String>? = null,
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -201,10 +201,10 @@ class ConfigLoader(
|
|||||||
val strippedDocker = docker.toMutableMap().apply { PINNED_DOCKER_KEYS.forEach { remove(it) } }
|
val strippedDocker = docker.toMutableMap().apply { PINNED_DOCKER_KEYS.forEach { remove(it) } }
|
||||||
if (strippedDocker.isEmpty()) result.remove("docker") else result["docker"] = strippedDocker
|
if (strippedDocker.isEmpty()) result.remove("docker") else result["docker"] = strippedDocker
|
||||||
}
|
}
|
||||||
val bwrap = entry["bwrap"] as? Map<String, Any?>
|
val werkdock = entry["werkdock"] as? Map<String, Any?>
|
||||||
if (bwrap != null) {
|
if (werkdock != null) {
|
||||||
val strippedBwrap = bwrap.toMutableMap().apply { PINNED_BWRAP_KEYS.forEach { remove(it) } }
|
val strippedWerkdock = werkdock.toMutableMap().apply { PINNED_WERKDOCK_KEYS.forEach { remove(it) } }
|
||||||
if (strippedBwrap.isEmpty()) result.remove("bwrap") else result["bwrap"] = strippedBwrap
|
if (strippedWerkdock.isEmpty()) result.remove("werkdock") else result["werkdock"] = strippedWerkdock
|
||||||
}
|
}
|
||||||
return result
|
return result
|
||||||
}
|
}
|
||||||
@@ -481,14 +481,62 @@ class ConfigLoader(
|
|||||||
private fun loadFile(file: File): Map<String, Any?> {
|
private fun loadFile(file: File): Map<String, Any?> {
|
||||||
if (!file.exists()) return emptyMap()
|
if (!file.exists()) return emptyMap()
|
||||||
@Suppress("UNCHECKED_CAST")
|
@Suppress("UNCHECKED_CAST")
|
||||||
return yaml.readValue(file, Map::class.java) as Map<String, Any?>
|
return renameLegacySandbox(yaml.readValue(file, Map::class.java) as Map<String, Any?>, file.toString())
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Parses a `.werkator.yml` read from git (not from disk); blank or null yields no layer. */
|
/** Parses a `.werkator.yml` read from git (not from disk); blank or null yields no layer. */
|
||||||
private fun parseYaml(text: String?): Map<String, Any?> {
|
private fun parseYaml(text: String?): Map<String, Any?> {
|
||||||
if (text.isNullOrBlank()) return emptyMap()
|
if (text.isNullOrBlank()) return emptyMap()
|
||||||
@Suppress("UNCHECKED_CAST")
|
@Suppress("UNCHECKED_CAST")
|
||||||
return yaml.readValue(text, Map::class.java) as? Map<String, Any?> ?: emptyMap()
|
val raw = yaml.readValue(text, Map::class.java) as? Map<String, Any?> ?: emptyMap()
|
||||||
|
return renameLegacySandbox(raw, "the branch configuration")
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Reads the pre-PR#19 `bwrap` section under its new name `werkdock`, including its
|
||||||
|
* `werkdock` key which is `binary` now. Done on the raw map of every layer, before
|
||||||
|
* merging, so nothing downstream — merging, pinning, binding — knows two names.
|
||||||
|
*
|
||||||
|
* Renaming rather than rejecting: the section is written in the machine configuration
|
||||||
|
* of every webspace instance, which no repository tracks. The warning is what makes
|
||||||
|
* the old name go away; the hard refusal belongs to the release that sets
|
||||||
|
* [ConfigVersions.FORMAT_BROKE_IN], where a file declaring no version can be caught
|
||||||
|
* by name at all.
|
||||||
|
*/
|
||||||
|
@Suppress("UNCHECKED_CAST")
|
||||||
|
private fun renameLegacySandbox(
|
||||||
|
raw: Map<String, Any?>,
|
||||||
|
source: String,
|
||||||
|
): Map<String, Any?> {
|
||||||
|
var renamed = false
|
||||||
|
val result =
|
||||||
|
raw.mapValues { (section, value) ->
|
||||||
|
if (section != "builds" && section != "branches") {
|
||||||
|
return@mapValues value
|
||||||
|
}
|
||||||
|
val entries = value as? Map<String, Any?> ?: return@mapValues value
|
||||||
|
entries.mapValues inner@{ (_, entry) ->
|
||||||
|
val settings = entry as? Map<String, Any?> ?: return@inner entry
|
||||||
|
val legacy = settings["bwrap"] as? Map<String, Any?> ?: return@inner entry
|
||||||
|
renamed = true
|
||||||
|
val moved =
|
||||||
|
legacy.mapKeys { (key, _) -> if (key == "werkdock") "binary" else key }
|
||||||
|
val existing = settings["werkdock"] as? Map<String, Any?> ?: emptyMap()
|
||||||
|
settings.toMutableMap().apply {
|
||||||
|
remove("bwrap")
|
||||||
|
// an explicit werkdock section wins: the new name is the one meant
|
||||||
|
put("werkdock", moved + existing)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (renamed && warnedSections.add("bwrap-renamed:$source")) {
|
||||||
|
log.warn(
|
||||||
|
"reading the 'bwrap' section of {} as 'werkdock' (and 'bwrap.werkdock' as 'werkdock.binary'); " +
|
||||||
|
"rename it — the old name goes away with the next breaking configuration change",
|
||||||
|
source,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
return result
|
||||||
}
|
}
|
||||||
|
|
||||||
@Suppress("UNCHECKED_CAST")
|
@Suppress("UNCHECKED_CAST")
|
||||||
@@ -550,8 +598,8 @@ class ConfigLoader(
|
|||||||
/** `docker` keys a branch must never override: the sandbox policy. */
|
/** `docker` keys a branch must never override: the sandbox policy. */
|
||||||
private val PINNED_DOCKER_KEYS = setOf("enabled", "network")
|
private val PINNED_DOCKER_KEYS = setOf("enabled", "network")
|
||||||
|
|
||||||
/** `bwrap` keys a branch must never override: the sandbox policy (Step 17) and its executing binary. */
|
/** `werkdock` keys a branch must never override: the sandbox policy (Step 17) and its executing binary. */
|
||||||
private val PINNED_BWRAP_KEYS = setOf("enabled", "rootfs", "werkdock")
|
private val PINNED_WERKDOCK_KEYS = setOf("enabled", "rootfs", "binary")
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* The one key of a build definition that says *when* and *for which branches* it
|
* The one key of a build definition that says *when* and *for which branches* it
|
||||||
|
|||||||
@@ -38,9 +38,9 @@ data class WerkatorConfig(
|
|||||||
): BranchConfig {
|
): BranchConfig {
|
||||||
val branchConfig = branches[branch] ?: branches["default"] ?: BranchConfig()
|
val branchConfig = branches[branch] ?: branches["default"] ?: BranchConfig()
|
||||||
val settings = effectiveBuildDefinitions()[build]?.applyTo(branchConfig) ?: branchConfig
|
val settings = effectiveBuildDefinitions()[build]?.applyTo(branchConfig) ?: branchConfig
|
||||||
if (settings.docker.enabled && settings.bwrap.enabled) {
|
if (settings.docker.enabled && settings.werkdock.enabled) {
|
||||||
throw IllegalArgumentException(
|
throw IllegalArgumentException(
|
||||||
"builds.$build on '$branch' enables both docker and bwrap; a build runs in exactly one sandbox. " +
|
"builds.$build on '$branch' enables both docker and werkdock; a build runs in exactly one sandbox. " +
|
||||||
"Disable one of them.",
|
"Disable one of them.",
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
@@ -179,17 +179,22 @@ data class BranchConfig(
|
|||||||
val statusContext: String = "",
|
val statusContext: String = "",
|
||||||
val autoBuild: AutoBuildConfig = AutoBuildConfig(),
|
val autoBuild: AutoBuildConfig = AutoBuildConfig(),
|
||||||
val docker: DockerConfig = DockerConfig(),
|
val docker: DockerConfig = DockerConfig(),
|
||||||
/** bubblewrap user-namespace sandbox; mutually exclusive with [docker]. */
|
/** werkdock sandbox (bubblewrap user namespace); mutually exclusive with [docker]. */
|
||||||
val bwrap: BwrapConfig = BwrapConfig(),
|
val werkdock: WerkdockConfig = WerkdockConfig(),
|
||||||
)
|
)
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* bubblewrap build sandbox (Step 17): runs the build in an unprivileged user namespace
|
* The werkdock build sandbox (Step 17, executed by the werkdock CLI since step 21):
|
||||||
* with a prepared Debian root filesystem. For hosts without root and without a Docker
|
* runs the build in an unprivileged bubblewrap user namespace over a prepared Debian
|
||||||
* daemon (e.g. Hostsharing managed webspaces); see `docs/plan/17-bwrap-build-runtime.md`.
|
* root filesystem. For hosts without root and without a Docker daemon (e.g. Hostsharing
|
||||||
|
* managed webspaces); see `docs/plan/17-bwrap-build-runtime.md`.
|
||||||
|
*
|
||||||
|
* The section was called `bwrap` until PR#19 and is still read under that name, with a
|
||||||
|
* warning: `bwrap` named the mechanism one layer below the tool that actually runs it,
|
||||||
|
* which made `bwrap.werkdock` the key naming its own executor.
|
||||||
*/
|
*/
|
||||||
data class BwrapConfig(
|
data class WerkdockConfig(
|
||||||
/** Run the clean and build commands in a bwrap sandbox instead of natively. */
|
/** Run the clean and build commands in the sandbox instead of natively. */
|
||||||
val enabled: Boolean = false,
|
val enabled: Boolean = false,
|
||||||
/**
|
/**
|
||||||
* Path or URL of the prepared rootfs archive (e.g. `werkator-buildenv-trixie-java21.tar.zst`),
|
* Path or URL of the prepared rootfs archive (e.g. `werkator-buildenv-trixie-java21.tar.zst`),
|
||||||
@@ -200,8 +205,9 @@ data class BwrapConfig(
|
|||||||
/**
|
/**
|
||||||
* The werkdock CLI executing the sandbox (step 21 session C); empty or the default
|
* The werkdock CLI executing the sandbox (step 21 session C); empty or the default
|
||||||
* resolves via PATH. Pinned — a branch must not substitute the executing binary.
|
* resolves via PATH. Pinned — a branch must not substitute the executing binary.
|
||||||
|
* Was `bwrap.werkdock` until PR#19.
|
||||||
*/
|
*/
|
||||||
val werkdock: String = "werkdock",
|
val binary: String = "werkdock",
|
||||||
/** Additional environment variables set inside the sandbox. */
|
/** Additional environment variables set inside the sandbox. */
|
||||||
val env: Map<String, String> = emptyMap(),
|
val env: Map<String, String> = emptyMap(),
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -7,6 +7,16 @@
|
|||||||
<div th:replace="~{fragments :: nav(${view})}"></div>
|
<div th:replace="~{fragments :: nav(${view})}"></div>
|
||||||
<div class="panel release-notes">
|
<div class="panel release-notes">
|
||||||
|
|
||||||
|
<h2>v1.2.0 <span class="muted">— 2026-09-03</span></h2>
|
||||||
|
<ul>
|
||||||
|
<li>The build sandbox for hosts without Docker is configured as <code>werkdock</code> now,
|
||||||
|
not <code>bwrap</code> (PR#19), and its <code>bwrap.werkdock</code> key — which named its
|
||||||
|
own executor — is <code>werkdock.binary</code>. The old section is still read, with a
|
||||||
|
warning naming the file, so no installation has to be changed before its next
|
||||||
|
configuration edit. <code>bwrap</code> named the mechanism one layer below the tool that
|
||||||
|
actually runs it: builds have been executed by the werkdock CLI since v1.0.0.</li>
|
||||||
|
</ul>
|
||||||
|
|
||||||
<h2>v1.1.2 <span class="muted">— 2026-09-03</span></h2>
|
<h2>v1.1.2 <span class="muted">— 2026-09-03</span></h2>
|
||||||
<ul>
|
<ul>
|
||||||
<li>On a Hostsharing Managed Webspace, an <code>instance-update</code> restart no longer looks
|
<li>On a Hostsharing Managed Webspace, an <code>instance-update</code> restart no longer looks
|
||||||
|
|||||||
@@ -1,8 +1,8 @@
|
|||||||
package de.hoennig.werkator.build
|
package de.hoennig.werkator.build
|
||||||
|
|
||||||
import de.hoennig.werkator.config.BranchConfig
|
import de.hoennig.werkator.config.BranchConfig
|
||||||
import de.hoennig.werkator.config.BwrapConfig
|
|
||||||
import de.hoennig.werkator.config.DockerConfig
|
import de.hoennig.werkator.config.DockerConfig
|
||||||
|
import de.hoennig.werkator.config.WerkdockConfig
|
||||||
import io.kotest.core.spec.style.FunSpec
|
import io.kotest.core.spec.style.FunSpec
|
||||||
import io.kotest.matchers.shouldBe
|
import io.kotest.matchers.shouldBe
|
||||||
import io.mockk.Called
|
import io.mockk.Called
|
||||||
@@ -15,13 +15,13 @@ import java.nio.file.Paths
|
|||||||
class DispatchingBuildRunnerTest : FunSpec() {
|
class DispatchingBuildRunnerTest : FunSpec() {
|
||||||
private val processBuildRunner = mockk<ProcessBuildRunner>()
|
private val processBuildRunner = mockk<ProcessBuildRunner>()
|
||||||
private val dockerBuildRunner = mockk<DockerBuildRunner>()
|
private val dockerBuildRunner = mockk<DockerBuildRunner>()
|
||||||
private val bwrapBuildRunner = mockk<BwrapBuildRunner>()
|
private val werkdockBuildRunner = mockk<WerkdockBuildRunner>()
|
||||||
private val dispatcher = DispatchingBuildRunner(processBuildRunner, dockerBuildRunner, bwrapBuildRunner)
|
private val dispatcher = DispatchingBuildRunner(processBuildRunner, dockerBuildRunner, werkdockBuildRunner)
|
||||||
private val process = mockk<Process>()
|
private val process = mockk<Process>()
|
||||||
private val dir = Paths.get(".")
|
private val dir = Paths.get(".")
|
||||||
|
|
||||||
init {
|
init {
|
||||||
beforeEach { clearMocks(processBuildRunner, dockerBuildRunner, bwrapBuildRunner) }
|
beforeEach { clearMocks(processBuildRunner, dockerBuildRunner, werkdockBuildRunner) }
|
||||||
|
|
||||||
test("runs natively by default") {
|
test("runs natively by default") {
|
||||||
val branchConfig = BranchConfig()
|
val branchConfig = BranchConfig()
|
||||||
@@ -30,7 +30,7 @@ class DispatchingBuildRunnerTest : FunSpec() {
|
|||||||
dispatcher.start("cmd", dir, emptyMap(), dir, branchConfig) shouldBe process
|
dispatcher.start("cmd", dir, emptyMap(), dir, branchConfig) shouldBe process
|
||||||
|
|
||||||
verify { dockerBuildRunner wasNot Called }
|
verify { dockerBuildRunner wasNot Called }
|
||||||
verify { bwrapBuildRunner wasNot Called }
|
verify { werkdockBuildRunner wasNot Called }
|
||||||
}
|
}
|
||||||
|
|
||||||
test("runs in Docker when the branch enables it") {
|
test("runs in Docker when the branch enables it") {
|
||||||
@@ -40,12 +40,12 @@ class DispatchingBuildRunnerTest : FunSpec() {
|
|||||||
dispatcher.start("cmd", dir, emptyMap(), dir, branchConfig) shouldBe process
|
dispatcher.start("cmd", dir, emptyMap(), dir, branchConfig) shouldBe process
|
||||||
|
|
||||||
verify { processBuildRunner wasNot Called }
|
verify { processBuildRunner wasNot Called }
|
||||||
verify { bwrapBuildRunner wasNot Called }
|
verify { werkdockBuildRunner wasNot Called }
|
||||||
}
|
}
|
||||||
|
|
||||||
test("runs in bwrap when the branch enables it (and not Docker)") {
|
test("runs in the werkdock sandbox when the branch enables it (and not Docker)") {
|
||||||
val branchConfig = BranchConfig(bwrap = BwrapConfig(enabled = true, rootfs = "/srv/buildenv.tar.zst"))
|
val branchConfig = BranchConfig(werkdock = WerkdockConfig(enabled = true, rootfs = "/srv/buildenv.tar.zst"))
|
||||||
every { bwrapBuildRunner.start("cmd", dir, emptyMap(), dir, branchConfig) } returns process
|
every { werkdockBuildRunner.start("cmd", dir, emptyMap(), dir, branchConfig) } returns process
|
||||||
|
|
||||||
dispatcher.start("cmd", dir, emptyMap(), dir, branchConfig) shouldBe process
|
dispatcher.start("cmd", dir, emptyMap(), dir, branchConfig) shouldBe process
|
||||||
|
|
||||||
|
|||||||
+21
-21
@@ -1,7 +1,7 @@
|
|||||||
package de.hoennig.werkator.build
|
package de.hoennig.werkator.build
|
||||||
|
|
||||||
import de.hoennig.werkator.config.BranchConfig
|
import de.hoennig.werkator.config.BranchConfig
|
||||||
import de.hoennig.werkator.config.BwrapConfig
|
import de.hoennig.werkator.config.WerkdockConfig
|
||||||
import de.hoennig.werkator.git.GitCommandResult
|
import de.hoennig.werkator.git.GitCommandResult
|
||||||
import de.hoennig.werkator.git.GitCommandRunner
|
import de.hoennig.werkator.git.GitCommandRunner
|
||||||
import io.kotest.assertions.throwables.shouldThrow
|
import io.kotest.assertions.throwables.shouldThrow
|
||||||
@@ -15,20 +15,20 @@ import io.mockk.verify
|
|||||||
import java.nio.file.Files
|
import java.nio.file.Files
|
||||||
import java.nio.file.Path
|
import java.nio.file.Path
|
||||||
|
|
||||||
class BwrapBuildRunnerTest : FunSpec() {
|
class WerkdockBuildRunnerTest : FunSpec() {
|
||||||
private val commandRunner = mockk<GitCommandRunner>()
|
private val commandRunner = mockk<GitCommandRunner>()
|
||||||
private lateinit var runner: BwrapBuildRunner
|
private lateinit var runner: WerkdockBuildRunner
|
||||||
private lateinit var repoDir: Path
|
private lateinit var repoDir: Path
|
||||||
private lateinit var workspace: Path
|
private lateinit var workspace: Path
|
||||||
private val captured = mutableListOf<List<String>>()
|
private val captured = mutableListOf<List<String>>()
|
||||||
|
|
||||||
private fun bwrapBranchConfig(
|
private fun werkdockBranchConfig(
|
||||||
rootfs: String = "/srv/buildenv.tar.zst",
|
rootfs: String = "/srv/buildenv.tar.zst",
|
||||||
env: Map<String, String> = emptyMap(),
|
env: Map<String, String> = emptyMap(),
|
||||||
): BranchConfig =
|
): BranchConfig =
|
||||||
BranchConfig(
|
BranchConfig(
|
||||||
bwrap =
|
werkdock =
|
||||||
BwrapConfig(
|
WerkdockConfig(
|
||||||
enabled = true,
|
enabled = true,
|
||||||
rootfs = rootfs,
|
rootfs = rootfs,
|
||||||
env = env,
|
env = env,
|
||||||
@@ -52,9 +52,9 @@ class BwrapBuildRunnerTest : FunSpec() {
|
|||||||
beforeEach {
|
beforeEach {
|
||||||
clearMocks(commandRunner)
|
clearMocks(commandRunner)
|
||||||
captured.clear()
|
captured.clear()
|
||||||
repoDir = Files.createTempDirectory("werkator-bwrap-runner")
|
repoDir = Files.createTempDirectory("werkator-werkdock-runner")
|
||||||
workspace = repoDir.resolve("workspace")
|
workspace = repoDir.resolve("workspace")
|
||||||
runner = BwrapBuildRunner(commandRunner)
|
runner = WerkdockBuildRunner(commandRunner)
|
||||||
runner.processStarter = { command, _ ->
|
runner.processStarter = { command, _ ->
|
||||||
captured += command
|
captured += command
|
||||||
ProcessBuilder("true").start()
|
ProcessBuilder("true").start()
|
||||||
@@ -64,7 +64,7 @@ class BwrapBuildRunnerTest : FunSpec() {
|
|||||||
test("assembles the exact werkdock run command for a loaded image") {
|
test("assembles the exact werkdock run command for a loaded image") {
|
||||||
givenImageLoaded()
|
givenImageLoaded()
|
||||||
|
|
||||||
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, bwrapBranchConfig())
|
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, werkdockBranchConfig())
|
||||||
|
|
||||||
captured.single() shouldBe
|
captured.single() shouldBe
|
||||||
listOf(
|
listOf(
|
||||||
@@ -99,7 +99,7 @@ class BwrapBuildRunnerTest : FunSpec() {
|
|||||||
)
|
)
|
||||||
} returns GitCommandResult(0, "", "")
|
} returns GitCommandResult(0, "", "")
|
||||||
|
|
||||||
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, bwrapBranchConfig())
|
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, werkdockBranchConfig())
|
||||||
|
|
||||||
verify {
|
verify {
|
||||||
commandRunner.runOrThrow(
|
commandRunner.runOrThrow(
|
||||||
@@ -114,7 +114,7 @@ class BwrapBuildRunnerTest : FunSpec() {
|
|||||||
test("does not load an image werkdock already has") {
|
test("does not load an image werkdock already has") {
|
||||||
givenImageLoaded()
|
givenImageLoaded()
|
||||||
|
|
||||||
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, bwrapBranchConfig())
|
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, werkdockBranchConfig())
|
||||||
|
|
||||||
verify(exactly = 0) { commandRunner.runOrThrow(match { "load" in it }, any(), any(), any()) }
|
verify(exactly = 0) { commandRunner.runOrThrow(match { "load" in it }, any(), any(), any()) }
|
||||||
}
|
}
|
||||||
@@ -124,7 +124,7 @@ class BwrapBuildRunnerTest : FunSpec() {
|
|||||||
GitCommandResult(0, imageName() + "\n", "")
|
GitCommandResult(0, imageName() + "\n", "")
|
||||||
val branchConfig =
|
val branchConfig =
|
||||||
BranchConfig(
|
BranchConfig(
|
||||||
bwrap = BwrapConfig(enabled = true, rootfs = "/srv/buildenv.tar.zst", werkdock = "/opt/bin/werkdock"),
|
werkdock = WerkdockConfig(enabled = true, rootfs = "/srv/buildenv.tar.zst", binary = "/opt/bin/werkdock"),
|
||||||
)
|
)
|
||||||
|
|
||||||
runner.start("./gradlew test", workspace, emptyMap(), repoDir, branchConfig)
|
runner.start("./gradlew test", workspace, emptyMap(), repoDir, branchConfig)
|
||||||
@@ -136,7 +136,7 @@ class BwrapBuildRunnerTest : FunSpec() {
|
|||||||
givenImageLoaded()
|
givenImageLoaded()
|
||||||
val relativeWorkspace = repoDir.relativize(workspace)
|
val relativeWorkspace = repoDir.relativize(workspace)
|
||||||
|
|
||||||
runner.start("./gradlew test", relativeWorkspace, mapOf("branch" to "main"), repoDir, bwrapBranchConfig())
|
runner.start("./gradlew test", relativeWorkspace, mapOf("branch" to "main"), repoDir, werkdockBranchConfig())
|
||||||
|
|
||||||
val args = captured.single()
|
val args = captured.single()
|
||||||
val absolute = workspace.toAbsolutePath().normalize().toString()
|
val absolute = workspace.toAbsolutePath().normalize().toString()
|
||||||
@@ -145,7 +145,7 @@ class BwrapBuildRunnerTest : FunSpec() {
|
|||||||
args.count { it == "$absolute:$absolute" } shouldBe 1
|
args.count { it == "$absolute:$absolute" } shouldBe 1
|
||||||
}
|
}
|
||||||
|
|
||||||
test("adds bwrap env after the branch environment") {
|
test("adds the sandbox env after the branch environment") {
|
||||||
givenImageLoaded()
|
givenImageLoaded()
|
||||||
|
|
||||||
runner.start(
|
runner.start(
|
||||||
@@ -153,7 +153,7 @@ class BwrapBuildRunnerTest : FunSpec() {
|
|||||||
workspace,
|
workspace,
|
||||||
mapOf("branch" to "main"),
|
mapOf("branch" to "main"),
|
||||||
repoDir,
|
repoDir,
|
||||||
bwrapBranchConfig(env = mapOf("FOO" to "bar")),
|
werkdockBranchConfig(env = mapOf("FOO" to "bar")),
|
||||||
)
|
)
|
||||||
|
|
||||||
val args = captured.single()
|
val args = captured.single()
|
||||||
@@ -171,7 +171,7 @@ class BwrapBuildRunnerTest : FunSpec() {
|
|||||||
Files.writeString(workspace.resolve(".git"), "gitdir: $adminDir\n")
|
Files.writeString(workspace.resolve(".git"), "gitdir: $adminDir\n")
|
||||||
givenImageLoaded()
|
givenImageLoaded()
|
||||||
|
|
||||||
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, bwrapBranchConfig())
|
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, werkdockBranchConfig())
|
||||||
|
|
||||||
val args = captured.single()
|
val args = captured.single()
|
||||||
args[args.indexOf("$gitDir:$gitDir:ro") - 1] shouldBe "-v"
|
args[args.indexOf("$gitDir:$gitDir:ro") - 1] shouldBe "-v"
|
||||||
@@ -190,7 +190,7 @@ class BwrapBuildRunnerTest : FunSpec() {
|
|||||||
givenImageLoaded()
|
givenImageLoaded()
|
||||||
Files.createDirectories(workspace)
|
Files.createDirectories(workspace)
|
||||||
|
|
||||||
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, bwrapBranchConfig())
|
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, werkdockBranchConfig())
|
||||||
|
|
||||||
val args = captured.single()
|
val args = captured.single()
|
||||||
val gitDir = repoDir.resolve(".git")
|
val gitDir = repoDir.resolve(".git")
|
||||||
@@ -199,21 +199,21 @@ class BwrapBuildRunnerTest : FunSpec() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
test("fails without a configured rootfs") {
|
test("fails without a configured rootfs") {
|
||||||
val branchConfig = BranchConfig(bwrap = BwrapConfig(enabled = true))
|
val branchConfig = BranchConfig(werkdock = WerkdockConfig(enabled = true))
|
||||||
|
|
||||||
val exception =
|
val exception =
|
||||||
shouldThrow<IllegalArgumentException> {
|
shouldThrow<IllegalArgumentException> {
|
||||||
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, branchConfig)
|
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, branchConfig)
|
||||||
}
|
}
|
||||||
|
|
||||||
exception.message shouldContain "bwrap.rootfs"
|
exception.message shouldContain "werkdock.rootfs"
|
||||||
}
|
}
|
||||||
|
|
||||||
test("downloads a URL rootfs once before loading it") {
|
test("downloads a URL rootfs once before loading it") {
|
||||||
val url = "https://example.test/buildenv.tar.zst"
|
val url = "https://example.test/buildenv.tar.zst"
|
||||||
val downloadTarget =
|
val downloadTarget =
|
||||||
repoDir
|
repoDir
|
||||||
.resolve(BwrapBuildRunner.BUILDENV_DIR)
|
.resolve(WerkdockBuildRunner.BUILDENV_DIR)
|
||||||
.resolve(url.sha12())
|
.resolve(url.sha12())
|
||||||
.resolve("buildenv.tar.zst")
|
.resolve("buildenv.tar.zst")
|
||||||
givenImageMissing()
|
givenImageMissing()
|
||||||
@@ -222,7 +222,7 @@ class BwrapBuildRunnerTest : FunSpec() {
|
|||||||
every { commandRunner.runOrThrow(match { "load" in it }, any(), any(), any()) } returns
|
every { commandRunner.runOrThrow(match { "load" in it }, any(), any(), any()) } returns
|
||||||
GitCommandResult(0, "", "")
|
GitCommandResult(0, "", "")
|
||||||
|
|
||||||
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, bwrapBranchConfig(rootfs = url))
|
runner.start("./gradlew test", workspace, mapOf("branch" to "main"), repoDir, werkdockBranchConfig(rootfs = url))
|
||||||
|
|
||||||
verify {
|
verify {
|
||||||
commandRunner.runOrThrow(listOf("curl", "-fsSL", "-o", downloadTarget.toString(), url), repoDir, any(), any())
|
commandRunner.runOrThrow(listOf("curl", "-fsSL", "-o", downloadTarget.toString(), url), repoDir, any(), any())
|
||||||
@@ -496,7 +496,7 @@ class ConfigLoaderTest : FunSpec() {
|
|||||||
settings.docker.image shouldBe "attacker-image"
|
settings.docker.image shouldBe "attacker-image"
|
||||||
}
|
}
|
||||||
|
|
||||||
test("a branch cannot disable its bwrap sandbox or substitute a foreign rootfs through a build definition") {
|
test("the legacy bwrap section is read as werkdock, its werkdock key as binary") {
|
||||||
val dir = Files.createTempDirectory("werkator-test")
|
val dir = Files.createTempDirectory("werkator-test")
|
||||||
dir.resolve(".werkator.yml").toFile().writeText(
|
dir.resolve(".werkator.yml").toFile().writeText(
|
||||||
"""
|
"""
|
||||||
@@ -505,6 +505,58 @@ class ConfigLoaderTest : FunSpec() {
|
|||||||
bwrap:
|
bwrap:
|
||||||
enabled: true
|
enabled: true
|
||||||
rootfs: /host/rootfs.tar.zst
|
rootfs: /host/rootfs.tar.zst
|
||||||
|
werkdock: /opt/bin/werkdock
|
||||||
|
env:
|
||||||
|
FOO: bar
|
||||||
|
""".trimIndent(),
|
||||||
|
)
|
||||||
|
|
||||||
|
val settings = loader.load(dir).buildSettings("any-branch", "default")
|
||||||
|
|
||||||
|
settings.werkdock.enabled shouldBe true
|
||||||
|
settings.werkdock.rootfs shouldBe "/host/rootfs.tar.zst"
|
||||||
|
settings.werkdock.binary shouldBe "/opt/bin/werkdock"
|
||||||
|
settings.werkdock.env shouldBe mapOf("FOO" to "bar")
|
||||||
|
}
|
||||||
|
|
||||||
|
test("a legacy bwrap section on a branch is pinned exactly like the new name") {
|
||||||
|
val dir = Files.createTempDirectory("werkator-test")
|
||||||
|
dir.resolve(".werkator.yml").toFile().writeText(
|
||||||
|
"""
|
||||||
|
builds:
|
||||||
|
default:
|
||||||
|
werkdock:
|
||||||
|
enabled: true
|
||||||
|
rootfs: /host/rootfs.tar.zst
|
||||||
|
""".trimIndent(),
|
||||||
|
)
|
||||||
|
val worktree = Files.createTempDirectory("werkator-test-worktree")
|
||||||
|
// the old name must not become a way around the pinning
|
||||||
|
worktree.resolve(".werkator.yml").toFile().writeText(
|
||||||
|
"""
|
||||||
|
builds:
|
||||||
|
default:
|
||||||
|
bwrap:
|
||||||
|
enabled: false
|
||||||
|
rootfs: /attacker/rootfs.tar.zst
|
||||||
|
""".trimIndent(),
|
||||||
|
)
|
||||||
|
|
||||||
|
val settings = loader.loadForWorktree(dir, worktree).buildSettings("any-branch", "default")
|
||||||
|
|
||||||
|
settings.werkdock.enabled shouldBe true
|
||||||
|
settings.werkdock.rootfs shouldBe "/host/rootfs.tar.zst"
|
||||||
|
}
|
||||||
|
|
||||||
|
test("a branch cannot disable its werkdock sandbox or substitute a foreign rootfs through a build definition") {
|
||||||
|
val dir = Files.createTempDirectory("werkator-test")
|
||||||
|
dir.resolve(".werkator.yml").toFile().writeText(
|
||||||
|
"""
|
||||||
|
builds:
|
||||||
|
default:
|
||||||
|
werkdock:
|
||||||
|
enabled: true
|
||||||
|
rootfs: /host/rootfs.tar.zst
|
||||||
""".trimIndent(),
|
""".trimIndent(),
|
||||||
)
|
)
|
||||||
val worktree = Files.createTempDirectory("werkator-test-worktree")
|
val worktree = Files.createTempDirectory("werkator-test-worktree")
|
||||||
@@ -512,7 +564,7 @@ class ConfigLoaderTest : FunSpec() {
|
|||||||
"""
|
"""
|
||||||
builds:
|
builds:
|
||||||
default:
|
default:
|
||||||
bwrap:
|
werkdock:
|
||||||
enabled: false
|
enabled: false
|
||||||
rootfs: /attacker/rootfs.tar.zst
|
rootfs: /attacker/rootfs.tar.zst
|
||||||
env:
|
env:
|
||||||
@@ -523,10 +575,10 @@ class ConfigLoaderTest : FunSpec() {
|
|||||||
val settings = loader.loadForWorktree(dir, worktree).buildSettings("any-branch", "default")
|
val settings = loader.loadForWorktree(dir, worktree).buildSettings("any-branch", "default")
|
||||||
|
|
||||||
// pinned: the sandbox can neither be switched off nor pointed at a foreign rootfs
|
// pinned: the sandbox can neither be switched off nor pointed at a foreign rootfs
|
||||||
settings.bwrap.enabled shouldBe true
|
settings.werkdock.enabled shouldBe true
|
||||||
settings.bwrap.rootfs shouldBe "/host/rootfs.tar.zst"
|
settings.werkdock.rootfs shouldBe "/host/rootfs.tar.zst"
|
||||||
// everything that describes the build itself stays the branch's own business
|
// everything that describes the build itself stays the branch's own business
|
||||||
settings.bwrap.env shouldBe mapOf("FOO" to "from-branch")
|
settings.werkdock.env shouldBe mapOf("FOO" to "from-branch")
|
||||||
}
|
}
|
||||||
|
|
||||||
test("a build the branch invents inherits the host's sandbox policy") {
|
test("a build the branch invents inherits the host's sandbox policy") {
|
||||||
@@ -565,7 +617,7 @@ class ConfigLoaderTest : FunSpec() {
|
|||||||
settings.requirePullRequest shouldBe true
|
settings.requirePullRequest shouldBe true
|
||||||
}
|
}
|
||||||
|
|
||||||
test("enabling both docker and bwrap on a build is rejected, not picked silently") {
|
test("enabling both docker and werkdock on a build is rejected, not picked silently") {
|
||||||
val dir = Files.createTempDirectory("werkator-test")
|
val dir = Files.createTempDirectory("werkator-test")
|
||||||
dir.resolve(".werkator.yml").toFile().writeText(
|
dir.resolve(".werkator.yml").toFile().writeText(
|
||||||
"""
|
"""
|
||||||
@@ -574,7 +626,7 @@ class ConfigLoaderTest : FunSpec() {
|
|||||||
docker:
|
docker:
|
||||||
enabled: true
|
enabled: true
|
||||||
image: build-env
|
image: build-env
|
||||||
bwrap:
|
werkdock:
|
||||||
enabled: true
|
enabled: true
|
||||||
rootfs: /srv/rootfs.tar.zst
|
rootfs: /srv/rootfs.tar.zst
|
||||||
""".trimIndent(),
|
""".trimIndent(),
|
||||||
@@ -586,7 +638,7 @@ class ConfigLoaderTest : FunSpec() {
|
|||||||
config.buildSettings("any-branch", "default")
|
config.buildSettings("any-branch", "default")
|
||||||
}
|
}
|
||||||
|
|
||||||
exception.message shouldContain "both docker and bwrap"
|
exception.message shouldContain "both docker and werkdock"
|
||||||
exception.message shouldContain "builds.default"
|
exception.message shouldContain "builds.default"
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
+9
-5
@@ -50,8 +50,9 @@
|
|||||||
# unit, exactly as `init --systemd` derives it
|
# unit, exactly as `init --systemd` derives it
|
||||||
# WERKATOR_INSTALL_DIR directory holding the unpacked runtime bundle, absolute or
|
# WERKATOR_INSTALL_DIR directory holding the unpacked runtime bundle, absolute or
|
||||||
# relative to WERKATOR_PATH (default: .werkator)
|
# relative to WERKATOR_PATH (default: .werkator)
|
||||||
# WERKATOR_SANDBOX build runtime of the host: bwrap (default) or docker; a docker
|
# WERKATOR_SANDBOX build runtime of the host: werkdock (default, the bubblewrap
|
||||||
# host needs neither the werkdock binary nor a rootfs archive
|
# sandbox; `bwrap` is accepted as its former name) or docker —
|
||||||
|
# a docker host needs neither the werkdock binary nor a rootfs
|
||||||
# WERKDOCK_REPO checkout of the werkdock repository, whose binary the
|
# WERKDOCK_REPO checkout of the werkdock repository, whose binary the
|
||||||
# instance runs (default: <repo>/../werkdock)
|
# instance runs (default: <repo>/../werkdock)
|
||||||
# WERKDOCK_BINARY the built werkdock binary (default: $WERKDOCK_REPO/dist/werkdock)
|
# WERKDOCK_BINARY the built werkdock binary (default: $WERKDOCK_REPO/dist/werkdock)
|
||||||
@@ -137,10 +138,13 @@ REPO_DIR="$(resolve_dir "${WERKATOR_REPO_DIR:-werkator}")"
|
|||||||
INSTALL_DIR="$(resolve_dir "${WERKATOR_INSTALL_DIR:-.werkator}")"
|
INSTALL_DIR="$(resolve_dir "${WERKATOR_INSTALL_DIR:-.werkator}")"
|
||||||
# where `repo-add` puts a further repository of the registry: beside the watched one
|
# where `repo-add` puts a further repository of the registry: beside the watched one
|
||||||
SIBLING_DIR="$(dirname "$REPO_DIR")"
|
SIBLING_DIR="$(dirname "$REPO_DIR")"
|
||||||
SANDBOX="${WERKATOR_SANDBOX:-bwrap}"
|
SANDBOX="${WERKATOR_SANDBOX:-werkdock}"
|
||||||
|
# `bwrap` was the name of the config section until Werkator v1.2.0; accepted so an env
|
||||||
|
# file written for the older script keeps working, normalised so only one name is used.
|
||||||
|
[ "$SANDBOX" = "bwrap" ] && SANDBOX="werkdock"
|
||||||
case "$SANDBOX" in
|
case "$SANDBOX" in
|
||||||
bwrap|docker) ;;
|
werkdock|docker) ;;
|
||||||
*) die "WERKATOR_SANDBOX is 'bwrap' or 'docker', not '$SANDBOX'" ;;
|
*) die "WERKATOR_SANDBOX is 'werkdock' or 'docker', not '$SANDBOX'" ;;
|
||||||
esac
|
esac
|
||||||
|
|
||||||
MACHINE_CONFIG="$REPO_DIR/.git/werkator/.werkator.yml"
|
MACHINE_CONFIG="$REPO_DIR/.git/werkator/.werkator.yml"
|
||||||
|
|||||||
Reference in New Issue
Block a user