fix(config): a build definition can say docker.socket #72

2026-09-15T20:56:30+02:00

mi commented

2026-09-15 20:56:30 +02:00

PR#55 added docker.socket to DockerConfig and to both pinning lists, but
not to DockerOverrides. The key was parsed, pinned and enforced, and then
dropped when the definition was applied — leaving the default false.

Since ADR 0007 the sandbox lives under builds..docker, so the key
was unreachable from the only section a current configuration uses; only
the deprecated branches section could set it, which is where the existing
test put it. On vm4006 this cost every Testcontainers test: the socket was
never mounted, and the build found no Docker environment at all.

Beside the three-line fix, a test now compares DockerConfig against
DockerOverrides and WerkdockConfig against WerkdockOverrides, so a key
added to a sandbox and forgotten in its overrides fails the build.

Co-Authored-By: Claude Opus 5 noreply@anthropic.com

PR#55 added docker.socket to DockerConfig and to both pinning lists, but not to DockerOverrides. The key was parsed, pinned and enforced, and then dropped when the definition was applied — leaving the default false. Since ADR 0007 the sandbox lives under builds.<name>.docker, so the key was unreachable from the only section a current configuration uses; only the deprecated branches section could set it, which is where the existing test put it. On vm4006 this cost every Testcontainers test: the socket was never mounted, and the build found no Docker environment at all. Beside the three-line fix, a test now compares DockerConfig against DockerOverrides and WerkdockConfig against WerkdockOverrides, so a key added to a sandbox and forgotten in its overrides fails the build. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

mi added 1 commit 2026-09-15 20:56:31 +02:00

fix(config): a build definition can say docker.socket

werkator build succeeded after 02:15

Details

4002dd793d

PR#55 added docker.socket to DockerConfig and to both pinning lists, but
not to DockerOverrides. The key was parsed, pinned and enforced, and then
dropped when the definition was applied — leaving the default false.

Since ADR 0007 the sandbox lives under builds.<name>.docker, so the key
was unreachable from the only section a current configuration uses; only
the deprecated branches section could set it, which is where the existing
test put it. On vm4006 this cost every Testcontainers test: the socket was
never mounted, and the build found no Docker environment at all.

Beside the three-line fix, a test now compares DockerConfig against
DockerOverrides and WerkdockConfig against WerkdockOverrides, so a key
added to a sandbox and forgotten in its overrides fails the build.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

mi merged commit 9f5f99aa86 into main

2026-09-15 20:56:53 +02:00

mi deleted branch docker-socket-override

2026-09-15 20:56:53 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mi/werkator#72