The watcher state, the System page and the Current page name no private repository's work to a visitor (v1.43.9) #169

Merged
ai-reviewer merged 2 commits from claude-code/private-names-redacted into main 2026-10-24 21:22:48 +02:00
Collaborator

See docs/prs/2026-10-24-PR#169-private-names-redacted.md

🤖 Generated with Claude Code

See docs/prs/2026-10-24-PR#169-private-names-redacted.md 🤖 Generated with [Claude Code](https://claude.com/claude-code)
claude-code marked the pull request as ready for review 2026-10-24 20:41:11 +02:00
Collaborator
🟢 werkrevisor GREEN for 6ca504b, superseded by the result for 88c5edf

🟢 werkrevisor: GREEN / PASS

Change kind: mixed.

Reasons

  • hint 12 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev
  • hint 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.02)
  • hint 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (each larger than [review] max_full_file_chars = 80000): src/main/resources/templates/releases.html
  • hint 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (all full files together would exceed [review] max_full_files_chars = 160000): src/test/kotlin/de/javagil/werkator/server/UiBuildListsRestTest.kt

Classifier

9 of 9 units passed all questions (1 PR document(s)).
2 answers ignored because of a confidence below [classifier] min_confidence.

Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 61856, calls 1, tokens in 59434 / out 31191 (reasoning included in out), duration 260.9 s, cost 0.0552 USD (reported), classifier `jev-1.14.0` calls 9, tokens in 7345, cost 0.0003 USD, excerpt selection `openrouter/openai/gpt-6-luna` calls 2, tokens in 38497 / out 405, cost 0.0050 USD (reported), build file judge `jev-1.14.0` calls 13, tokens in 18583, cost 0.0008 USD, phases: path_judge 0.6 s, classifier 0.4 s, context 7.2 s, model_review 252.3 s, config: defaults + host + repository (.werkrevisor.toml at main 9e6dff6).
Reviewed head `6ca504ba4b7d5dc4271e09b10aa36c96ecadafa2` against base `9e6dff6bbc9553c913a3c091fdea237d6f7aad12`, werkrevisor 0.66.0.
<!-- werkrevisor:6ca504ba4b7d5dc4271e09b10aa36c96ecadafa2 --> <!-- werkrevisor-verdict:GREEN --> <!-- werkrevisor-blocks:9631d2bd8370f626f55bcae9d8aa808e,2a14935bf74ca8be400c7504393888ee,a1c0d0721e4631a047947433ac6f6faf,61634832e42424ae0fe36200f3a66b1d,412151f470633cf162f5b6a20c849db1,67a47b92edcd871b50fb3eb8cf8357c4,930df80a9a5edbc45f387bbe350df55d,935420a237f977e9d737177f48c8441f,df1964ff1421e658f250b2bb69fd11f9,d1916a262aaa23cb9661fdd26955c6e1,92cdeac36c44fbcb591bfcccd37c52a5,ad137f136dce7e4941606cfd40299a89,529f4db2938c0cd3f5882a07fefe531b,fda23643d672a6edfcc8c500ca8763ce,661f72ad5442008f0c813e73f874492e,5e0a254d2fa238a1d0c7fd3c8febbd8d,99df1c0768f0747f4874017166b5cb52,0648009508d22b3b133366eb35eb1559,5932264f111de8a713dcc5ff06b84b85,c4d7e52cc9dd88554593a85861f09397,ca3da5f8c6fcf994451cf1948f6c6992,a085c3085179a5afa87672fa24a78038,f3edc250582712236b8e9c9e860527e1,ddce74a53924baa99396b1709ee3a14b,6dc1d7bc9fd67d766c50bd6770f687d6,92bf01547344cb29e81c8402bb88550e,dc5ea6e3bc09df988a8b168bc2c87c1e,501488091c710153d1907d7027e46901,ea9390d2a01522033a1a445e89cb63e2,184eef8f42260a44cd18aca9bc500b70,d8921f70e98a102e48dccdfbb31e62e0,cf6ae5245d88448566a7439e64492068,d1225de99b5171d9f41b72073163e356,6a6003d888909f1cd26d165e449dc0f2,6256a4e43dbc18627f102b9cf2af3518,b6569d579eda9615d369faee0d0d66ec,6fbef5ec7042078c0b899dc688a87046,079e2d2b7c478bb09e808047d50e8490,65b8f5358da77a8a9fdb3cc50d375330,52cc80be05329c8a411a0e47701a3187 --> <!-- werkrevisor-folded --> <details><summary>🟢 werkrevisor GREEN for <code>6ca504b</code>, superseded by <a href="http://git.javagil.de/mi/werkator/pulls/169#issuecomment-7802">the result for <code>88c5edf</code></a></summary> ## 🟢 werkrevisor: GREEN / PASS Change kind: `mixed`. ### Reasons - **hint** 12 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev - **hint** 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.02) - **hint** 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (each larger than [review] max_full_file_chars = 80000): src/main/resources/templates/releases.html - **hint** 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (all full files together would exceed [review] max_full_files_chars = 160000): src/test/kotlin/de/javagil/werkator/server/UiBuildListsRestTest.kt ### Classifier 9 of 9 units passed all questions (1 PR document(s)). 2 answers ignored because of a confidence below [classifier] min_confidence. <sub> Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 61856, calls 1, tokens in 59434 / out 31191 (reasoning included in out), duration 260.9 s, cost 0.0552 USD (reported), classifier `jev-1.14.0` calls 9, tokens in 7345, cost 0.0003 USD, excerpt selection `openrouter/openai/gpt-6-luna` calls 2, tokens in 38497 / out 405, cost 0.0050 USD (reported), build file judge `jev-1.14.0` calls 13, tokens in 18583, cost 0.0008 USD, phases: path_judge 0.6 s, classifier 0.4 s, context 7.2 s, model_review 252.3 s, config: defaults + host + repository (.werkrevisor.toml at main 9e6dff6).<br> Reviewed head `6ca504ba4b7d5dc4271e09b10aa36c96ecadafa2` against base `9e6dff6bbc9553c913a3c091fdea237d6f7aad12`, werkrevisor 0.66.0. </sub> </details>
ai-reviewer approved these changes 2026-10-24 20:45:43 +02:00
Dismissed
ai-reviewer left a comment
Collaborator

werkrevisor: GREEN / PASS for 6ca504ba4b7d5dc4271e09b10aa36c96ecadafa2.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `6ca504ba4b7d5dc4271e09b10aa36c96ecadafa2`. The result comment of werkrevisor holds the details. <!-- werkrevisor-review:6ca504ba4b7d5dc4271e09b10aa36c96ecadafa2 -->
ai-reviewer scheduled this pull request to auto merge when all checks succeed 2026-10-24 20:45:44 +02:00
Collaborator

Codex review: critical

The change controls disclosure of private repository content based on control-token authorization. A mistake could expose confidential repository names, build details, or error messages to unauthenticated visitors, so human review is required.

No findings.

The merge waits for the status ai-review/codex: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here.

Model `gpt-6-astra`, effort high, tokens in 395074 (cached 327936) / out 1781, 54.4 s, 14 commands; reviewed head `6ca504ba4b7d5dc4271e09b10aa36c96ecadafa2`.
<!-- werkrevisor-codex:6ca504ba4b7d5dc4271e09b10aa36c96ecadafa2 --> <!-- werkrevisor-codex-critical:true --> <!-- werkrevisor-codex-unattached:0 --> <!-- werkrevisor-codex --> ## Codex review: critical The change controls disclosure of private repository content based on control-token authorization. A mistake could expose confidential repository names, build details, or error messages to unauthenticated visitors, so human review is required. No findings. The merge waits for the status `ai-review/codex`: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here. <sub> Model `gpt-6-astra`, effort high, tokens in 395074 (cached 327936) / out 1781, 54.4 s, 14 commands; reviewed head `6ca504ba4b7d5dc4271e09b10aa36c96ecadafa2`. </sub>
claude-code added 2 commits 2026-10-24 20:53:35 +02:00
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The watcher state, the System page and the Current page name no private repository's work to a visitor (v1.43.9)
ai-review/assessment AI review passed; approved by werkrevisor; merge already scheduled
ai-review/gate build succeeded after 04:04
ai-review/codex done ✅: Codex review passed
werkator build succeeded after 02:17
88c5edf4e4
/api/watcher answered the names of private repositories, of their queued builds and git's
error text; /api/system and the System page named their running builds; the first paint of
the Current page held branch, commit and artifact key. All three now use RepoRouting.hidden,
like every other route (RFC 0003, D8).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-code force-pushed claude-code/private-names-redacted from 6ca504ba4b to 88c5edf4e4 2026-10-24 20:53:35 +02:00 Compare
claude-code dismissed ai-reviewer's review 2026-10-24 20:53:36 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Collaborator

🟢 werkrevisor: GREEN / PASS

Change kind: mixed.

Reasons

  • hint approval of werkrevisor for 6ca504b not carried over: 1 approved block(s) are missing
  • hint 12 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev
  • hint 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.02)
  • hint 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (each larger than [review] max_full_file_chars = 80000): src/main/resources/templates/releases.html
  • hint 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (all full files together would exceed [review] max_full_files_chars = 160000): src/test/kotlin/de/javagil/werkator/server/UiBuildListsRestTest.kt
  • hint 1 changed file was given to the AI only as diff, not in full, so it could not check it against the rest of its file (all full files together would exceed [review] max_full_files_chars = 160000, and no excerpt fits the limits either): src/test/kotlin/de/javagil/werkator/server/WatcherApiControllerRestTest.kt (advisory: Jev judged every changed file)

Classifier

9 of 9 units passed all questions (1 PR document(s)).
2 answers ignored because of a confidence below [classifier] min_confidence.

Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 60044, calls 1, tokens in 57685 / out 32258 (reasoning included in out), duration 240.8 s, cost 0.0560 USD (reported), classifier `jev-1.14.0` calls 9, tokens in 7345, cost 0.0003 USD, excerpt selection `openrouter/openai/gpt-6-luna` calls 3, tokens in 42004 / out 705, cost 0.0049 USD (reported), build file judge `jev-1.14.0` calls 13, tokens in 18579, cost 0.0008 USD, phases: path_judge 0.6 s, classifier 0.5 s, context 10.8 s, model_review 228.4 s, config: defaults + host + repository (.werkrevisor.toml at main 7fabc11).
Reviewed head `88c5edf4e411ee91f43077878001481117b32e5e` against base `7fabc116005b848038e10946b6e2fe43e00111a5`, werkrevisor 0.66.0.
<!-- werkrevisor:88c5edf4e411ee91f43077878001481117b32e5e --> <!-- werkrevisor-verdict:GREEN --> <!-- werkrevisor-blocks:81acc36d2a6b62245f37612b3d3a5e8e,2a14935bf74ca8be400c7504393888ee,a1c0d0721e4631a047947433ac6f6faf,61634832e42424ae0fe36200f3a66b1d,412151f470633cf162f5b6a20c849db1,67a47b92edcd871b50fb3eb8cf8357c4,930df80a9a5edbc45f387bbe350df55d,935420a237f977e9d737177f48c8441f,df1964ff1421e658f250b2bb69fd11f9,d1916a262aaa23cb9661fdd26955c6e1,92cdeac36c44fbcb591bfcccd37c52a5,ad137f136dce7e4941606cfd40299a89,529f4db2938c0cd3f5882a07fefe531b,fda23643d672a6edfcc8c500ca8763ce,661f72ad5442008f0c813e73f874492e,5e0a254d2fa238a1d0c7fd3c8febbd8d,99df1c0768f0747f4874017166b5cb52,0648009508d22b3b133366eb35eb1559,5932264f111de8a713dcc5ff06b84b85,c4d7e52cc9dd88554593a85861f09397,ca3da5f8c6fcf994451cf1948f6c6992,a085c3085179a5afa87672fa24a78038,f3edc250582712236b8e9c9e860527e1,ddce74a53924baa99396b1709ee3a14b,6dc1d7bc9fd67d766c50bd6770f687d6,92bf01547344cb29e81c8402bb88550e,dc5ea6e3bc09df988a8b168bc2c87c1e,501488091c710153d1907d7027e46901,ea9390d2a01522033a1a445e89cb63e2,184eef8f42260a44cd18aca9bc500b70,d8921f70e98a102e48dccdfbb31e62e0,cf6ae5245d88448566a7439e64492068,d1225de99b5171d9f41b72073163e356,6a6003d888909f1cd26d165e449dc0f2,6256a4e43dbc18627f102b9cf2af3518,b6569d579eda9615d369faee0d0d66ec,6fbef5ec7042078c0b899dc688a87046,079e2d2b7c478bb09e808047d50e8490,65b8f5358da77a8a9fdb3cc50d375330,52cc80be05329c8a411a0e47701a3187 --> ## 🟢 werkrevisor: GREEN / PASS Change kind: `mixed`. ### Reasons - **hint** approval of werkrevisor for `6ca504b` not carried over: 1 approved block(s) are missing - **hint** 12 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev - **hint** 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.02) - **hint** 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (each larger than [review] max_full_file_chars = 80000): src/main/resources/templates/releases.html - **hint** 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (all full files together would exceed [review] max_full_files_chars = 160000): src/test/kotlin/de/javagil/werkator/server/UiBuildListsRestTest.kt - **hint** 1 changed file was given to the AI only as diff, not in full, so it could not check it against the rest of its file (all full files together would exceed [review] max_full_files_chars = 160000, and no excerpt fits the limits either): src/test/kotlin/de/javagil/werkator/server/WatcherApiControllerRestTest.kt (advisory: Jev judged every changed file) ### Classifier 9 of 9 units passed all questions (1 PR document(s)). 2 answers ignored because of a confidence below [classifier] min_confidence. <sub> Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 60044, calls 1, tokens in 57685 / out 32258 (reasoning included in out), duration 240.8 s, cost 0.0560 USD (reported), classifier `jev-1.14.0` calls 9, tokens in 7345, cost 0.0003 USD, excerpt selection `openrouter/openai/gpt-6-luna` calls 3, tokens in 42004 / out 705, cost 0.0049 USD (reported), build file judge `jev-1.14.0` calls 13, tokens in 18579, cost 0.0008 USD, phases: path_judge 0.6 s, classifier 0.5 s, context 10.8 s, model_review 228.4 s, config: defaults + host + repository (.werkrevisor.toml at main 7fabc11).<br> Reviewed head `88c5edf4e411ee91f43077878001481117b32e5e` against base `7fabc116005b848038e10946b6e2fe43e00111a5`, werkrevisor 0.66.0. </sub>
ai-reviewer left a comment
Collaborator

werkrevisor: GREEN / PASS for 88c5edf4e411ee91f43077878001481117b32e5e.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `88c5edf4e411ee91f43077878001481117b32e5e`. The result comment of werkrevisor holds the details. <!-- werkrevisor-review:88c5edf4e411ee91f43077878001481117b32e5e -->
Collaborator

Codex review: critical

The change controls which private repository content unauthenticated visitors can see, including error messages, build identifiers, and cached responses. A mistake could disclose confidential information, so human review is required.

No findings.

The merge waits for the status ai-review/codex: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here.

Model `gpt-6-astra`, effort high, tokens in 383897 (cached 320000) / out 1349, 46.4 s, 11 commands; reviewed head `88c5edf4e411ee91f43077878001481117b32e5e`.
<!-- werkrevisor-codex:88c5edf4e411ee91f43077878001481117b32e5e --> <!-- werkrevisor-codex-critical:true --> <!-- werkrevisor-codex-unattached:0 --> <!-- werkrevisor-codex --> ## Codex review: critical The change controls which private repository content unauthenticated visitors can see, including error messages, build identifiers, and cached responses. A mistake could disclose confidential information, so human review is required. No findings. The merge waits for the status `ai-review/codex`: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here. <sub> Model `gpt-6-astra`, effort high, tokens in 383897 (cached 320000) / out 1349, 46.4 s, 11 commands; reviewed head `88c5edf4e411ee91f43077878001481117b32e5e`. </sub>
mi approved these changes 2026-10-24 21:16:45 +02:00
ai-reviewer merged commit aa0602e5c3 into main 2026-10-24 21:22:48 +02:00
ai-reviewer deleted branch claude-code/private-names-redacted 2026-10-24 21:22:48 +02:00
Sign in to join this conversation.
No Reviewers
No labels
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mi/werkator#169