The gap filler of the metrics history has no loop, so its mutants no longer run out of memory (v1.43.2) #162

Merged

ai-reviewer merged 3 commits from claude-code/history-nulls-no-loop into main 2026-10-14 16:23:44 +02:00

Conversation 3 Commits 3 Files Changed 5

+66 -2

claude-code commented 2026-10-14 16:11:01 +02:00

Collaborator

Copy Link

Copy Source

See docs/prs/2026-10-14-PR#162-history-nulls-without-loop.md

🤖 Generated with Claude Code

See docs/prs/2026-10-14-PR#162-history-nulls-without-loop.md 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-code added 1 commit 2026-10-14 16:11:02 +02:00

The gap filler of the metrics history has no loop, so its mutants no longer run out of memory (v1.43.2) ... 734a489081

HistoryTier.nulls was List(size) { null }, a counting loop; PIT's mutants of
its counter never end it, and on 2026-10-14 two ran out of memory instead of
into the timeout. werkcrappit reports MEMORY_ERROR as inconclusive, so the
nightly Mutation-CRAP gate failed. arrayOfNulls(size).asList() has no loop.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-code added 1 commit 2026-10-14 16:12:25 +02:00

PR-doc: the local PIT measurement of HistoryTier ... 441e689164

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-code added 1 commit 2026-10-14 16:16:07 +02:00

Rerun CI: the build of 441e689 stopped mid-test without a failure ... e9d47b9924

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-code marked the pull request as ready for review 2026-10-14 16:18:55 +02:00

ai-reviewer commented 2026-10-14 16:19:39 +02:00

Collaborator

Copy Link

Copy Source

🟢 werkrevisor: GREEN / PASS

Change kind: mixed.

Reasons

• hint deferred TODOs in the PR document: docs/prs/2026-10-14-PR#162-history-nulls-without-loop.md:50: - [ ] TODO.werkcrappit: PIT counts 'MEMORY_ERROR' as detected, werkcrappit as inconclusive.
• hint 2 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev
• hint 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.01)
• hint 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (each larger than [review] max_full_file_chars = 80000): src/main/resources/templates/releases.html

Classifier

5 of 5 units passed all questions (1 PR document(s)).
3 answers ignored because of a confidence below [classifier] min_confidence.

_{Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 18834, calls 1, tokens in 18130 / out 3047 (reasoning included in out), duration 31.5 s, cost 0.0091 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3941, cost 0.0002 USD, excerpt selection `openrouter/openai/gpt-6-luna` calls 1, tokens in 31805 / out 127, cost 0.0040 USD (reported), build file judge `jev-1.13.0` calls 3, tokens in 3639, cost 0.0002 USD, phases: path_judge 0.3 s, classifier 0.4 s, context 2.9 s, model_review 27.6 s, config: defaults + host + repository (.werkrevisor.toml at main fc84913).
Reviewed head `e9d47b9924bbb9998f07b2f1ee109384ddb5979f` against base `fc84913a4a78e92da02f77f15d5f3799f54652cf`, werkrevisor 0.41.2.}

<!-- werkrevisor:e9d47b9924bbb9998f07b2f1ee109384ddb5979f --> <!-- werkrevisor-verdict:GREEN --> <!-- werkrevisor-blocks:a797770d6abc7ab727500ffcb066a7d1,d0b558965672af12e093d057f919aae1,b0d37570fc50b684e41298af99e7010e,cdd823f14907ea5a76ffa8b618388573,9316e9525eef4bedc7fbd75d9656ae7b --> ## 🟢 werkrevisor: GREEN / PASS Change kind: `mixed`. ### Reasons - **hint** deferred TODOs in the PR document: docs/prs/2026-10-14-PR#162-history-nulls-without-loop.md:50: `- [ ] TODO.werkcrappit: PIT counts 'MEMORY_ERROR' as detected, werkcrappit as inconclusive.` - **hint** 2 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev - **hint** 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.01) - **hint** 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (each larger than [review] max_full_file_chars = 80000): src/main/resources/templates/releases.html ### Classifier 5 of 5 units passed all questions (1 PR document(s)). 3 answers ignored because of a confidence below [classifier] min_confidence. _{Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 18834, calls 1, tokens in 18130 / out 3047 (reasoning included in out), duration 31.5 s, cost 0.0091 USD (reported), classifier `jev-1.13.0` calls 5, tokens in 3941, cost 0.0002 USD, excerpt selection `openrouter/openai/gpt-6-luna` calls 1, tokens in 31805 / out 127, cost 0.0040 USD (reported), build file judge `jev-1.13.0` calls 3, tokens in 3639, cost 0.0002 USD, phases: path_judge 0.3 s, classifier 0.4 s, context 2.9 s, model_review 27.6 s, config: defaults + host + repository (.werkrevisor.toml at main fc84913).<br> Reviewed head `e9d47b9924bbb9998f07b2f1ee109384ddb5979f` against base `fc84913a4a78e92da02f77f15d5f3799f54652cf`, werkrevisor 0.41.2.}

ai-reviewer approved these changes 2026-10-14 16:19:40 +02:00

ai-reviewer left a comment

Collaborator

Copy Link

Copy Source

werkrevisor: GREEN / PASS for e9d47b9924bbb9998f07b2f1ee109384ddb5979f.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `e9d47b9924bbb9998f07b2f1ee109384ddb5979f`. The result comment of werkrevisor holds the details. <!-- werkrevisor-review:e9d47b9924bbb9998f07b2f1ee109384ddb5979f -->

ai-reviewer scheduled this pull request to auto merge when all checks succeed 2026-10-14 16:19:40 +02:00

ai-reviewer commented 2026-10-14 16:23:42 +02:00

Collaborator

Copy Link

Copy Source

Codex review: not critical

The change preserves null-padding behavior in metrics history, and both callers immediately copy the result when appending a value. It changes no security controls, stored-data format, tests, or CI gates.

No findings.

The merge waits for the status ai-review/codex: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here.

_{Model `gpt-6-astra`, effort high, tokens in 94553 (cached 54272) / out 449, 27.8 s, 5 commands; reviewed head `e9d47b9924bbb9998f07b2f1ee109384ddb5979f`.}

<!-- werkrevisor-codex:e9d47b9924bbb9998f07b2f1ee109384ddb5979f --> <!-- werkrevisor-codex-critical:false --> <!-- werkrevisor-codex-unattached:0 --> <!-- werkrevisor-codex --> ## Codex review: not critical The change preserves null-padding behavior in metrics history, and both callers immediately copy the result when appending a value. It changes no security controls, stored-data format, tests, or CI gates. No findings. The merge waits for the status `ai-review/codex`: every line comment resolved, and the approval of a human for a critical PR or for a finding that is only here. _{Model `gpt-6-astra`, effort high, tokens in 94553 (cached 54272) / out 449, 27.8 s, 5 commands; reviewed head `e9d47b9924bbb9998f07b2f1ee109384ddb5979f`.}

ai-reviewer merged commit b470c1d080 into main 2026-10-14 16:23:44 +02:00

ai-reviewer deleted branch claude-code/history-nulls-no-loop 2026-10-14 16:23:44 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

ai-reviewer

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

ai-reviewer claude-code mi

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mi/werkator#162