A failed build is shown as outdated once its branch is gone or a newer build ended #156

2026-10-12T15:35:32+02:00

claude-code commented

2026-10-12 15:35:32 +02:00

A failed or timed-out run is outdated once its branch is deleted or a newer run of its name ended with a verdict. The History shows it grey with an outdated tag that gives the reason, and the home strip draws it grey.

🤖 Generated with Claude Code

See [the PR-doc](docs/prs/2026-10-12-PR%23156-outdated-failures.md). A failed or timed-out run is outdated once its branch is deleted or a newer run of its name ended with a verdict. The History shows it grey with an `outdated` tag that gives the reason, and the home strip draws it grey. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-code added 1 commit 2026-10-12 15:35:33 +02:00

WIP: outdated failed builds (v1.42.0)

werkator build failed after 07:32

Details

f3d73ed319

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-code added 1 commit 2026-10-12 15:50:20 +02:00

A failed build is shown as outdated once its branch is gone or a newer build ended (v1.42.0)

werkator build succeeded after 06:20

Details

ai-review/assessment AI review passed; approved by werkrevisor; merge waits for 2 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit

Details

ai-review/gate build succeeded after 04:55

Details

a7fce6d762

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-code marked the pull request as ready for review 2026-10-12 15:57:10 +02:00

ai-reviewer commented

2026-10-12 16:02:03 +02:00

🟢 werkrevisor GREEN for a7fce6d, superseded by the result for 981409b

🟢 werkrevisor: GREEN / PASS

Gate: approved by werkrevisor; merge waits for 2 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit.

Change kind: mixed.

Reasons

hint writing rules violated in the changed docs: .claude/skills/architecture/SKILL.md:47: line longer than 400 characters (512)
hint 19 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev
hint 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.01)
hint 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (each larger than [review] max_full_file_chars = 80000): src/main/resources/static/werkator.js
hint 1 changed file was given to the AI only as diff, not in full, so it could not check it against the rest of its file (each larger than [review] max_full_file_chars = 80000, and no excerpt fits the limits either): src/main/resources/templates/releases.html (advisory: Jev judged every changed file)
hint 4 changed files were given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (all full files together would exceed [review] max_full_files_chars = 160000): src/main/kotlin/de/hoennig/werkator/server/UiViews.kt, src/main/resources/static/werkator.css, src/main/resources/templates/home.html and 1 more
hint 5 changed files were given to the AI only as diff, not in full, so it could not check them against the rest of their file (all full files together would exceed [review] max_full_files_chars = 160000, and no excerpt fits the limits either): src/test/kotlin/de/hoennig/werkator/build/OutdatedRunsUnitTest.kt, src/test/kotlin/de/hoennig/werkator/server/BuildsApiControllerRestTest.kt, src/test/kotlin/de/hoennig/werkator/server/RepoOverviewsUnitTest.kt and 2 more (advisory: Jev judged every changed file)
hint 2 finding(s) of low severity or rated minor by Jev: docs/werkator.werkbaum:174-175, docs/prs/2026-10-12-PR#156-outdated-failures.md:114

Findings

[low] Grammar issue in Werkbaum task title at docs/werkator.werkbaum:174-175

hint

The new Werkbaum entry "A failure a newer run or a deleted branch overtook is shown as outdated" is missing the relative pronoun that introduces the relative clause. As written, "a failure" is followed by another noun phrase starting with "a" and an intransitive past-tense verb, so the relationship between the failure and what overtook it is left unexpressed. A clearer phrasing would be "A failure that a newer run or a deleted branch overtook" or "A failure overtaken by a newer run or a deleted branch". This is a wording nit; the meaning is recoverable from context.
[low] Awkward phrasing in scenario title at docs/prs/2026-10-12-PR#156-outdated-failures.md:114, hint, as a line comment

Classifier

11 of 11 units passed all questions (1 PR document(s)).
1 answer ignored because of a confidence below [classifier] min_confidence.

_{Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 71074, calls 1, tokens in 68399 / out 29105 (reasoning included in out), duration 276.7 s, cost 0.0554 USD (reported), classifier `jev-1.13.0` calls 11, tokens in 10274, cost 0.0004 USD, finding judge `none` calls 0, tokens in 0, cost 0.0000 USD, excerpt selection `openrouter/openai/gpt-6-luna` calls 11, tokens in 141491 / out 1938, cost 0.0187 USD (reported), build file judge `jev-1.13.0` calls 20, tokens in 28210, cost 0.0012 USD, phases: path_judge 1.3 s, classifier 0.8 s, context 36.5 s, model_review 236.4 s, finding_judge 0.0 s, config: defaults + host + repository (.werkrevisor.toml at main faa86e0).

Reviewed head `a7fce6d76268352315994cfe5e2b0ba978c99b52` against base `faa86e060b9aece97c20627912bdb450e9e68fa5`, werkrevisor 0.38.0.}

<details><summary>🟢 werkrevisor GREEN for <code>a7fce6d</code>, superseded by <a href="http://git.javagil.de/mi/werkator/pulls/156#issuecomment-4722">the result for <code>981409b</code></a></summary> ## 🟢 werkrevisor: GREEN / PASS Gate: approved by werkrevisor; merge waits for 2 open hint(s): reply to each line comment and resolve it, then restart the review or push a commit. Change kind: `mixed`. ### Reasons - **hint** writing rules violated in the changed docs: .claude/skills/architecture/SKILL.md:47: line longer than 400 characters (512) - **hint** 19 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev - **hint** 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.01) - **hint** 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (each larger than [review] max_full_file_chars = 80000): src/main/resources/static/werkator.js - **hint** 1 changed file was given to the AI only as diff, not in full, so it could not check it against the rest of its file (each larger than [review] max_full_file_chars = 80000, and no excerpt fits the limits either): src/main/resources/templates/releases.html (advisory: Jev judged every changed file) - **hint** 4 changed files were given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (all full files together would exceed [review] max_full_files_chars = 160000): src/main/kotlin/de/hoennig/werkator/server/UiViews.kt, src/main/resources/static/werkator.css, src/main/resources/templates/home.html and 1 more - **hint** 5 changed files were given to the AI only as diff, not in full, so it could not check them against the rest of their file (all full files together would exceed [review] max_full_files_chars = 160000, and no excerpt fits the limits either): src/test/kotlin/de/hoennig/werkator/build/OutdatedRunsUnitTest.kt, src/test/kotlin/de/hoennig/werkator/server/BuildsApiControllerRestTest.kt, src/test/kotlin/de/hoennig/werkator/server/RepoOverviewsUnitTest.kt and 2 more (advisory: Jev judged every changed file) - **hint** 2 finding(s) of low severity or rated minor by Jev: docs/werkator.werkbaum:174-175, docs/prs/2026-10-12-PR#156-outdated-failures.md:114 ### Findings 1. **[low] Grammar issue in Werkbaum task title** at `docs/werkator.werkbaum:174-175` hint The new Werkbaum entry "A failure a newer run or a deleted branch overtook is shown as outdated" is missing the relative pronoun that introduces the relative clause. As written, "a failure" is followed by another noun phrase starting with "a" and an intransitive past-tense verb, so the relationship between the failure and what overtook it is left unexpressed. A clearer phrasing would be "A failure that a newer run or a deleted branch overtook" or "A failure overtaken by a newer run or a deleted branch". This is a wording nit; the meaning is recoverable from context. 2. **[low] Awkward phrasing in scenario title** at `docs/prs/2026-10-12-PR#156-outdated-failures.md:114`, hint, as a line comment ### Classifier 11 of 11 units passed all questions (1 PR document(s)). 1 answer ignored because of a confidence below [classifier] min_confidence. Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 71074, calls 1, tokens in 68399 / out 29105 (reasoning included in out), duration 276.7 s, cost 0.0554 USD (reported), classifier `jev-1.13.0` calls 11, tokens in 10274, cost 0.0004 USD, finding judge `none` calls 0, tokens in 0, cost 0.0000 USD, excerpt selection `openrouter/openai/gpt-6-luna` calls 11, tokens in 141491 / out 1938, cost 0.0187 USD (reported), build file judge `jev-1.13.0` calls 20, tokens in 28210, cost 0.0012 USD, phases: path_judge 1.3 s, classifier 0.8 s, context 36.5 s, model_review 236.4 s, finding_judge 0.0 s, config: defaults + host + repository (.werkrevisor.toml at main faa86e0). Reviewed head `a7fce6d76268352315994cfe5e2b0ba978c99b52` against base `faa86e060b9aece97c20627912bdb450e9e68fa5`, werkrevisor 0.38.0. </details>

ai-reviewer approved these changes

2026-10-12 16:02:04 +02:00

Dismissed

ai-reviewer left a comment

werkrevisor: GREEN / PASS for a7fce6d76268352315994cfe5e2b0ba978c99b52.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `a7fce6d76268352315994cfe5e2b0ba978c99b52`. The result comment of werkrevisor holds the details.

.claude/skills/architecture/SKILL.md Outdated

						
				@@ -44,6 +44,8 @@ Wherever a branch name is shown — the Latest, Branches, History and Current Bu

				The History page carries the build-duration trend above its table (`BuildDurationTrends`, PR#49): one card per build *definition* — never per branch, since a branch leaves two or three measurements and disappears — over the last 30 successful builds, however old (PR#84; a time window left rarely built repositories without a trend and let a slow drift become the median), showing the series, the median with min and max, and the latest run's distance from that median, amber from a quarter above it. Derived on read from the recorded history, so nothing is stored; since records outlive their artifacts (up to 100 per build name), a single-branch build such as a nightly or release build has a series too; the median rather than the average is what makes pooling every branch of one definition affordable. Served as `GET /api/builds/durations` (repository-scoped like every route), which answers a private repository with an empty list rather than a redacted one — not because the timings are secret (they are metadata, and `latest`/`branches`/`history` hand them out) but because a card is grouped by build definition, and redacting that name to `n/a` leaves every card labelled alike and the list saying nothing. `UiFormats.trendDelta` and its `werkator.js` twin must word the distance identically.

				A failed or timed-out run is *outdated* once its branch is gone from origin or a newer run of its name ended with a verdict — `success`, `failed` or `timed_out`, never `pending`, `running`, `cancelled` or `interrupted` (`OutdatedRuns`, PR#156): derived on read over the whole history, carried as `BuildResultDto.outdated` and `RecentBuildDto.outdated`, and shown grey with an `outdated` tag in the History and as a grey bar in the home strip; `UiFormats.outdatedTitle` and its `werkator.js` twin word the reason.

ai-reviewer commented

2026-10-12 16:02:04 +02:00

Writing rule: line longer than 400 characters (512) (werkrevisor writing rule)

Fix the line, or reply why it stays, and resolve this comment.

**Writing rule: line longer than 400 characters (512)** (werkrevisor writing rule) Fix the line, or reply why it stays, and resolve this comment.

claude-code commented

2026-10-12 16:03:09 +02:00

Fixed in 981409b: the paragraph is split into four sentences, one per line, each under 400 characters.

Fixed in 981409b: the paragraph is split into four sentences, one per line, each under 400 characters.

claude-code marked this conversation as resolved

docs/prs/2026-10-12-PR#156-outdated-failures.md Outdated

						
				@@ -0,0 +111,4 @@

				- [RepoOverviewsUnitTest: the strip marks a failure a newer run overtook](../../src/test/kotlin/de/hoennig/werkator/server/RepoOverviewsUnitTest.kt)

				- [UiViewsUnitTest: an outdated failure is a grey bar of its own height](../../src/test/kotlin/de/hoennig/werkator/server/UiViewsUnitTest.kt)

				#### Scenario#156.07: A private repository tells why a run is outdated, but not with what!

ai-reviewer commented

2026-10-12 16:02:04 +02:00

[low] Awkward phrasing in scenario title (werkrevisor)

hint

The Scenario#156.07 title ends with "but not with what!", which does not name what is redacted. The scenario body makes the intent clear (the reason, the outcome and the time of the newer run stay; its commit becomes n/a and its page is not linked), but the title alone does not convey that. A clearer phrasing would be "but not which newer build" or "but not with which data".

**[low] Awkward phrasing in scenario title** (werkrevisor) hint The Scenario#156.07 title ends with "but not with what!", which does not name what is redacted. The scenario body makes the intent clear (the reason, the outcome and the time of the newer run stay; its commit becomes `n/a` and its page is not linked), but the title alone does not convey that. A clearer phrasing would be "but not which newer build" or "but not with which data".

claude-code commented

2026-10-12 16:03:05 +02:00

Fixed in 981409b: the title now says "but not which commit superseded it".

Fixed in 981409b: the title now says "but not which commit superseded it".

claude-code marked this conversation as resolved

claude-code added 1 commit 2026-10-12 16:03:00 +02:00

Review: Werkbaum wording, scenario title, skill lines split

ai-review/assessment AI review passed; approved by werkrevisor; merge scheduled for when the checks succeed

Details

ai-review/gate build succeeded after 03:53

Details

werkator build succeeded after 04:24

Details

981409b6f9

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-code dismissed ai-reviewer's review 2026-10-12 16:03:00 +02:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

ai-reviewer commented

2026-10-12 16:06:56 +02:00

🟢 werkrevisor: GREEN / PASS

Change kind: mixed.

Reasons

hint approval of werkrevisor for a7fce6d not carried over: 3 approved block(s) are missing
hint 19 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev
hint 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.01)
hint 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (each larger than [review] max_full_file_chars = 80000): src/main/resources/templates/releases.html
hint 1 changed file was given to the AI only as diff, not in full, so it could not check it against the rest of its file (each larger than [review] max_full_file_chars = 80000, and no excerpt fits the limits either): src/main/resources/static/werkator.js (advisory: Jev judged every changed file)
hint 1 changed file was given to the AI as excerpt with 40 lines around each changed line, not in full (all full files together would exceed [review] max_full_files_chars = 160000): src/main/resources/static/werkator.css
hint 4 changed files were given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (all full files together would exceed [review] max_full_files_chars = 160000): src/main/kotlin/de/hoennig/werkator/server/UiViews.kt, src/main/resources/templates/builds.html, src/main/resources/templates/home.html and 1 more
hint 5 changed files were given to the AI only as diff, not in full, so it could not check them against the rest of their file (all full files together would exceed [review] max_full_files_chars = 160000, and no excerpt fits the limits either): src/test/kotlin/de/hoennig/werkator/build/OutdatedRunsUnitTest.kt, src/test/kotlin/de/hoennig/werkator/server/BuildsApiControllerRestTest.kt, src/test/kotlin/de/hoennig/werkator/server/RepoOverviewsUnitTest.kt and 2 more (advisory: Jev judged every changed file)
hint excerpt selection by openrouter/openai/gpt-6-luna failed, the fixed window was used: src/main/resources/static/werkator.css (a range lies outside the file), src/main/resources/static/werkator.js (a range lies outside the file)

Classifier

11 of 11 units passed all questions (1 PR document(s)).

_{Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 71824, calls 1, tokens in 69062 / out 13823 (reasoning included in out), duration 228.2 s, cost 0.0373 USD (reported), classifier `jev-1.13.0` calls 11, tokens in 10278, cost 0.0004 USD, excerpt selection `openrouter/openai/gpt-6-luna` calls 12, tokens in 144540 / out 2244, cost 0.0029 USD (reported), build file judge `jev-1.13.0` calls 20, tokens in 28210, cost 0.0012 USD, phases: path_judge 1.4 s, classifier 0.8 s, context 55.7 s, model_review 169.0 s, config: defaults + host + repository (.werkrevisor.toml at main faa86e0).

Reviewed head `981409b6f9e26d1683a0185482c398300292cd84` against base `faa86e060b9aece97c20627912bdb450e9e68fa5`, werkrevisor 0.38.0.}

## 🟢 werkrevisor: GREEN / PASS Change kind: `mixed`. ### Reasons - **hint** approval of werkrevisor for `a7fce6d` not carried over: 3 approved block(s) are missing - **hint** 19 changed file(s) that neither weaken the checks, touch security nor show a risk category of jvm-spring-backend according to Jev - **hint** 1 build change(s) of low risk according to Jev: build.gradle.kts (weakens checks 0.03, risk 0.00, security 0.01) - **hint** 1 changed file was given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (each larger than [review] max_full_file_chars = 80000): src/main/resources/templates/releases.html - **hint** 1 changed file was given to the AI only as diff, not in full, so it could not check it against the rest of its file (each larger than [review] max_full_file_chars = 80000, and no excerpt fits the limits either): src/main/resources/static/werkator.js (advisory: Jev judged every changed file) - **hint** 1 changed file was given to the AI as excerpt with 40 lines around each changed line, not in full (all full files together would exceed [review] max_full_files_chars = 160000): src/main/resources/static/werkator.css - **hint** 4 changed files were given to the AI as excerpt of the selected lines and 5 lines around each changed line, not in full (all full files together would exceed [review] max_full_files_chars = 160000): src/main/kotlin/de/hoennig/werkator/server/UiViews.kt, src/main/resources/templates/builds.html, src/main/resources/templates/home.html and 1 more - **hint** 5 changed files were given to the AI only as diff, not in full, so it could not check them against the rest of their file (all full files together would exceed [review] max_full_files_chars = 160000, and no excerpt fits the limits either): src/test/kotlin/de/hoennig/werkator/build/OutdatedRunsUnitTest.kt, src/test/kotlin/de/hoennig/werkator/server/BuildsApiControllerRestTest.kt, src/test/kotlin/de/hoennig/werkator/server/RepoOverviewsUnitTest.kt and 2 more (advisory: Jev judged every changed file) - **hint** excerpt selection by openrouter/openai/gpt-6-luna failed, the fixed window was used: src/main/resources/static/werkator.css (a range lies outside the file), src/main/resources/static/werkator.js (a range lies outside the file) ### Classifier 11 of 11 units passed all questions (1 PR document(s)). Usage: model `openrouter/minimax/minimax-m3`, LLM done, tokens counted before the call 71824, calls 1, tokens in 69062 / out 13823 (reasoning included in out), duration 228.2 s, cost 0.0373 USD (reported), classifier `jev-1.13.0` calls 11, tokens in 10278, cost 0.0004 USD, excerpt selection `openrouter/openai/gpt-6-luna` calls 12, tokens in 144540 / out 2244, cost 0.0029 USD (reported), build file judge `jev-1.13.0` calls 20, tokens in 28210, cost 0.0012 USD, phases: path_judge 1.4 s, classifier 0.8 s, context 55.7 s, model_review 169.0 s, config: defaults + host + repository (.werkrevisor.toml at main faa86e0). Reviewed head `981409b6f9e26d1683a0185482c398300292cd84` against base `faa86e060b9aece97c20627912bdb450e9e68fa5`, werkrevisor 0.38.0.

ai-reviewer approved these changes

2026-10-12 16:06:56 +02:00

ai-reviewer left a comment

werkrevisor: GREEN / PASS for 981409b6f9e26d1683a0185482c398300292cd84.
The result comment of werkrevisor holds the details.

werkrevisor: GREEN / PASS for `981409b6f9e26d1683a0185482c398300292cd84`. The result comment of werkrevisor holds the details.

ai-reviewer scheduled this pull request to auto merge when all checks succeed 2026-10-12 16:06:56 +02:00

ai-reviewer merged commit c218a0c0c2 into main

2026-10-12 16:07:34 +02:00

ai-reviewer deleted branch claude-code/outdated-failures

2026-10-12 16:07:34 +02:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mi/werkator#156