added permanent artifact links for latest green builds: /branches/<branch-key>/... serves the latest green build's artifacts (green-only, resolved per request), keepLatestGreen retention protection, permanent artifact-index page, and latestGreenUrl links in the branches view

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 15:35:16 +02:00
parent 83e70e73c3
commit bb06c8b731
25 changed files with 820 additions and 18 deletions
@@ -0,0 +1,86 @@
+package de.hoennig.gittally.server
+
+import de.hoennig.gittally.build.ArtifactKeys
+import de.hoennig.gittally.build.BuildResult
+import de.hoennig.gittally.build.BuildResultRepository
+import de.hoennig.gittally.build.BuildStatus
+import io.kotest.assertions.throwables.shouldThrow
+import io.kotest.core.spec.style.FunSpec
+import io.kotest.matchers.shouldBe
+import io.kotest.matchers.string.shouldContain
+import io.mockk.every
+import io.mockk.mockk
+import org.springframework.http.HttpStatus
+import org.springframework.web.server.ResponseStatusException
+import java.time.Duration
+import java.time.Instant
+
+class BranchPermalinksTest : FunSpec() {
+    private val repository = mockk<BuildResultRepository>()
+    private val permalinks = BranchPermalinks(repository)
+
+    private fun result(
+        branch: String,
+        status: BuildStatus = BuildStatus.SUCCESS,
+    ) = BuildResult(
+        branch = branch,
+        commit = "0123456789abcdef",
+        status = status,
+        startedAt = Instant.parse("2026-07-07T10:00:00Z"),
+        duration = Duration.ofSeconds(83),
+        artifactKey = "$branch-key",
+    )
+
+    init {
+        test("resolves the hash-free permanent key to the branch's latest green build") {
+            every { repository.latestPerBranch() } returns listOf(result("feature/x"), result("main"))
+            every { repository.latestGreenFor("feature/x") } returns result("feature/x")
+
+            permalinks.latestGreenBuild("feature_x") shouldBe result("feature/x")
+        }
+
+        test("resolves the full branch key with hash suffix") {
+            every { repository.latestPerBranch() } returns listOf(result("feature/x"))
+            every { repository.latestGreenFor("feature/x") } returns result("feature/x")
+
+            permalinks.latestGreenBuild(ArtifactKeys.branchKey("feature/x")) shouldBe result("feature/x")
+        }
+
+        test("an unknown branch key answers 404") {
+            every { repository.latestPerBranch() } returns listOf(result("main"))
+
+            val exception = shouldThrow<ResponseStatusException> { permalinks.latestGreenBuild("gone") }
+
+            exception.statusCode shouldBe HttpStatus.NOT_FOUND
+        }
+
+        test("a branch without a green build answers 404") {
+            every { repository.latestPerBranch() } returns listOf(result("main", status = BuildStatus.FAILED))
+            every { repository.latestGreenFor("main") } returns null
+
+            val exception = shouldThrow<ResponseStatusException> { permalinks.latestGreenBuild("main") }
+
+            exception.statusCode shouldBe HttpStatus.NOT_FOUND
+        }
+
+        test("a permanent key matching several branches answers 409 and names the candidates") {
+            every { repository.latestPerBranch() } returns listOf(result("feature/x"), result("feature_x"))
+
+            val exception = shouldThrow<ResponseStatusException> { permalinks.latestGreenBuild("feature_x") }
+
+            exception.statusCode shouldBe HttpStatus.CONFLICT
+            exception.reason.orEmpty() shouldContain "feature/x"
+        }
+
+        test("with ambiguous permanent keys the full branch key still resolves") {
+            every { repository.latestPerBranch() } returns listOf(result("feature/x"), result("feature_x"))
+            every { repository.latestGreenFor("feature/x") } returns result("feature/x")
+
+            permalinks.latestGreenBuild(ArtifactKeys.branchKey("feature/x")) shouldBe result("feature/x")
+        }
+
+        test("permanentUrl uses the hash-free branch key") {
+            BranchPermalinks.permanentUrl("feature/x") shouldBe "/branches/feature_x"
+        }
+    }
+}