Review round of b8d51a68: the ORANGE finding is wrong (answered in its thread); the scenarios are reworded in cba9ba1.
Not a problem, no change: the assignment script="…" is in double quotes, so $(cat "$(dirname "$0")/release_files.py") runs locally and puts the file into the string; only the escaped `$(cat…
Review round of the first head: the hint is fixed in b8d51a6.
Fixed in b8d51a6: after the sixth refused attempt the script gives up at once; it waits only between attempts, 30 to 150 s.
Review round of 8e11f82d: the ORANGE finding is wrong, answered without a change; the grep reads .werkator.yml. ORANGE and the YELLOW for tools/build-rootfs need the approval of the human user.
Not a problem, no change: line 47 reads grep -ohE 'werkrevisor-rootfs-[0-9]+(\.[0-9]+)+\.tar\.zst' ~/*/.git/werkator/.werkator.yml, the same file that line 38 edits. The pattern names the…
Review round of 8a2c9168: the ORANGE finding is fixed in 8e11f82. The YELLOW for tools/build-rootfs stays: the build now deletes old archives and image tags, which needs the approval of the…
Fixed in 8e11f82: an existing backup of the same version stays; only the first deploy of a version writes it.
Answer to the werkrevisor review of f12afc5:
- Finding, unclear wording at line 30: it means "version 1.38.1, a patch, because only the tooling of the nightly build changes". The PR was merged…
